Small-fix batch: artist_metadata sweep, and the three unbounded surfaces (#248, #249) #255

Merged

yonlu merged 6 commits from batch/248-249 into main 2026-09-21 02:01:55 +00:00

Conversation 0 Commits 6 Files Changed 10

+306 -5

6 Commits

Author	SHA1	Message	Date
yonlu	8dbdb7ad75	Merge branch 'fix/249-unbounded-growth' into batch/248-249 ... Both branches add to the same two registries, so the conflicts are between the two fixes rather than with main: - backend/app.go: both register a janitor job. Both are registered. - backend/maintenance/sweeps.go: both append a job at the end of the file. Both are kept, each with its own closing tail. - backend/maintenance/maintenance_test.go: both append a test. Both are kept as separate functions. - backend/library/library.go: #249's orphan-path lyrics delete was written against the loop variable before #250 renamed it, so its `audioFile.ID` no longer exists in that function. Adapted to `f.ID`. Closes #248 Closes #249	2026-09-20 21:40:49 -04:00
yonlu	a205224a26	Merge branch 'fix/248-artist-metadata-sweep' into batch/248-249	2026-09-20 21:34:50 -04:00
yonlu	a96cc9be1f	Merge remote-tracking branch 'origin/main' into fix/248-artist-metadata-sweep	2026-09-20 21:15:14 -04:00
yonlu	cf90030463	chore(bindings): regenerate for the queue's DropSourceForPlaylist ... frontend/bindings is generated by wails3 and is not covered by the codegen pre-commit hook, so the new bound method went out without it and make bindings-check failed on the PR.	2026-09-20 20:22:16 -04:00
yonlu	88f5524aa2	fix(maintenance): bound lyrics search and clicks, clear queue source ... Three unbounded or stale surfaces, each small on its own: - lyrics_index rows were never pruned on track removal, so the FTS index grew forever. Delete the entry where the library search FTS entry is already deleted, on the orphan and RemoveFromLibrary paths. - search_clicks had no ceiling; age out ranking rows after a retention window via a daily janitor job. - queue.source_* kept a "Playing from X" label after its playlist was deleted. Drop the source when the queue's own playlist goes, wired through a playlist-service hook like Library.SetRemovalHooks. Closes #249	2026-09-11 17:14:41 -04:00
yonlu	e745acf88a	fix(maintenance): sweep artist_metadata rows nothing references ... artist_metadata was classified Cache/Swept but had no sweep and no DELETE anywhere, so long-lived entity data (no TTL by design) grew for the life of the install. Sweep rows whose MBID is neither a library artist nor holding cached artwork, and register the job with the janitor. Closes #248	2026-09-09 10:16:32 -04:00