yonlu/yellowjacket
1
1
Fork 0
Code Issues 51 Pull Requests 4 Actions Packages Projects Releases 12 Wiki Activity

Unbounded growth: search_clicks, lyrics_index, and stale queue source #249

New Issue
Open
opened 2026-09-09 13:57:49 +00:00 by yonlu · 1 comment
yonlu commented 2026-09-09 13:57:49 +00:00
Owner
Copy Link
Copy Source

Report

Three persisted surfaces grow without bound, and one cosmetic fact goes
stale. These are not data loss, so they are one janitorial issue rather
than three.

Findings

  • search_clicks (Authored, Retained) has no ceiling. Deliberately
    retained, but every distinct query→MBID the user clicks is a row
    forever; nothing states a bound.
  • lyrics_index rows are never pruned on track removal. The orphan and
    RemoveFromLibrary paths call DeleteSearchIndex for the library
    FTS but nothing touches lyrics_index. Harmless to results (the
    search inner-joins track_metadata, so dead rowids drop out) but the
    index grows. contentless_delete=1 makes a single-row delete valid,
    so this is cheap to fix.
  • queue.source_type/source_id/source_label go stale when their source
    playlist or library is deleted — the player still says "Playing from: X"
    for something that no longer exists. Cosmetic.

Direction

  • Give search_clicks a documented budget or a TTL (it is behavioural
    ranking data; a cap on retained rows is enough).
  • Prune the lyrics_index entry (and the lyrics row, which already
    cascades) where DeleteSearchIndex is already called.
  • Clear or re-resolve queue.source_* on playlist/library deletion.
**Report** Three persisted surfaces grow without bound, and one cosmetic fact goes stale. These are not data loss, so they are one janitorial issue rather than three. **Findings** - `search_clicks` (`Authored, Retained`) has no ceiling. Deliberately retained, but every distinct query→MBID the user clicks is a row forever; nothing states a bound. - `lyrics_index` rows are never pruned on track removal. The orphan and `RemoveFromLibrary` paths call `DeleteSearchIndex` for the library FTS but nothing touches `lyrics_index`. Harmless to results (the search inner-joins `track_metadata`, so dead rowids drop out) but the index grows. `contentless_delete=1` makes a single-row delete valid, so this is cheap to fix. - `queue.source_type/source_id/source_label` go stale when their source playlist or library is deleted — the player still says "Playing from: X" for something that no longer exists. Cosmetic. **Direction** - Give `search_clicks` a documented budget or a TTL (it is behavioural ranking data; a cap on retained rows is enough). - Prune the `lyrics_index` entry (and the `lyrics` row, which already cascades) where `DeleteSearchIndex` is already called. - Clear or re-resolve `queue.source_*` on playlist/library deletion.
yonlu added the Kind/Enhancement
Priority
Low
4
Platform/AndroidPlatform/Desktop labels 2026-09-09 13:57:49 +00:00
yonlu self-assigned this 2026-09-09 13:58:20 +00:00
yonlu added the
Status
In Progress
 label 2026-09-09 13:58:21 +00:00
yonlu commented 2026-09-09 13:58:21 +00:00
Author
Owner
Copy Link
Copy Source

Branch: fix/249-unbounded-growth

Approach: prune lyrics_index on the removal paths where DeleteSearchIndex is already called; clear or re-resolve queue.source_* on playlist/library delete; give search_clicks a documented row ceiling or TTL. Small, three independent edits, one PR.

Branch: fix/249-unbounded-growth Approach: prune lyrics_index on the removal paths where DeleteSearchIndex is already called; clear or re-resolve queue.source_* on playlist/library delete; give search_clicks a documented row ceiling or TTL. Small, three independent edits, one PR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Kind/Enhancement Platform/Android Platform/Desktop
Priority
Low
4
Status
In Progress
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#249