yonlu/yellowjacket
1
1
Fork 0
Code Issues 51 Pull Requests 4 Actions Packages Projects Releases 12 Wiki Activity

artist_metadata is classified Swept but never swept #248

New Issue
Open
opened 2026-09-09 13:57:39 +00:00 by yonlu · 1 comment
yonlu commented 2026-09-09 13:57:39 +00:00
Owner
Copy Link
Copy Source

Report

artist_metadata is classified Cache, Swept in the datamap — "swept
when the artist is no longer referenced" — but no sweep exists and no
DELETE FROM artist_metadata appears anywhere in the tree. It is a
long-lived enrichment store (no TTL by design), so rows accumulate for
the life of the install.

Findings

  • backend/datamap/datamap.go:128 declares Cache, Swept.
  • The only references are the read/write in backend/explore/cache.go:137,161.
  • The maintenance runner (backend/app.go:777-790) registers
    http_cache, cover files, artist images and the proxy cache — nothing
    for artist_metadata.

Direction

Either add a sweep (keyed on artist_metadata.mbid no longer being
referenced by a library artist or any artist_images/artist_enrichment
row) or, if it is meant to stay, reclassify it Retained and give it a
ceiling like http_cache/browsedArtBudget — a year-long entity cache
without a bound is exactly the leak httpCacheBudget exists to stop.

**Report** `artist_metadata` is classified `Cache, Swept` in the datamap — "swept when the artist is no longer referenced" — but no sweep exists and no `DELETE FROM artist_metadata` appears anywhere in the tree. It is a long-lived enrichment store (no TTL by design), so rows accumulate for the life of the install. **Findings** - `backend/datamap/datamap.go:128` declares `Cache, Swept`. - The only references are the read/write in `backend/explore/cache.go:137,161`. - The maintenance runner (`backend/app.go:777-790`) registers `http_cache`, cover files, artist images and the proxy cache — nothing for `artist_metadata`. **Direction** Either add a sweep (keyed on `artist_metadata.mbid` no longer being referenced by a library artist or any `artist_images`/`artist_enrichment` row) or, if it is meant to stay, reclassify it `Retained` and give it a ceiling like `http_cache`/`browsedArtBudget` — a year-long entity cache without a bound is exactly the leak `httpCacheBudget` exists to stop.
yonlu self-assigned this 2026-09-09 13:58:14 +00:00
yonlu added the
Status
In Progress
 label 2026-09-09 13:58:14 +00:00
yonlu commented 2026-09-09 13:58:15 +00:00
Author
Owner
Copy Link
Copy Source

Branch: fix/248-artist-metadata-sweep

Approach: add a janitor job that deletes artist_metadata rows whose mbid is no longer a library artist nor referenced by artist_images/artist_enrichment, and register it. Decision to record: sweep (keep Swept) versus reclassify Retained with a budget — pick sweep if the owned-artist query is cheap, else a size budget like http_cache.

Branch: fix/248-artist-metadata-sweep Approach: add a janitor job that deletes artist_metadata rows whose mbid is no longer a library artist nor referenced by artist_images/artist_enrichment, and register it. Decision to record: sweep (keep Swept) versus reclassify Retained with a budget — pick sweep if the owned-artist query is cheap, else a size budget like http_cache.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Kind/Bug Platform/Android Platform/Desktop
Priority
Low
4
Reviewed
Confirmed
1
Status
In Progress
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#248