yonlu/yellowjacket
1
1 Fork 0
Code Issues 61 Pull Requests 1 Actions Packages Projects Releases 13 Wiki Activity

fix(maintenance): bound search_clicks and lyrics_index, clear stale queue source #253

Closed
yonlu wants to merge 0 commits from fix/249-unbounded-growth into main
pull from: fix/249-unbounded-growth
merge into: yonlu:main
Conversation 1 Commits - Files Changed -
yonlu commented 2026-09-09 14:23:36 +00:00
Owner
Copy link
Copy source
commit issue
4e5c6b9f fix(maintenance): bound search_clicks and lyrics_index, clear stale queue source #249

Verification

  • go test ./backend/database/... ./backend/library/... ./backend/queue/... ./backend/playlist/... ./backend/maintenance/...
  • golangci-lint run .

Three small items: prune lyrics_index on track removal, age out
search_clicks via a daily janitor job, and drop the queue's
"Playing from" label when its source playlist is deleted.

Note: this branch and #246 both touch the orphan loop in
backend/library/library.go; merge #246 first and rebase this one.

Closes #249

| commit | issue | |---|---| | `4e5c6b9f` fix(maintenance): bound search_clicks and lyrics_index, clear stale queue source | #249 | ## Verification - `go test ./backend/database/... ./backend/library/... ./backend/queue/... ./backend/playlist/... ./backend/maintenance/...` - `golangci-lint run .` Three small items: prune `lyrics_index` on track removal, age out `search_clicks` via a daily janitor job, and drop the queue's "Playing from" label when its source playlist is deleted. Note: this branch and #246 both touch the orphan loop in `backend/library/library.go`; merge #246 first and rebase this one. Closes #249
yonlu added 1 commit 2026-09-11 21:14:48 +00:00
fix(maintenance): bound lyrics search and clicks, clear queue source
CI / check (push) Skipped
CI / e2e (push) Skipped
CI / check (pull_request) Failing after 3m44s
Details
CI / e2e (pull_request) Skipped
Details
88f5524aa2 
Three unbounded or stale surfaces, each small on its own:

- lyrics_index rows were never pruned on track removal, so the FTS index
  grew forever. Delete the entry where the library search FTS entry is
  already deleted, on the orphan and RemoveFromLibrary paths.
- search_clicks had no ceiling; age out ranking rows after a retention
  window via a daily janitor job.
- queue.source_* kept a "Playing from X" label after its playlist was
  deleted. Drop the source when the queue's own playlist goes, wired
  through a playlist-service hook like Library.SetRemovalHooks.

Closes #249
yonlu force-pushed fix/249-unbounded-growth from 4e5c6b9f7a to 88f5524aa2 2026-09-11 21:14:48 +00:00 Compare
yonlu added 1 commit 2026-09-21 00:22:32 +00:00
chore(bindings): regenerate for the queue's DropSourceForPlaylist
CI / check (push) Skipped
CI / e2e (push) Skipped
CI / check (pull_request) Successful in 6m50s
Details
CI / e2e (pull_request) Successful in 11m9s
Details
cf90030463 
frontend/bindings is generated by wails3 and is not covered by the
codegen pre-commit hook, so the new bound method went out without it and
make bindings-check failed on the PR.
yonlu commented 2026-09-21 02:17:13 +00:00
Author
Owner
Copy link
Copy source

Closed rather than merged: this branch is in main through PR #255 (main is now a5c3990, batch head 8dbdb7a), which also carries the bindings fix cf900304 that this PR's final CI run was waiting on. 88f5524a is preserved in that history and closed #249.

One conflict with #252 in backend/library/library.go: the orphan-path lyrics delete used audioFile.ID, which is the loop variable before #250 renamed it to f — the auto-merge kept the added lines verbatim and they would not have compiled. Adapted to f.ID in the batch. Everything else in this change merged clean.

Closed rather than merged: this branch is in `main` through PR #255 (main is now `a5c3990`, batch head `8dbdb7a`), which also carries the bindings fix `cf900304` that this PR's final CI run was waiting on. `88f5524a` is preserved in that history and closed #249. One conflict with #252 in `backend/library/library.go`: the orphan-path lyrics delete used `audioFile.ID`, which is the loop variable before #250 renamed it to `f` — the auto-merge kept the added lines verbatim and they would not have compiled. Adapted to `f.ID` in the batch. Everything else in this change merged clean.
yonlu closed this pull request 2026-09-21 02:17:13 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#253