yonlu/yellowjacket
1
1 Fork 0
Code Issues 61 Pull Requests 1 Actions Packages Projects Releases 13 Wiki Activity

fix(maintenance): sweep artist_metadata rows nothing references #252

Closed
yonlu wants to merge 0 commits from fix/248-artist-metadata-sweep into main
pull from: fix/248-artist-metadata-sweep
merge into: yonlu:main
Conversation 1 Commits - Files Changed -
yonlu commented 2026-09-09 14:23:36 +00:00
Owner
Copy link
Copy source
commit issue
e745acf8 fix(maintenance): sweep artist_metadata rows nothing references #248

Verification

  • go test ./backend/maintenance/...
  • golangci-lint run .

artist_metadata was classified Cache/Swept but had no sweep and no
DELETE anywhere. Sweeps rows whose MBID is neither a library artist nor
holding cached artwork, registered with the janitor.

Closes #248

| commit | issue | |---|---| | `e745acf8` fix(maintenance): sweep artist_metadata rows nothing references | #248 | ## Verification - `go test ./backend/maintenance/...` - `golangci-lint run .` `artist_metadata` was classified `Cache/Swept` but had no sweep and no DELETE anywhere. Sweeps rows whose MBID is neither a library artist nor holding cached artwork, registered with the janitor. Closes #248
yonlu added 1 commit 2026-09-09 14:23:36 +00:00
fix(maintenance): sweep artist_metadata rows nothing references
CI / check (push) Skipped
CI / e2e (push) Skipped
CI / check (pull_request) Successful in 3m6s
Details
CI / e2e (pull_request) Successful in 11m22s
Details
e745acf88a 
artist_metadata was classified Cache/Swept but had no sweep and no
DELETE anywhere, so long-lived entity data (no TTL by design) grew for
the life of the install.  Sweep rows whose MBID is neither a library
artist nor holding cached artwork, and register the job with the
janitor.

Closes #248
yonlu added 1 commit 2026-09-21 01:15:19 +00:00
Merge remote-tracking branch 'origin/main' into fix/248-artist-metadata-sweep
CI / check (push) Skipped
CI / e2e (push) Skipped
CI / check (pull_request) Successful in 3m22s
Details
CI / e2e (pull_request) Successful in 11m43s
Details
a96cc9be1f
yonlu commented 2026-09-21 02:17:12 +00:00
Author
Owner
Copy link
Copy source

Closed rather than merged: this branch is in main through PR #255, the batch that reconciled it with #253 (main is now a5c3990, batch head 8dbdb7a). Its commit e745acf8 is preserved in that history and closed #248 on the way in.

The batch hit conflicts with #253 in backend/app.go (both register a janitor job), backend/maintenance/sweeps.go (both append a job) and backend/maintenance/maintenance_test.go (both append a test). All three were resolved by keeping both sides, and the combination is what CI/check and CI/e2e verified on 8dbdb7a before the merge.

Closed rather than merged: this branch is in `main` through PR #255, the batch that reconciled it with #253 (main is now `a5c3990`, batch head `8dbdb7a`). Its commit `e745acf8` is preserved in that history and closed #248 on the way in. The batch hit conflicts with #253 in `backend/app.go` (both register a janitor job), `backend/maintenance/sweeps.go` (both append a job) and `backend/maintenance/maintenance_test.go` (both append a test). All three were resolved by keeping both sides, and the combination is what CI/check and CI/e2e verified on `8dbdb7a` before the merge.
yonlu closed this pull request 2026-09-21 02:17:13 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#252