Files
yellowjacket/backend/tagwriter/pipeline.go
T
logan 5ca6cad45a
Build & publish Arch package / arch-package (push) Successful in 2m8s
CI / check (push) Failing after 1m56s
CI / e2e (push) Skipped
Search index maintenance / maintain-index (push) Successful in 13s
feat(harness): agent-drivable dev harness and CI that gates
A coding agent could develop this repo's Go packages and could not
develop the application: every path to running YellowJacket ended in a
blocking GTK window, so 265 bound methods, 46 events, 33 component
directories and 13 stores had exactly one form of verification
available — `tsc --noEmit`.

The unlock is that `wails dev`'s dev server on :34115 serves the real
frontend with the real generated bindings against the same Go backend a
desktop window attaches to, so a plain Chromium under Xvfb gets a fully
functional app. Four test tiers now exist, cheapest first:

- `make ui-test` — 313 Vitest tests in a real browser in ~2 s, no app,
  no backend, no display. Works because `frontend/wailsjs/` is a pure
  passthrough to `window.go`/`window.runtime`, so faking just those two
  globals runs the real bindings and the real store code.
- `make test` — services in-process, asserting on the payload the
  frontend would receive, via a new `events.Emit` wrapper.
- `make dev-headless` + `playwright-cli` — the real app, driven
  interactively, with an event bridge on `window.__yjEvents` and a
  dev-only control surface at `/__test/`.
- `make e2e` — 19 of those flows frozen as Playwright specs.

`events.Emit(ctx, …)` replaces all 35 direct `runtime.EventsEmit` call
sites: wails' `getEvents` `log.Fatalf`s on any context without its
runtime, so those paths could not run under test and a background
worker could take the app down. Four packages had each hand-rolled the
same guard; nine more guarded on `ctx != nil`, which does not help.
`TestNoDirectRuntimeEmits` fails the build on a new one.

Fixtures are generated, not committed (`make testdata`), and seeds are
built by *running the app* — never by hand-writing config and DB rows,
which would be a second description of a valid YJ_HOME.

`.gitea/workflows/ci.yml` is the first workflow here that tests
anything; the other three only package, so `gitea_ci` reported only
packaging jobs and misled anyone asking whether a push was healthy.
Both jobs were prototyped to green in a bare ubuntu:24.04 container
before the YAML was written, which immediately caught `make lint`
linting three configurations that nothing builds: all three passes
omitted `webkit2_41`, so wails resolved webkit2gtk-4.0 — which Arch
still ships and Ubuntu 24.04 dropped.

Operational instructions live in `.pi/skills/yellowjacket-dev/`,
measured discoveries in `.planning/NOTES.md`, and architecture in
`CLAUDE.md` — split by tense, not by topic, because a topical split
gives every new fact two plausible homes. `make skill-check` fails a
commit if the skill cites a make target that does not exist.
2026-08-10 23:20:42 -04:00

382 lines
10 KiB
Go

package tagwriter
import (
"context"
"errors"
"fmt"
"log/slog"
"time"
"yellowjacket/backend/database"
"yellowjacket/backend/events"
)
// errNoChanges is returned when WriteTrackTags is called with an
// empty TagChanges map.
var errNoChanges = errors.New("tagwriter: no changes provided")
// BatchFailure records a single track that failed during a batch write.
type BatchFailure struct {
FilePath string `json:"filePath"`
Error string `json:"error"`
}
// BatchResult summarises the outcome of a batch tag write.
type BatchResult struct {
Total int `json:"total"`
Succeeded int `json:"succeeded"`
Failed int `json:"failed"`
Cancelled bool `json:"cancelled"`
Failures []BatchFailure `json:"failures"`
}
// PlayerStopper checks whether a file is currently playing and
// stops playback if needed. Defined as an interface to break the
// import cycle between tagwriter and player.
type PlayerStopper interface {
// CurrentFilePath returns the file path of the currently-
// loaded track, or empty string if nothing is loaded.
CurrentFilePath() string
// StopAndRelease stops playback and releases the file handle.
StopAndRelease()
}
// PipelineLocker abstracts the library's pipeline mutex for
// scan/write mutual exclusion.
type PipelineLocker interface {
AcquirePipelineLock()
ReleasePipelineLock()
}
// TagWriter orchestrates the complete tag writing pipeline:
// file write → DB sync → event emission.
type TagWriter struct {
logger *slog.Logger
db *database.DB
ctx context.Context // Wails context for event emission
player PlayerStopper
library PipelineLocker
cancelBatch chan struct{} // Signals batch cancellation.
suppressEvents bool // Suppresses per-track events during batch.
}
// NewTagWriter creates a TagWriter with the given dependencies.
// Call SetContext after the Wails runtime is available.
func NewTagWriter(
logger *slog.Logger,
db *database.DB,
player PlayerStopper,
library PipelineLocker,
) *TagWriter {
return &TagWriter{
logger: logger.WithGroup("tagwriter"),
db: db,
player: player,
library: library,
}
}
// SetContext stores the Wails runtime context for event emission.
// Called during the two-phase init pattern in OnStartup.
func (tw *TagWriter) SetContext(ctx context.Context) {
tw.ctx = ctx
}
// WriteTrackTags is the single entry point for writing metadata to
// a track's audio file and synchronising all changes to the
// database. It accepts a track ID (audio_file.id) and a diff map
// of changed fields.
//
// The pipeline:
// 1. Look up track from DB.
// 2. Detect audio format.
// 3. Acquire pipeline lock (mutual exclusion with scan).
// 4. Stop player if this file is currently playing.
// 5. Write tags to file (format-specific writer).
// 6. Sync database (entity relink, FTS5, orphan cleanup).
// 7. Emit TrackMetadataChanged event.
func (tw *TagWriter) WriteTrackTags(trackID int64, changes TagChanges) error {
start := time.Now()
ctx := context.Background()
if len(changes) == 0 {
return errNoChanges
}
// 1. Look up track.
audioFile, err := tw.db.Queries.GetAudioFile(ctx, trackID)
if err != nil {
return fmt.Errorf("get audio file %d: %w", trackID, err)
}
recording, err := tw.db.Queries.GetRecording(ctx, audioFile.RecordingID)
if err != nil {
return fmt.Errorf("get recording %d: %w", audioFile.RecordingID, err)
}
rgLinks, err := tw.db.Queries.GetRecordingReleaseGroups(ctx, recording.ID)
if err != nil {
return fmt.Errorf("get recording rg links: %w", err)
}
// 2. Detect format.
format, err := DetectFormat(audioFile.FilePath)
if err != nil {
return fmt.Errorf("detect format: %w", err)
}
// 3. Acquire pipeline lock.
tw.library.AcquirePipelineLock()
defer tw.library.ReleasePipelineLock()
// 4. Player safety check.
if tw.player != nil && tw.player.CurrentFilePath() == audioFile.FilePath {
tw.logger.Info("stopping playback for tag write",
"path", audioFile.FilePath)
tw.player.StopAndRelease()
}
// 5. Write file tags.
switch format {
case FormatMP3:
err = writeMp3Tags(tw.logger, audioFile.FilePath, changes)
case FormatFLAC:
err = writeFlacTags(tw.logger, audioFile.FilePath, changes)
case FormatWAV:
err = writeWavTags(tw.logger, audioFile.FilePath, changes)
case FormatOGG:
err = writeOggTags(tw.logger, audioFile.FilePath, changes)
default:
err = fmt.Errorf("%w: %s", errUnsupportedFormat, format)
}
if err != nil {
return fmt.Errorf("write file tags: %w", err)
}
// 6. Sync database.
if syncErr := syncDatabase(ctx, tw.logger, tw.db, dbSyncParams{
audioFileID: audioFile.ID,
recordingID: recording.ID,
filePath: audioFile.FilePath,
changes: changes,
oldRecording: recording,
oldRGLinks: rgLinks,
}); syncErr != nil {
tw.logger.Error("db sync failed after successful file write",
"err", syncErr,
"trackID", trackID,
"path", audioFile.FilePath,
)
return fmt.Errorf("sync database: %w", syncErr)
}
// 7. Emit event (suppressed during batch writes).
if !tw.suppressEvents {
events.Emit(tw.ctx, events.TrackMetadataChanged,
map[string]any{
"trackId": trackID,
"filePath": audioFile.FilePath,
},
)
}
tw.logger.Info("tag write complete",
"trackID", trackID,
"path", audioFile.FilePath,
"duration", time.Since(start),
"changedFields", len(changes),
)
return nil
}
// WriteUntrackedFileTags writes tags to a file that is not in the
// library, skipping every step of the full pipeline that assumes it is:
// no audio_file lookup, no database sync, no event.
//
// This exists for the download import path, which tags files while they
// are still in the staging directory. Tagging before the move is what
// makes the import atomic from the library's point of view — the
// scanner only ever sees a finished, correctly tagged file, instead of
// ingesting a mislabelled one and being corrected afterwards.
//
// Callers are responsible for ensuring the file is not in a library
// path; using this on a tracked file would leave the database stale.
func (tw *TagWriter) WriteUntrackedFileTags(
filePath string,
changes TagChanges,
) error {
if len(changes) == 0 {
return errNoChanges
}
return WriteFileTags(tw.logger, filePath, changes)
}
// WriteFileTags writes tags straight to an audio file, with no
// database, player or lock involvement. It is the format-dispatch
// half of WriteUntrackedFileTags, exported so tooling that has no
// app to construct — the fixture generator in cmd/gentestdata — can
// tag files with the same writers the app uses, rather than growing a
// second tagger that is free to drift from this one.
//
// Callers owning a *TagWriter should use WriteUntrackedFileTags.
func WriteFileTags(
logger *slog.Logger,
filePath string,
changes TagChanges,
) error {
format, err := DetectFormat(filePath)
if err != nil {
return fmt.Errorf("detect format: %w", err)
}
switch format {
case FormatMP3:
err = writeMp3Tags(logger, filePath, changes)
case FormatFLAC:
err = writeFlacTags(logger, filePath, changes)
case FormatWAV:
err = writeWavTags(logger, filePath, changes)
case FormatOGG:
err = writeOggTags(logger, filePath, changes)
default:
err = fmt.Errorf("%w: %s", errUnsupportedFormat, format)
}
if err != nil {
return fmt.Errorf("write file tags: %w", err)
}
return nil
}
// WriteTrackTagsByPath resolves a file path to its audio_file.id and
// delegates to WriteTrackTags. This is the frontend-facing entry
// point since the frontend identifies tracks by FilePath.
func (tw *TagWriter) WriteTrackTagsByPath(filePath string, changes TagChanges) error {
ctx := context.Background()
audioFile, err := tw.db.Queries.GetAudioFileByPath(ctx, filePath)
if err != nil {
return fmt.Errorf("resolve track by path %q: %w", filePath, err)
}
return tw.WriteTrackTags(audioFile.ID, changes)
}
// CancelBatchWrite signals the in-progress batch write to stop after
// the current track completes.
func (tw *TagWriter) CancelBatchWrite() {
ch := tw.cancelBatch
if ch != nil {
select {
case <-ch:
// Already closed.
default:
close(ch)
}
}
}
// BatchWriteTrackTags applies the same TagChanges to every file in
// filePaths. It processes tracks sequentially, emits a
// BatchWriteProgress event after each track, and continues past
// individual failures. Returns a BatchResult summarising outcomes.
func (tw *TagWriter) BatchWriteTrackTags(
filePaths []string,
changes TagChanges,
) BatchResult {
start := time.Now()
total := len(filePaths)
result := BatchResult{
Total: total,
Failures: []BatchFailure{},
}
if total == 0 || len(changes) == 0 {
return result
}
// Set up cancellation channel.
tw.cancelBatch = make(chan struct{})
defer func() { tw.cancelBatch = nil }()
// Suppress per-track TrackMetadataChanged events — we emit one
// at the end instead.
tw.suppressEvents = true
defer func() { tw.suppressEvents = false }()
for i, filePath := range filePaths {
// Check for cancellation before each track.
select {
case <-tw.cancelBatch:
result.Cancelled = true
tw.logger.Info("batch write cancelled",
"at", i,
"total", total,
)
default:
}
if result.Cancelled {
break
}
err := tw.WriteTrackTagsByPath(filePath, changes)
if err != nil {
result.Failed++
result.Failures = append(result.Failures, BatchFailure{
FilePath: filePath,
Error: err.Error(),
})
tw.logger.Warn("batch track failed",
"path", filePath,
"err", err,
"index", i+1,
"total", total,
)
} else {
result.Succeeded++
}
// Emit progress after each track (success or failure).
events.Emit(tw.ctx,
events.BatchWriteProgress,
map[string]any{
"current": i + 1,
"total": total,
"filePath": filePath,
"succeeded": result.Succeeded,
"failed": result.Failed,
},
)
}
// Emit a single TrackMetadataChanged after the batch completes
// so the library store invalidates once rather than per-track.
events.Emit(tw.ctx, events.TrackMetadataChanged,
map[string]any{
"batch": true,
"total": result.Succeeded,
},
)
tw.logger.Info("batch write complete",
"total", total,
"succeeded", result.Succeeded,
"failed", result.Failed,
"cancelled", result.Cancelled,
"duration", time.Since(start),
)
return result
}