yonlu/yellowjacket
1
1
Fork 0
Code Issues 51 Pull Requests 4 Actions Packages Projects Releases 12 Wiki Activity

fix(library): preserve playlist phantoms on incremental scan and removal #250

Open
yonlu wants to merge 1 commits from fix/246-incremental-scan-phantoms into main
pull from: fix/246-incremental-scan-phantoms
merge into: :main
Conversation 0 Commits 1 Files Changed 6
+412 -38
yonlu commented 2026-09-09 14:23:34 +00:00
Owner
Copy Link
Copy Source
commit issue
1b9868dd fix(library): preserve playlist phantoms on incremental scan and removal #246

Verification

  • go test ./backend/database/... ./backend/library/...
  • golangci-lint run .

The incremental scan's orphan cleanup and RemoveFromLibrary deleted
audio_files rows without first filling the playlist phantom columns,
so a track removed from the library folder outside YellowJacket (or
removed from the library) became a permanently empty playlist row. Adds
a scoped PreservePlaylistPhantomsForFiles and runs it in the same
transaction as the deletes.

Closes #246

| commit | issue | |---|---| | `1b9868dd` fix(library): preserve playlist phantoms on incremental scan and removal | #246 | ## Verification - `go test ./backend/database/... ./backend/library/...` - `golangci-lint run .` The incremental scan's orphan cleanup and `RemoveFromLibrary` deleted `audio_files` rows without first filling the playlist phantom columns, so a track removed from the library folder outside YellowJacket (or removed from the library) became a permanently empty playlist row. Adds a scoped `PreservePlaylistPhantomsForFiles` and runs it in the same transaction as the deletes. Closes #246
yonlu added 1 commit 2026-09-09 14:23:34 +00:00
fix(library): preserve playlist phantoms on incremental scan and removal
CI / check (push) Skipped
CI / e2e (push) Skipped
CI / check (pull_request) Successful in 3m33s
Details
CI / e2e (pull_request) Successful in 11m12s
Details
1b9868ddd0 
The incremental scan's orphan cleanup and RemoveFromLibrary deleted
audio_files rows without first filling the playlist phantom columns, so
a track removed from the library folder outside YellowJacket (or
removed from the library) became a permanently empty playlist row that
nothing could re-link — the same bug #183 fixed on the full-rescan and
retire paths, on the two paths it missed.

Add a scoped PreservePlaylistPhantomsForFiles and run it in the same
transaction as the deletes on both paths.

Closes #246
All checks were successful
CI / check (push) Skipped
Required
CI / e2e (push) Skipped
Required
CI / check (pull_request) Successful in 3m33s
Required
Details
CI / e2e (pull_request) Successful in 11m12s
Required
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/246-incremental-scan-phantoms:fix/246-incremental-scan-phantoms
git checkout fix/246-incremental-scan-phantoms
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#250