yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Desktop: "Play all" and "Play all shuffled" on the Tracks tab (and anywhere else missing them) #31

New Issue
Open
opened 2026-08-18 05:56:10 +00:00 by logan · 0 comments
logan commented 2026-08-18 05:56:10 +00:00
Collaborator
Copy Link
Copy Source

Report

The Tracks tab should have a play button and a play-shuffled button at the top so I can just put the whole library on. Those two buttons should be on every page with multiple tracks — a genre list, for instance (most other places already have them).

Findings

  • <page-header> (components/page-header/) is the one component carrying title/count/sort/actions for the nine primary views, so this is one action pair added there and passed by each host — not nine implementations.
  • Playback already has the right primitives: GetFilePathsByGenres(names, libraryID) and GetFilePathsByAlbums(ids, libraryID) return paths only, grouped so the caller keeps its order. A "play all tracks" equivalent should ask for paths only too, in the order the user can see, rather than mapping over track rows (that pattern cost 6 MB over the IPC for 5 genres).
  • SetQueue(paths, startIndex, shuffleStart, source) takes shuffleStart, so shuffled-play is the same call.

Direction

Add the pair to page-header's actions slot, wire the missing hosts (Tracks certainly; audit genres/artists/playlists), and set a correct Source so "Playing from" says something true (see the stale-source issue).

**Report** The Tracks tab should have a play button and a play-shuffled button at the top so I can just put the whole library on. Those two buttons should be on every page with multiple tracks — a genre list, for instance (most other places already have them). **Findings** - `<page-header>` (`components/page-header/`) is the one component carrying title/count/sort/actions for the nine primary views, so this is one action pair added there and passed by each host — not nine implementations. - Playback already has the right primitives: `GetFilePathsByGenres(names, libraryID)` and `GetFilePathsByAlbums(ids, libraryID)` return paths only, grouped so the caller keeps its order. A "play all tracks" equivalent should ask for paths only too, in the order the user can see, rather than mapping over track rows (that pattern cost 6 MB over the IPC for 5 genres). - `SetQueue(paths, startIndex, shuffleStart, source)` takes `shuffleStart`, so shuffled-play is the same call. **Direction** Add the pair to `page-header`'s actions slot, wire the missing hosts (Tracks certainly; audit genres/artists/playlists), and set a correct `Source` so "Playing from" says something true (see the stale-source issue).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Library-UI Area/Queue Kind/Feature Platform/Desktop
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#31