yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Desktop: "Playing from" keeps naming a source the queue has outgrown #14

New Issue
Closed
opened 2026-08-18 05:54:00 +00:00 by logan · 0 comments
logan commented 2026-08-18 05:54:00 +00:00
Collaborator
Copy Link
Copy Source

Report

The "Playing from ..." line under the now-playing artist/track keeps naming the first album I happened to start a song from, even after I have appended lots of unrelated tracks to the queue. It should only claim a source while the queue actually is that source — or it should track the current track's origin.

Findings

  • backend/queue/queue.go: q.source is set by SetQueue (line ~248) and cleared in exactly one place (line 1224, on clear). Nothing in the add-to-queue paths touches it, so it survives arbitrary appends.
  • The line is rendered by frontend/src/utils/queue-source-link.ts from QueueState.Source.
  • It is persisted too (persistence.go:404), so a stale source survives a restart.

Direction

Two candidate rules, pick one deliberately:

  1. Invalidate on divergence — any append/insert/remove that makes the queue no longer equal to what the source produced clears q.source. Simple, honest, and the line disappears rather than lying.
  2. Per-track provenance — store a source per queue row and show the current track's. More useful, more bookkeeping (queue_tracks gains columns, and the persist writer's snapshots must carry it).

Whatever is chosen, resolveFallback's PreviousSource reads the same field, so check the dynamic-mix continuation still behaves.

**Report** The "Playing from ..." line under the now-playing artist/track keeps naming the first album I happened to start a song from, even after I have appended lots of unrelated tracks to the queue. It should only claim a source while the queue actually *is* that source — or it should track the current track's origin. **Findings** - `backend/queue/queue.go`: `q.source` is set by `SetQueue` (line ~248) and cleared in exactly one place (line 1224, on clear). Nothing in the add-to-queue paths touches it, so it survives arbitrary appends. - The line is rendered by `frontend/src/utils/queue-source-link.ts` from `QueueState.Source`. - It is persisted too (`persistence.go:404`), so a stale source survives a restart. **Direction** Two candidate rules, pick one deliberately: 1. **Invalidate on divergence** — any append/insert/remove that makes the queue no longer equal to what the source produced clears `q.source`. Simple, honest, and the line disappears rather than lying. 2. **Per-track provenance** — store a source per queue row and show the current track's. More useful, more bookkeeping (`queue_tracks` gains columns, and the persist writer's snapshots must carry it). Whatever is chosen, `resolveFallback`'s `PreviousSource` reads the same field, so check the dynamic-mix continuation still behaves.
yonlu was assigned by logan 2026-08-18 15:32:38 +00:00
logan closed this issue 2026-08-18 16:18:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Queue Kind/Bug Platform/Android Platform/Desktop
Priority
High
2
Reviewed
Confirmed
1
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#14