Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
266 lines
6.8 KiB
Go
266 lines
6.8 KiB
Go
package library
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"yellowjacket/backend/coverart"
|
|
)
|
|
|
|
var errNoLibrariesConfigured = errors.New(
|
|
"no libraries configured for rescan",
|
|
)
|
|
|
|
// FullRescan clears the queue and player, wipes all library data
|
|
// (database records and cover art files), and performs a fresh
|
|
// scan of every library in the database. The returned ScanMetrics
|
|
// reflects the last library scanned; clear-phase durations are
|
|
// folded into its totals.
|
|
func (l *Library) FullRescan() (*ScanMetrics, error) {
|
|
l.logger.Info("beginning full library rescan")
|
|
|
|
// Resolve all libraries from the database.
|
|
libs, err := l.db.Queries.GetAllLibraries(l.ctx)
|
|
if err != nil {
|
|
return nil, fmt.Errorf(
|
|
"could not get libraries for rescan: %w", err,
|
|
)
|
|
}
|
|
|
|
if len(libs) == 0 {
|
|
return nil, errNoLibrariesConfigured
|
|
}
|
|
|
|
// Run the pre-clear hook (e.g. clear queue / stop playback)
|
|
// before wiping data so the player is not referencing
|
|
// now-deleted tracks.
|
|
clearQueueStart := time.Now()
|
|
|
|
if l.rescanHooks.PreClear != nil {
|
|
l.rescanHooks.PreClear()
|
|
}
|
|
|
|
clearQueueDur := time.Since(clearQueueStart)
|
|
|
|
// Clear all library data (DB + cover art files).
|
|
clearDBStart := time.Now()
|
|
|
|
if err := l.clearLibraryTables(); err != nil {
|
|
return nil, fmt.Errorf(
|
|
"could not clear library tables: %w", err,
|
|
)
|
|
}
|
|
|
|
clearDBDur := time.Since(clearDBStart)
|
|
|
|
clearFilesStart := time.Now()
|
|
|
|
if err := l.clearCoverArtFiles(); err != nil {
|
|
return nil, fmt.Errorf(
|
|
"could not clear cover art files: %w", err,
|
|
)
|
|
}
|
|
|
|
clearFilesDur := time.Since(clearFilesStart)
|
|
|
|
l.logger.Info("library data cleared successfully")
|
|
|
|
// Scan the first library directly (bypassing the queue) so
|
|
// we get ScanMetrics back. Queue remaining libraries so
|
|
// they run sequentially via the scan coordinator.
|
|
metrics := l.scanInternal(libs[0].ID, libs[0].Name, libs[0].Path)
|
|
|
|
for _, lib := range libs[1:] {
|
|
if scanErr := l.ScanLibrary(lib.ID); scanErr != nil {
|
|
l.logger.Error("could not queue library for rescan",
|
|
"libraryID", lib.ID, "err", scanErr)
|
|
}
|
|
}
|
|
|
|
// Drain the queue in a goroutine so any queued libraries
|
|
// scan sequentially. scanInternal was called directly (not
|
|
// via startScan), so drainQueue hasn't been invoked yet.
|
|
go l.drainQueue()
|
|
|
|
if metrics != nil {
|
|
metrics.ClearQueue = clearQueueDur
|
|
metrics.ClearDatabase = clearDBDur
|
|
metrics.ClearCoverFiles = clearFilesDur
|
|
|
|
// Include clear-phase durations in the total so the
|
|
// displayed value reflects true wall-clock time.
|
|
metrics.Total += clearQueueDur +
|
|
clearDBDur + clearFilesDur
|
|
}
|
|
|
|
// Run the post-scan hook (e.g. restore playlists from M3U8
|
|
// files) now that audio_files are populated again.
|
|
if l.rescanHooks.PostScan != nil {
|
|
l.rescanHooks.PostScan()
|
|
}
|
|
|
|
return metrics, nil
|
|
}
|
|
|
|
// clearLibraryTables deletes all library-related rows in FK-safe
|
|
// order within a single transaction.
|
|
func (l *Library) clearLibraryTables() error {
|
|
tx, err := l.db.BeginTx()
|
|
if err != nil {
|
|
return fmt.Errorf("could not begin transaction: %w", err)
|
|
}
|
|
|
|
defer func() {
|
|
_ = tx.Rollback()
|
|
}()
|
|
|
|
txq := l.db.Queries.WithTx(tx)
|
|
|
|
// Phase 1: leaf tables (nothing references these).
|
|
if err := txq.ClearQueueTracks(l.ctx); err != nil {
|
|
return fmt.Errorf("could not clear queue tracks: %w", err)
|
|
}
|
|
|
|
// A full rescan is the "start over" button, and it is the only way
|
|
// back for a path removed from the library by mistake: the file is
|
|
// still on disk, but nothing else will ever import it again while
|
|
// its exclusion stands. Until there is a UI for managing the list,
|
|
// clearing it here is the escape hatch.
|
|
if err := txq.ClearExcludedPaths(l.ctx); err != nil {
|
|
return fmt.Errorf("could not clear excluded paths: %w", err)
|
|
}
|
|
|
|
// Preserve playlist tracks across rescan: populate phantom
|
|
// metadata for all linked tracks before audio_files are deleted.
|
|
// ON DELETE SET NULL will null out audio_file_id, converting them
|
|
// to phantoms that ResolvePhantomTracksAfterScan can re-link.
|
|
if _, err := tx.ExecContext(l.ctx, `
|
|
UPDATE playlist_tracks
|
|
SET
|
|
phantom_title = COALESCE(phantom_title, (
|
|
SELECT tm.title FROM track_metadata tm
|
|
WHERE tm.id = playlist_tracks.audio_file_id
|
|
)),
|
|
phantom_artist = COALESCE(phantom_artist, (
|
|
SELECT tm.artist_name FROM track_metadata tm
|
|
WHERE tm.id = playlist_tracks.audio_file_id
|
|
)),
|
|
phantom_album = COALESCE(phantom_album, (
|
|
SELECT tm.album FROM track_metadata tm
|
|
WHERE tm.id = playlist_tracks.audio_file_id
|
|
)),
|
|
phantom_duration_ms = COALESCE(phantom_duration_ms, (
|
|
SELECT af.length_milliseconds FROM audio_files af
|
|
WHERE af.id = playlist_tracks.audio_file_id
|
|
)),
|
|
phantom_file_path = COALESCE(phantom_file_path, (
|
|
SELECT af.file_path FROM audio_files af
|
|
WHERE af.id = playlist_tracks.audio_file_id
|
|
))
|
|
WHERE audio_file_id IS NOT NULL
|
|
`); err != nil {
|
|
return fmt.Errorf(
|
|
"could not preserve playlist track metadata: %w", err,
|
|
)
|
|
}
|
|
|
|
// Phase 2: the files. file_genres cascades with them.
|
|
if err := txq.DeleteAllAudioFiles(l.ctx); err != nil {
|
|
return fmt.Errorf(
|
|
"could not clear audio files: %w", err,
|
|
)
|
|
}
|
|
|
|
if err := txq.DeleteAllAlbums(l.ctx); err != nil {
|
|
return fmt.Errorf(
|
|
"could not clear albums: %w", err,
|
|
)
|
|
}
|
|
|
|
// Phase 3: root tables.
|
|
if err := txq.DeleteAllCoverArt(l.ctx); err != nil {
|
|
return fmt.Errorf(
|
|
"could not clear cover art: %w", err,
|
|
)
|
|
}
|
|
|
|
if err := txq.DeleteAllArtists(l.ctx); err != nil {
|
|
return fmt.Errorf(
|
|
"could not clear artists: %w", err,
|
|
)
|
|
}
|
|
|
|
if err := txq.DeleteAllGenres(l.ctx); err != nil {
|
|
return fmt.Errorf(
|
|
"could not clear genres: %w", err,
|
|
)
|
|
}
|
|
|
|
if err := tx.Commit(); err != nil {
|
|
return fmt.Errorf(
|
|
"could not commit library clear transaction: %w", err,
|
|
)
|
|
}
|
|
|
|
// Clear FTS5 search index AFTER the transaction.
|
|
// ClearSearchIndex drops and recreates the contentless FTS5
|
|
// virtual table, which cannot run inside a transaction.
|
|
if err := l.db.ClearSearchIndex(); err != nil {
|
|
return fmt.Errorf(
|
|
"could not clear search index: %w", err,
|
|
)
|
|
}
|
|
|
|
l.logger.Info("all library tables cleared")
|
|
|
|
return nil
|
|
}
|
|
|
|
// clearCoverArtFiles removes all files from the covers directory.
|
|
func (l *Library) clearCoverArtFiles() error {
|
|
coverDir, err := coverart.CoversDir()
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"could not resolve covers directory: %w", err,
|
|
)
|
|
}
|
|
|
|
entries, err := os.ReadDir(coverDir)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
return nil
|
|
}
|
|
|
|
return fmt.Errorf(
|
|
"could not read covers directory: %w", err,
|
|
)
|
|
}
|
|
|
|
var removed int
|
|
|
|
for _, entry := range entries {
|
|
if entry.IsDir() {
|
|
continue
|
|
}
|
|
|
|
path := filepath.Join(coverDir, entry.Name())
|
|
if err := os.Remove(path); err != nil {
|
|
l.logger.Warn(
|
|
"could not remove cover art file",
|
|
"path", path, "err", err,
|
|
)
|
|
|
|
continue
|
|
}
|
|
|
|
removed++
|
|
}
|
|
|
|
l.logger.Info("cover art files removed", "count", removed)
|
|
|
|
return nil
|
|
}
|