yonlu/yellowjacket
1
1
Fork 0
Code Issues 51 Pull Requests 4 Actions Packages Projects Releases 12 Wiki Activity

fix(library): sweep orphaned cover art when an album empties #251

Open
yonlu wants to merge 1 commits from fix/247-cover-art-orphans into main
pull from: fix/247-cover-art-orphans
merge into: :main
Conversation 0 Commits 1 Files Changed 4
+146 -51
yonlu commented 2026-09-09 14:23:35 +00:00
Owner
Copy Link
Copy Source
commit issue
32bb6491 fix(library): sweep orphaned cover art when an album empties #247

Verification

  • go test ./backend/library/...
  • golangci-lint run .

pruneEmptyEntities deleted empty albums but never the cover_art rows
they referenced, so removing the last track of an album leaked the row
and its files forever (the janitor's covers sweep computes its live set
from cover_art.file_path, keeping the orphaned row's files exempt).
Extracts one sweep used by the scan path, RemoveFromLibrary and
RemoveLibrary.

Closes #247

| commit | issue | |---|---| | `32bb6491` fix(library): sweep orphaned cover art when an album empties | #247 | ## Verification - `go test ./backend/library/...` - `golangci-lint run .` `pruneEmptyEntities` deleted empty albums but never the `cover_art` rows they referenced, so removing the last track of an album leaked the row and its files forever (the janitor's covers sweep computes its live set from `cover_art.file_path`, keeping the orphaned row's files exempt). Extracts one sweep used by the scan path, `RemoveFromLibrary` and `RemoveLibrary`. Closes #247
yonlu added 1 commit 2026-09-09 14:23:35 +00:00
fix(library): sweep orphaned cover art when an album empties
CI / check (push) Skipped
CI / e2e (push) Skipped
CI / check (pull_request) Successful in 3m19s
Details
CI / e2e (pull_request) Successful in 10m53s
Details
32bb64918c 
pruneEmptyEntities deleted empty albums but never the cover_art rows
they referenced, so removing the last track of an album leaked the row
and its files forever — the janitor's covers sweep computes its live set
from cover_art.file_path, which keeps the orphaned row's files exempt.

Extract sweepOrphanedCoverArt/removeCoverArtFiles as one implementation
and run it from pruneEmptyEntities (scan orphan path and
RemoveFromLibrary) and RemoveLibrary alike.

Closes #247
All checks were successful
CI / check (push) Skipped
Required
CI / e2e (push) Skipped
Required
CI / check (pull_request) Successful in 3m19s
Required
Details
CI / e2e (pull_request) Successful in 10m53s
Required
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/247-cover-art-orphans:fix/247-cover-art-orphans
git checkout fix/247-cover-art-orphans
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#251