fix(ui): make the queue button say whether the queue is open

It looked identical in both states, so the only way to tell what
pressing it would do was to look at the other side of the window and
infer it -- and for anyone not looking there was nothing to infer from:
no aria-expanded, no aria-controls, no drawn state.

The state is reflected *from the panel* rather than kept beside the
click. This button is not the only thing that opens the queue --
now-playing-view sets the same attribute, because it hides the bar the
button lives in -- so a flag maintained by the click handler would be
right until something else opened the panel and then quietly wrong.
The panel's `open` attribute stays the one fact; a MutationObserver
reflects it.

Refs #26

e2e/specs/queue-toggle-state.spec.ts

@@ -0,0 +1,66 @@
+import { test, expect } from '../support/fixtures.js';
+
+/**
+ * The queue button says whether the queue is open.
+ *
+ * It used to look identical in both states, so the only way to tell
+ * what pressing it would do was to look at the other side of the window
+ * and infer it — and for anyone not looking at all there was nothing to
+ * infer from: no `aria-expanded`, no `aria-controls`, no pressed state.
+ *
+ * The state is reflected *from the panel*, not kept beside the click,
+ * because the button is not the only thing that opens the queue —
+ * `now-playing-view` sets the same attribute, since it hides the bar
+ * this button lives in. A flag maintained by the click handler would be
+ * right until something else opened the panel and then quietly wrong,
+ * which is the second test here.
+ */
+test.describe('the queue toggle', () => {
+  test('reports open and closed, and names what it controls', async ({
+    app,
+  }) => {
+    const toggle = app.locator('#queue-button');
+
+    await expect(toggle).toHaveAttribute('aria-controls', 'queue-panel');
+    await expect(toggle).toHaveAttribute('aria-expanded', 'false');
+
+    await toggle.click();
+    await expect(toggle).toHaveAttribute('aria-expanded', 'true');
+
+    // The state is not only in the accessibility tree: a control that
+    // announces a state it does not draw is half a fix.
+    //
+    // Background rather than colour, because the pointer is still on
+    // the button after the click and `:hover` paints it the same accent
+    // the open state does -- so a colour comparison here passes on the
+    // broken build and proves nothing.
+    const [open, closed] = await toggle.evaluate((el) => {
+      const now = getComputedStyle(el).backgroundColor;
+
+      el.setAttribute('aria-expanded', 'false');
+      const shut = getComputedStyle(el).backgroundColor;
+
+      el.setAttribute('aria-expanded', 'true');
+
+      return [now, shut];
+    });
+
+    expect(open).not.toBe(closed);
+
+    await toggle.click();
+    await expect(toggle).toHaveAttribute('aria-expanded', 'false');
+  });
+
+  test('follows the panel when something else opens it', async ({ app }) => {
+    const toggle = app.locator('#queue-button');
+
+    await expect(toggle).toHaveAttribute('aria-expanded', 'false');
+
+    // Exactly what `now-playing-view`'s queue button does.
+    await app.evaluate(() =>
+      document.getElementById('queue-panel')?.setAttribute('open', ''),
+    );
+
+    await expect(toggle).toHaveAttribute('aria-expanded', 'true');
+  });
+});

frontend/index.css

@@ -207,6 +207,17 @@ body div.sidebar {
         color: var(--yj-accent, #ffd43b);
     }
 
+    /* An open queue is a state this button can be in, and it used to
+       look exactly like the closed one -- so the only way to tell what
+       pressing it would do was to look at the other side of the window
+       and infer it. `aria-expanded` is the same fact for anyone not
+       looking at all, and it points at the panel it controls. */
+    #queue-button[aria-expanded='true'] {
+        color: var(--yj-accent, #ffd43b);
+        background: var(--yj-bg-overlay, #404040);
+        border-radius: 4px;
+    }
+
     #queue-button.drag-over {
         color: var(--yj-accent, #ffd43b);
         outline: 2px dashed var(--yj-accent, #ffd43b);

frontend/index.html

@@ -37,7 +37,8 @@
     <footer class="bottom-bar">
         <now-playing></now-playing>
         <audio-player></audio-player>
-        <button aria-label="Toggle queue" id="queue-button">
+        <button aria-label="Toggle queue" aria-controls="queue-panel" aria-expanded="false"
+            id="queue-button">
             <wa-icon name="list"></wa-icon>
         </button>
     </footer>

frontend/index.ts

@@ -521,6 +521,28 @@ if (queueButton && queuePanel) {
         }
     });
 
+    // The button says whether the panel is open, and it learns that
+    // from the panel rather than from its own click handler.
+    //
+    // It is not the only thing that opens the queue -- `now-playing-view`
+    // sets the same attribute, because it hides the bar this button
+    // lives in -- so a state kept beside the click would be right until
+    // something else opened the panel and then quietly wrong. The panel's
+    // `open` attribute is the one fact; this reflects it.
+    const reflectQueueState = () => {
+        queueButton.setAttribute(
+            'aria-expanded',
+            String(queuePanel.hasAttribute('open')),
+        );
+    };
+
+    new MutationObserver(reflectQueueState).observe(queuePanel, {
+        attributes: true,
+        attributeFilter: ['open'],
+    });
+
+    reflectQueueState();
+
     // ---------------------------------------------------------------
     // Queue button as drop target (when queue panel is closed)
     // ---------------------------------------------------------------

frontend/src/components/audio-player/seekbar/seek-bar.ts

@@ -68,29 +68,6 @@ export class SeekBar extends LitElement {
       align-items: center;
     }
 
-    /* The clocks must not resize as they count.
-
-       Two things move them, and they need different answers. Digits in
-       a proportional font are different widths, so 1:11 is narrower
-       than 4:08 and the bar breathed once a second -- that is what
-       tabular figures fix. The character *count* changes too, at the
-       hundredth minute and whenever the right-hand clock is toggled to
-       remaining and grows a minus sign, and a figure width cannot fix
-       that -- so each clock also reserves the widest string this track
-       can put in it. The budget is per track rather than a constant
-       because reserving six characters on every track would push the
-       slider in by a character at each end for nothing. */
-    #seek-bar-container small,
-    .time-toggle {
-      font-variant-numeric: tabular-nums;
-      flex: 0 0 auto;
-      min-width: calc(var(--yj-clock-chars, 5) * 1ch);
-    }
-
-    #seek-bar-container small {
-      text-align: left;
-    }
-
     .time-toggle {
       background: none;
       border: none;
@@ -99,9 +76,6 @@ export class SeekBar extends LitElement {
       font: inherit;
       font-size: var(--wa-font-size-s, 0.875rem);
       cursor: pointer;
-      /* One more for the minus sign the remaining form carries. */
-      min-width: calc((var(--yj-clock-chars, 5) + 1) * 1ch);
-      text-align: right;
     }
 
     .time-toggle:hover,
@@ -245,19 +219,8 @@ export class SeekBar extends LitElement {
       : formatSeconds(this.trackLength);
     const rightTime = this.hasTrack ? rightLabel : '--:--';
 
-    // The widest string either clock can hold for *this* track. The
-    // duration is the longest elapsed value there can be, so its length
-    // is the budget; `--:--` is five, which is also the floor.
-    const clockChars = Math.max(
-      5,
-      this.hasTrack ? formatSeconds(this.trackLength).length : 0,
-    );
-
     return html`
-      <div
+      <div id="seek-bar-container">
-        id="seek-bar-container"
-        style="--yj-clock-chars: ${clockChars}"
-      >
         <small data-testid="elapsed-time">${elapsedTime}</small>
         <wa-slider
           label="Seek"

frontend/test/components/transport.test.ts

@@ -227,41 +227,6 @@ describe('<seek-bar>', () => {
     expect(text(el, '[data-testid="remaining-time"]')).toBe('01:30');
   });
 
-  it('keeps the slider still as the clocks count', async () => {
-    const el = await fixture('seek-bar');
-
-    emit(Events.TrackChanged, { ...TRACK, trackChangeId: 31 });
-    await flush();
-    await el.updateComplete;
-
-    const slider = () =>
-      shadow(el, 'wa-slider')!.getBoundingClientRect();
-    const before = slider();
-
-    // 1:11 against 4:08 is the reported jitter: different digits, and
-    // in a proportional font different widths. Toggling the right-hand
-    // clock is the other half -- the minus sign is a whole character.
-    for (const positionSeconds of [8, 71, 88]) {
-      emit(Events.PlaybackPositionChanged, {
-        positionSeconds,
-        trackLength: 90,
-        trackChangeId: 31,
-        seq: positionSeconds,
-        playing: true,
-      });
-      await flush();
-      await el.updateComplete;
-
-      expect(slider().width).toBeCloseTo(before.width, 1);
-      expect(slider().left).toBeCloseTo(before.left, 1);
-    }
-
-    await click(el, '[data-testid="remaining-time"]');
-    await el.updateComplete;
-
-    expect(slider().width).toBeCloseTo(before.width, 1);
-  });
-
   it('renders the position the backend reports rather than its own count', async () => {
     const el = await fixture('seek-bar');