yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Desktop: the queue toggle button does not show whether the queue is open #26

New Issue
Closed
opened 2026-08-18 05:55:00 +00:00 by logan · 1 comment
logan commented 2026-08-18 05:55:00 +00:00
Collaborator
Copy Link
Copy Source

Report

When the queue sidebar is open, the button that toggles it looks the same as when it is closed. Its state should be obvious.

Direction

Give it a pressed state — visually and in the accessibility tree (aria-pressed, or aria-expanded + aria-controls pointing at the panel, which is the pattern config-section's disclosure uses). The panel has to be in the DOM for aria-controls to name it; it already is (a closed panel renders no list, but the element exists).

Same button exists on the phone layout and in now-playing-view (which carries its own, because it hides the bar the normal one lives in) — fix all of them.

**Report** When the queue sidebar is open, the button that toggles it looks the same as when it is closed. Its state should be obvious. **Direction** Give it a pressed state — visually and in the accessibility tree (`aria-pressed`, or `aria-expanded` + `aria-controls` pointing at the panel, which is the pattern `config-section`'s disclosure uses). The panel has to be in the DOM for `aria-controls` to name it; it already is (a closed panel renders no list, but the element exists). Same button exists on the phone layout and in `now-playing-view` (which carries its own, because it hides the bar the normal one lives in) — fix all of them.
logan added the Area/QueueKind/EnhancementPlatform/Desktop
Priority
Medium
3
 labels 2026-08-18 14:36:08 +00:00
logan self-assigned this 2026-08-18 15:10:29 +00:00
yonlu commented 2026-08-18 19:56:52 +00:00
Owner
Copy Link
Copy Source

Shipped in main as a2ff0ae — fix(ui): make the queue button say whether the queue is open — merged through #83. This was listed in that PR's Closes line but did not close automatically; closing it now.

Shipped in `main` as `a2ff0ae` — fix(ui): make the queue button say whether the queue is open — merged through #83. This was listed in that PR's `Closes` line but did not close automatically; closing it now.
yonlu closed this issue 2026-08-18 19:56:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Queue Kind/Enhancement Platform/Desktop
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees logan
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#26