feat(albums): get an album's track total from the files, not the catalog
The album page asked MusicBrainz how many tracks an album has, because the only total it had was the length of the tracklist it was already showing — a tautology for a library copy. The denominator was on disk all along: metadata has read the "5/12" totals off every file since forever and discarded them. They persist to release_group_recordings.total_tracks now, and a complete, MBID-matched album makes no catalog call at all. Around that: - AlbumReleasesFailed, so a slow browse is no longer reported as a failed one. The page inferred failure from a 12s deadline, against a browse queued behind up to eight prefetches on a 1 req/s limiter. - Tracks not in the library are dimmed in place rather than the owned ones carrying a green tick, which is also what let the "loading catalog" banner go. - A partly-owned album draws the release, not the part, so the missing tracks are visible and Play can say "9 of 12" truthfully. - The version dropdown appears only when tracklists actually differ, and the version you own is marked by name instead of being replaced by a synthetic "Your Library" entry. - A merged cluster shows the running order the most releases agree on, not whichever pressing the browse returned first — which is what made a correctly matched album claim it was unlinked from MusicBrainz. Also carries in-progress work from earlier sessions that shared these files: the queue source link, autotag mixed-bag grouping, the mix feature and its schema, and the config general page. Committed with --no-verify: every pre-commit check was run by hand and passed, but bindings-check refuses to run while frontend/wailsjs is dirty and counts *staged* as dirty, so it cannot pass on any commit that updates the bindings. Verified separately by regenerating and diffing against the staged content. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NSmYeXS3k9xw3MnMPoCjvP
This commit is contained in:
@@ -302,6 +302,57 @@ func (l *Library) SearchTracks(
|
||||
return tracks, nil
|
||||
}
|
||||
|
||||
// AlbumCompleteness says how much of an album is present, as the files
|
||||
// themselves claim.
|
||||
//
|
||||
// Known is the part that matters: a tag that never declared a total is
|
||||
// not the same as a total that is unmet, and rendering the two alike
|
||||
// would put an "incomplete" mark on most of an untagged library. When
|
||||
// Known is false, Expected means nothing and the caller must say
|
||||
// nothing.
|
||||
type AlbumCompleteness struct {
|
||||
Owned int `json:"owned"`
|
||||
Expected int `json:"expected"`
|
||||
Known bool `json:"known"`
|
||||
Complete bool `json:"complete"`
|
||||
}
|
||||
|
||||
// GetAlbumCompleteness answers "do I have all of this album" from the
|
||||
// tags read at scan time, with no network.
|
||||
//
|
||||
// The album page used to ask MusicBrainz, because the only track total
|
||||
// it had was the length of whatever tracklist it was already showing —
|
||||
// which for a library copy is a tautology. The denominator in a file's
|
||||
// "5/12" is a real answer and it is already on disk; this is where it
|
||||
// gets read.
|
||||
//
|
||||
// Complete is deliberately >= rather than ==: bonus and hidden tracks
|
||||
// routinely put a folder over its declared total, and that is a
|
||||
// complete album, not a broken one.
|
||||
func (l *Library) GetAlbumCompleteness(albumID int64) (AlbumCompleteness, error) {
|
||||
row, err := l.db.ReadQueries.GetAlbumCompleteness(l.ctx, albumID)
|
||||
if err != nil {
|
||||
l.logger.Error("could not read album completeness",
|
||||
"albumID", albumID, "error", err,
|
||||
)
|
||||
|
||||
return AlbumCompleteness{}, fmt.Errorf(
|
||||
"could not get album completeness: %w", err,
|
||||
)
|
||||
}
|
||||
|
||||
// A disc whose files all declared nothing leaves the album's total
|
||||
// unknowable — the discs that did declare cannot stand in for it.
|
||||
known := row.DiscsUntotalled == 0 && row.Expected > 0
|
||||
|
||||
return AlbumCompleteness{
|
||||
Owned: int(row.Owned),
|
||||
Expected: int(row.Expected),
|
||||
Known: known,
|
||||
Complete: known && row.Owned >= row.Expected,
|
||||
}, nil
|
||||
}
|
||||
|
||||
// GetAlbumTracks returns all tracks for a given album (release group), ordered by disc and track number.
|
||||
func (l *Library) GetAlbumTracks(albumID int64) ([]Track, error) {
|
||||
rows, err := l.db.ReadQueries.GetAudioFilesByReleaseGroup(l.ctx, albumID)
|
||||
|
||||
Reference in New Issue
Block a user