fix(a11y): let the shell scroll sideways when it does not fit
Build & publish Arch package / arch-package (push) Successful in 2m1s
CI / check (push) Successful in 2m33s
Search index maintenance / maintain-index (push) Successful in 6s
CI / e2e (push) Canceled after 2m3s

a11y.21 (WCAG 1.4.10), measured rather than taken as filed. The
finding's mechanism is vertical — "the 4em bars grow while the viewport
does not, and anything that no longer fits is clipped with no
scrollbar" — and that is not what happens. The middle row is `1fr` and
absorbs the growth exactly: at 200% text on 800x600 the bars go 64px to
128px and the panel 472px to 344px, with the footer still landing on
600. Nothing is clipped vertically, and Settings stays reachable
because the sidebar scrolls (007 phase 5).

What is real is the axis the finding does not mention. At 200% text the
shell is 1014px wide in an 800px viewport, and at 320px — 400% page
zoom of 1280, the width 1.4.10 names — it is 784px, so 464px of the
app including the job indicator and the queue button sat behind
`overflow: hidden` with no way to reach it.

So the horizontal axis scrolls and the vertical one stays fixed, which
also keeps the transport where a desktop player's transport belongs. At
every size this app promises there is no overflow on either axis and no
scrollbar appears, which the three viewport cases assert.

The first version of the spec passed on the broken build: `overflow:
hidden` still permits programmatic scrolling, so `scrollLeft = 9999`
proves nothing. It is a wheel gesture now.
This commit is contained in:
2026-08-13 02:22:49 -04:00
parent 254646da5e
commit 4efd17d477
2 changed files with 113 additions and 1 deletions
+90
View File
@@ -158,3 +158,93 @@ test.describe('the title block fits its bar', () => {
expect(fits.bottom).toBe(true);
});
});
/**
* `a11y.21` (WCAG 1.4.10 Reflow), measured rather than taken as filed.
*
* The finding's mechanism is vertical — "at high zoom the 4em bars grow
* while the viewport does not, and anything that no longer fits is
* clipped with no scrollbar" — and that is not what happens. The middle
* row is `1fr` and absorbs the bars exactly. What is real is the axis
* the finding does not mention.
*/
test.describe('the shell reflows rather than hiding what does not fit', () => {
test('larger text shrinks the panel instead of clipping the shell', async ({
app,
}) => {
await app.setViewportSize({ width: 800, height: 600 });
await app.evaluate(() => {
document.documentElement.style.fontSize = '32px';
});
const shell = await app.evaluate(() => {
const foot = document.querySelector('.bottom-bar')!.getBoundingClientRect();
const main = document.querySelector('#main-content')!.getBoundingClientRect();
return {
footBottom: Math.round(foot.bottom),
viewport: document.documentElement.clientHeight,
mainHeight: Math.round(main.height),
};
});
// 200% text takes the bars from 64px to 128px each and the panel
// from 472px to 344px, and the footer still lands exactly on the
// bottom of the viewport. Nothing is clipped vertically.
expect(shell.footBottom).toBe(shell.viewport);
expect(shell.mainHeight).toBeGreaterThan(300);
await app.evaluate(() => {
document.documentElement.style.fontSize = '';
});
});
test('what does not fit sideways can be scrolled to', async ({ app }) => {
// 320 CSS px is 400% page zoom of a 1280px viewport, which is the
// size 1.4.10 names. The shell is 784px wide there, so 464px of the
// app — the job indicator and the queue button among it — used to
// be behind `overflow: hidden` with no way to reach it.
await app.setViewportSize({ width: 320, height: 256 });
// A *gesture*, not `scrollLeft = 9999`: `overflow: hidden` still
// permits programmatic scrolling, so the obvious probe passes on
// the build that has the bug. It did, first time.
await app.mouse.move(160, 20);
await app.mouse.wheel(400, 400);
await app.waitForTimeout(200);
const reach = await app.evaluate(() => {
const se = document.scrollingElement!;
return { left: se.scrollLeft, top: se.scrollTop };
});
expect(reach.left).toBeGreaterThan(0);
// And the vertical axis stays fixed, which is what keeps the
// transport where a desktop player's transport belongs.
expect(reach.top).toBe(0);
await app.evaluate(() => {
document.scrollingElement!.scrollLeft = 0;
});
await app.setViewportSize({ width: 1440, height: 900 });
});
for (const vp of VIEWPORTS) {
test(`no scrollbar appears at ${vp.name}`, async ({ app }) => {
await app.setViewportSize({ width: vp.width, height: vp.height });
const excess = await app.evaluate(() => {
const de = document.documentElement;
return de.scrollWidth - de.clientWidth;
});
// The other half: at every size this app promises, the fix costs
// nothing. A scrollbar that is always there is a worse answer
// than the clipping it replaced.
expect(excess).toBe(0);
});
}
});
+23 -1
View File
@@ -16,7 +16,29 @@ body {
height: 100vh;
display: grid;
grid-template: "top-bar top-bar" 4em "sidebar main-panel" 1fr "bottom-bar bottom-bar" 4em / auto 1fr;
overflow: hidden;
/* a11y.21 (WCAG 1.4.10), measured rather than taken as filed.
The finding's mechanism is vertical — "the 4em bars grow while
the viewport does not, and anything that no longer fits is
clipped with no scrollbar" — and that is not what happens. The
middle row is `1fr`, so it absorbs the bars exactly: at 200%
text on an 800×600 window the bars go 64px → 128px and the main
panel goes 472px → 344px, with the footer's bottom still landing
on 600. Nothing is clipped, and Settings stays reachable because
the sidebar scrolls (007 phase 5).
What is real is the other axis, which the finding does not
mention: at 200% text the shell is 1014px wide in an 800px
viewport, and at 320px (400% page zoom of 1280) it is 611px —
291px of the app unreachable behind `overflow: hidden`. So the
horizontal axis scrolls and the vertical one stays fixed, which
is also what keeps the transport bar where a desktop player's
transport bar belongs. At every size this app promises
(800×600 and up, default text) there is no overflow on either
axis and no scrollbar appears. */
overflow-x: auto;
overflow-y: hidden;
}
p {