docs: drop the webkit2_41 tag from the commands agents run
The commit before this removed the tag from the Makefile, lefthook, both packaging recipes and CI, but left it in CLAUDE.md's "Running tests" section and the yellowjacket-dev skill — which are the copies a coding agent actually runs, so a stale tag there is worse than one in prose. skill-check does not catch this: it verifies that documented make targets exist, not that documented go commands do. The historical mentions in .planning/ and .pi/journal.md are left alone; they are records of what was true then. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UDCbcCZQepnpSQYJ6SxxZm
This commit is contained in:
@@ -387,10 +387,10 @@ never get the shell back.
|
||||
when iterating on a single package:
|
||||
|
||||
```bash
|
||||
go test -tags webkit2_41 ./backend/player/ # the app build
|
||||
go test -tags webkit2_41 -run TestName ./backend/player/
|
||||
go test -tags "webkit2_41 indexbuild" ./backend/explore/... ./cmd/... # dump importer
|
||||
go test -tags "webkit2_41 dev" ./backend/testctl/... # control surface
|
||||
go test ./backend/player/ # the app build
|
||||
go test -run TestName ./backend/player/
|
||||
go test -tags indexbuild ./backend/explore/... ./cmd/... # dump importer
|
||||
go test -tags dev ./backend/testctl/... # control surface
|
||||
```
|
||||
|
||||
Forgetting the tag gives a build error that looks like a missing
|
||||
|
||||
@@ -35,7 +35,7 @@ Then:
|
||||
|
||||
```bash
|
||||
make generate # sqlc + templ
|
||||
go test -tags webkit2_41 ./backend/database/ # migration + column-order tests
|
||||
go test ./backend/database/ # migration + column-order tests
|
||||
make test
|
||||
```
|
||||
|
||||
|
||||
@@ -50,12 +50,15 @@ make setup # Install go tools, frontend deps, git hooks (lefthook)
|
||||
|
||||
### Running tests
|
||||
|
||||
All Go test commands require the `-tags webkit2_41` build tag:
|
||||
Go test commands need no build tag for the app configuration. The
|
||||
`webkit2_41` tag every command here used to carry is gone with wails
|
||||
v2: v3 builds against GTK4 + WebKitGTK 6.0 by default, which both Arch
|
||||
and ubuntu:24.04 ship.
|
||||
|
||||
```bash
|
||||
go test -tags webkit2_41 ./... # All tests
|
||||
go test -tags webkit2_41 ./backend/player/ # Single package
|
||||
go test -tags webkit2_41 -run TestName ./backend/player/ # Single test
|
||||
go test ./... # All tests
|
||||
go test ./backend/player/ # Single package
|
||||
go test -run TestName ./backend/player/ # Single test
|
||||
```
|
||||
|
||||
The central index builder is behind a second tag and is **not** covered
|
||||
@@ -63,14 +66,14 @@ by the command above — `make test` runs both passes, but a manual run
|
||||
needs it spelled out:
|
||||
|
||||
```bash
|
||||
go test -tags "webkit2_41 indexbuild" ./backend/explore/... ./cmd/...
|
||||
go test -tags indexbuild ./backend/explore/... ./cmd/...
|
||||
```
|
||||
|
||||
`backend/testctl` is behind a third tag and needs its own pass too
|
||||
(`make test` runs all three):
|
||||
|
||||
```bash
|
||||
go test -tags "webkit2_41 dev" ./backend/testctl/...
|
||||
go test -tags dev ./backend/testctl/...
|
||||
```
|
||||
|
||||
Audio playback integration tests require `YELLOWJACKET_INTEGRATION=1`.
|
||||
@@ -1518,8 +1521,10 @@ And
|
||||
`YJ_CORE_INDEX_URL` points at a dead address so no run fetches the real
|
||||
explore artifact, matching what `scripts/seed-sandbox.sh` already does.
|
||||
|
||||
**`make lint`'s tag sets must stay identical to `make test`'s.**
|
||||
Without `webkit2_41` wails resolves `webkit2gtk-4.0`, which Arch still
|
||||
ships and Ubuntu 24.04 does not — so a mismatch lints a configuration
|
||||
that only builds on one developer's distro, and says nothing about what
|
||||
ships.
|
||||
**`make lint`'s tag sets must stay identical to `make test`'s**, or
|
||||
lint is checking configurations nothing builds. There are three, and
|
||||
the app's is now the *default* tag set: v3 resolves GTK4 +
|
||||
WebKitGTK 6.0, which Arch and ubuntu:24.04 both ship, so the
|
||||
`webkit2_41` tag that used to be mandatory everywhere is gone. A
|
||||
machine without `webkitgtk-6.0` can still build with `-tags gtk3`, but
|
||||
that is an escape hatch, not what CI or a release builds.
|
||||
|
||||
Reference in New Issue
Block a user