test(04-01): add queue core operations and navigation tests
- Queue operations: SetQueue, AddTrack, InsertTracksAt, MoveQueueTracks, RemoveTrack, Clear, ToggleShuffle, CycleRepeat - Navigation: nextIndex/previousIndex in all repeat modes (off/all/one) - Shuffle: generateShuffleOrder properties (no duplicates, current at [0]), shuffle navigation - Mock TrackLoader and seedAudioFiles helper for DB-backed tests - 23 tests total (14 core + 9 navigation) all passing with -race
This commit is contained in:
@@ -0,0 +1,197 @@
|
||||
package queue
|
||||
|
||||
import (
|
||||
"log/slog"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// newTestQueueDirect creates a Queue with direct field manipulation
|
||||
// (no DB needed) for pure navigation logic tests.
|
||||
func newTestQueueDirect(tracks int, currentIndex int) *Queue {
|
||||
q := &Queue{
|
||||
logger: slog.Default(),
|
||||
repeatMode: RepeatOff,
|
||||
}
|
||||
|
||||
q.tracks = make([]Track, tracks)
|
||||
for i := 0; i < tracks; i++ {
|
||||
q.tracks[i] = Track{FilePath: "/test/track.mp3", Position: int64(i)}
|
||||
}
|
||||
|
||||
q.currentIndex = currentIndex
|
||||
|
||||
return q
|
||||
}
|
||||
|
||||
func TestNextIndex_NormalMode_AdvancesToNextTrack(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 2)
|
||||
|
||||
got := q.nextIndex()
|
||||
if got != 3 {
|
||||
t.Errorf("nextIndex: got %d, want 3", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestNextIndex_NormalMode_EndOfQueue_RepeatOff(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 4)
|
||||
|
||||
got := q.nextIndex()
|
||||
if got != -1 {
|
||||
t.Errorf("nextIndex at end (repeatOff): got %d, want -1", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestNextIndex_NormalMode_EndOfQueue_RepeatAll(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 4)
|
||||
q.repeatMode = RepeatAll
|
||||
|
||||
got := q.nextIndex()
|
||||
if got != 0 {
|
||||
t.Errorf("nextIndex at end (repeatAll): got %d, want 0", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestNextIndex_RepeatOne(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
// Note: RepeatOne is handled in the Next() method, not nextIndex().
|
||||
// nextIndex() with RepeatOne still advances normally — the repeat-one
|
||||
// logic replays the current track before calling nextIndex().
|
||||
// This test verifies nextIndex advances in the RepeatOne case.
|
||||
q := newTestQueueDirect(5, 2)
|
||||
q.repeatMode = RepeatOne
|
||||
|
||||
got := q.nextIndex()
|
||||
// nextIndex itself doesn't handle RepeatOne — it just advances.
|
||||
if got != 3 {
|
||||
t.Errorf("nextIndex (repeatOne): got %d, want 3", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPreviousIndex_NormalMode_GoesBack(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 3)
|
||||
|
||||
got := q.previousIndex()
|
||||
if got != 2 {
|
||||
t.Errorf("previousIndex: got %d, want 2", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPreviousIndex_AtStart_RepeatOff(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 0)
|
||||
|
||||
got := q.previousIndex()
|
||||
if got != -1 {
|
||||
t.Errorf("previousIndex at start (repeatOff): got %d, want -1", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPreviousIndex_AtStart_RepeatAll(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 0)
|
||||
q.repeatMode = RepeatAll
|
||||
|
||||
got := q.previousIndex()
|
||||
if got != 4 {
|
||||
t.Errorf("previousIndex at start (repeatAll): got %d, want 4", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGenerateShuffleOrder_Properties(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
testCases := []struct {
|
||||
name string
|
||||
trackCount int
|
||||
currentIdx int
|
||||
}{
|
||||
{"single track", 1, 0},
|
||||
{"five tracks", 5, 2},
|
||||
{"twenty tracks", 20, 10},
|
||||
}
|
||||
|
||||
for _, tc := range testCases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(tc.trackCount, tc.currentIdx)
|
||||
q.generateShuffleOrder()
|
||||
|
||||
// Property 1: length matches track count.
|
||||
if got := len(q.shuffleOrder); got != tc.trackCount {
|
||||
t.Errorf("shuffleOrder length: got %d, want %d", got, tc.trackCount)
|
||||
}
|
||||
|
||||
// Property 2: current track is at shuffleOrder[0].
|
||||
if q.shuffleOrder[0] != tc.currentIdx {
|
||||
t.Errorf("shuffleOrder[0]: got %d, want %d (currentIndex)", q.shuffleOrder[0], tc.currentIdx)
|
||||
}
|
||||
|
||||
// Property 3: all indices present (no duplicates, no missing).
|
||||
seen := make(map[int]bool, tc.trackCount)
|
||||
for _, idx := range q.shuffleOrder {
|
||||
if idx < 0 || idx >= tc.trackCount {
|
||||
t.Errorf("shuffleOrder contains out-of-range index: %d", idx)
|
||||
}
|
||||
|
||||
if seen[idx] {
|
||||
t.Errorf("shuffleOrder contains duplicate index: %d", idx)
|
||||
}
|
||||
|
||||
seen[idx] = true
|
||||
}
|
||||
|
||||
if len(seen) != tc.trackCount {
|
||||
t.Errorf("unique indices in shuffleOrder: got %d, want %d", len(seen), tc.trackCount)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestNextIndex_ShuffleMode(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q := newTestQueueDirect(5, 2)
|
||||
q.shuffleMode = true
|
||||
// Set a known shuffle order: [2, 4, 0, 3, 1]
|
||||
// Current index is 2, which is at shuffleOrder[0].
|
||||
q.shuffleOrder = []int{2, 4, 0, 3, 1}
|
||||
|
||||
// Next in shuffle order should be shuffleOrder[1] = 4.
|
||||
got := q.nextIndex()
|
||||
if got != 4 {
|
||||
t.Errorf("nextIndex (shuffle): got %d, want 4", got)
|
||||
}
|
||||
|
||||
// Advance to index 4 and get next.
|
||||
q.currentIndex = 4
|
||||
got = q.nextIndex()
|
||||
if got != 0 {
|
||||
t.Errorf("nextIndex (shuffle, pos 2): got %d, want 0", got)
|
||||
}
|
||||
|
||||
// At the end of shuffle order with RepeatOff.
|
||||
q.currentIndex = 1 // last in shuffleOrder
|
||||
got = q.nextIndex()
|
||||
if got != -1 {
|
||||
t.Errorf("nextIndex (shuffle, end, repeatOff): got %d, want -1", got)
|
||||
}
|
||||
|
||||
// At the end of shuffle order with RepeatAll.
|
||||
q.repeatMode = RepeatAll
|
||||
got = q.nextIndex()
|
||||
if got != 2 {
|
||||
t.Errorf("nextIndex (shuffle, end, repeatAll): got %d, want 2 (wraps to shuffleOrder[0])", got)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,394 @@
|
||||
package queue
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"log/slog"
|
||||
"testing"
|
||||
|
||||
"yellowjacket/backend/database"
|
||||
)
|
||||
|
||||
// mockTrackLoader satisfies the TrackLoader interface for tests.
|
||||
// All methods are no-ops.
|
||||
type mockTrackLoader struct {
|
||||
loadedFile string
|
||||
}
|
||||
|
||||
func (m *mockTrackLoader) LoadFile(filePath string) error {
|
||||
m.loadedFile = filePath
|
||||
return nil
|
||||
}
|
||||
|
||||
func (m *mockTrackLoader) Play() error { return nil }
|
||||
func (m *mockTrackLoader) IsPlaying() bool { return false }
|
||||
func (m *mockTrackLoader) UnloadTrack() {}
|
||||
|
||||
func (m *mockTrackLoader) CurrentPositionSeconds() (int, error) {
|
||||
return 0, nil
|
||||
}
|
||||
|
||||
// setupTestQueue creates an isolated Queue backed by an in-memory DB.
|
||||
func setupTestQueue(t *testing.T) (*Queue, *database.DB) {
|
||||
t.Helper()
|
||||
|
||||
db := database.NewTestDB(t)
|
||||
q := NewQueue(slog.Default(), db)
|
||||
q.SetPlayer(&mockTrackLoader{})
|
||||
|
||||
return q, db
|
||||
}
|
||||
|
||||
// seedAudioFiles inserts `count` audio_file rows (with FK chain) and
|
||||
// returns the file paths as a string slice.
|
||||
func seedAudioFiles(t *testing.T, db *database.DB, count int) []string {
|
||||
t.Helper()
|
||||
|
||||
// Shared artist credit.
|
||||
_, err := db.ExecContext(
|
||||
"INSERT OR IGNORE INTO artist_credit (id, text) VALUES (1, 'Test Artist')",
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("insert artist_credit: %v", err)
|
||||
}
|
||||
|
||||
paths := make([]string, count)
|
||||
|
||||
for i := 0; i < count; i++ {
|
||||
recID := i + 1
|
||||
afID := i + 1
|
||||
fp := fmt.Sprintf("/test/track%d.mp3", i+1)
|
||||
paths[i] = fp
|
||||
|
||||
_, err := db.ExecContext(
|
||||
"INSERT OR IGNORE INTO recordings (id, name, artist_credit_id) VALUES (?, ?, 1)",
|
||||
recID, fmt.Sprintf("Track %d", i+1),
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("insert recording %d: %v", recID, err)
|
||||
}
|
||||
|
||||
_, err = db.ExecContext(
|
||||
"INSERT OR IGNORE INTO audio_files (id, file_path, length_milliseconds, file_type_id, recording_id) VALUES (?, ?, 180000, 0, ?)",
|
||||
afID, fp, recID,
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("insert audio_file %d: %v", afID, err)
|
||||
}
|
||||
}
|
||||
|
||||
return paths
|
||||
}
|
||||
|
||||
func TestSetQueue_PopulatesTracks(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 0, false)
|
||||
|
||||
state := q.GetState()
|
||||
if got := len(state.Tracks); got != 5 {
|
||||
t.Errorf("track count: got %d, want 5", got)
|
||||
}
|
||||
|
||||
if state.CurrentIndex != 0 {
|
||||
t.Errorf("currentIndex: got %d, want 0", state.CurrentIndex)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetQueue_WithStartIndex(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 2, false)
|
||||
|
||||
state := q.GetState()
|
||||
if state.CurrentIndex != 2 {
|
||||
t.Errorf("currentIndex: got %d, want 2", state.CurrentIndex)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetQueue_WithShuffleStart(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
// Enable shuffle mode first.
|
||||
q.ToggleShuffle()
|
||||
|
||||
q.SetQueue(paths, 0, true)
|
||||
|
||||
state := q.GetState()
|
||||
if !state.ShuffleMode {
|
||||
t.Error("shuffleMode: got false, want true")
|
||||
}
|
||||
|
||||
q.mu.Lock()
|
||||
soLen := len(q.shuffleOrder)
|
||||
q.mu.Unlock()
|
||||
|
||||
if soLen != 5 {
|
||||
t.Errorf("shuffleOrder length: got %d, want 5", soLen)
|
||||
}
|
||||
}
|
||||
|
||||
func TestAddTrack_AppendsToQueue(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 4)
|
||||
|
||||
q.SetQueue(paths[:3], 0, false)
|
||||
q.AddTrack(paths[3])
|
||||
|
||||
state := q.GetState()
|
||||
if got := len(state.Tracks); got != 4 {
|
||||
t.Errorf("track count: got %d, want 4", got)
|
||||
}
|
||||
|
||||
lastTrack := state.Tracks[len(state.Tracks)-1]
|
||||
if lastTrack.FilePath != paths[3] {
|
||||
t.Errorf("last track path: got %q, want %q", lastTrack.FilePath, paths[3])
|
||||
}
|
||||
}
|
||||
|
||||
func TestInsertTracksAt_BeforeCurrentIndex(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 7)
|
||||
|
||||
q.SetQueue(paths[:5], 2, false)
|
||||
|
||||
// Insert 2 tracks at index 1 (before currentIndex=2).
|
||||
q.InsertTracksAt(paths[5:7], 1)
|
||||
|
||||
state := q.GetState()
|
||||
// currentIndex should shift by 2 (the number of inserted tracks).
|
||||
if state.CurrentIndex != 4 {
|
||||
t.Errorf("currentIndex after insert before: got %d, want 4", state.CurrentIndex)
|
||||
}
|
||||
|
||||
if got := len(state.Tracks); got != 7 {
|
||||
t.Errorf("track count: got %d, want 7", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestInsertTracksAt_AfterCurrentIndex(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 7)
|
||||
|
||||
q.SetQueue(paths[:5], 2, false)
|
||||
|
||||
// Insert 2 tracks at index 3 (after currentIndex=2).
|
||||
q.InsertTracksAt(paths[5:7], 3)
|
||||
|
||||
state := q.GetState()
|
||||
// currentIndex should remain 2.
|
||||
if state.CurrentIndex != 2 {
|
||||
t.Errorf("currentIndex after insert after: got %d, want 2", state.CurrentIndex)
|
||||
}
|
||||
}
|
||||
|
||||
func TestMoveQueueTracks_ForwardMove(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 0, false)
|
||||
|
||||
// Move track at index 1 to index 3.
|
||||
q.MoveQueueTracks([]int{1}, 3)
|
||||
|
||||
state := q.GetState()
|
||||
// After moving index 1 forward: the track originally at index 1
|
||||
// should now be at index 2 (adjustedIdx = 3-1 = 2).
|
||||
if state.Tracks[2].FilePath != paths[1] {
|
||||
t.Errorf("moved track: got %q at index 2, want %q", state.Tracks[2].FilePath, paths[1])
|
||||
}
|
||||
}
|
||||
|
||||
func TestMoveQueueTracks_BackwardMove(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 0, false)
|
||||
|
||||
// Move track at index 3 to index 1.
|
||||
q.MoveQueueTracks([]int{3}, 1)
|
||||
|
||||
state := q.GetState()
|
||||
// Track originally at index 3 should now be at index 1.
|
||||
if state.Tracks[1].FilePath != paths[3] {
|
||||
t.Errorf("moved track: got %q at index 1, want %q", state.Tracks[1].FilePath, paths[3])
|
||||
}
|
||||
}
|
||||
|
||||
func TestMoveQueueTracks_MoveCurrentTrack(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 2, false)
|
||||
|
||||
// Move the current track (index 2) to index 4.
|
||||
q.MoveQueueTracks([]int{2}, 4)
|
||||
|
||||
state := q.GetState()
|
||||
// The current track should follow to its new position.
|
||||
currentPath := state.Tracks[state.CurrentIndex].FilePath
|
||||
if currentPath != paths[2] {
|
||||
t.Errorf("current track after move: got %q, want %q", currentPath, paths[2])
|
||||
}
|
||||
}
|
||||
|
||||
func TestRemoveTrack_RemovesCorrectTrack(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 0, false)
|
||||
|
||||
q.RemoveTrack(2)
|
||||
|
||||
state := q.GetState()
|
||||
if got := len(state.Tracks); got != 4 {
|
||||
t.Errorf("track count: got %d, want 4", got)
|
||||
}
|
||||
|
||||
// Verify the removed track (paths[2]) is not present.
|
||||
for _, track := range state.Tracks {
|
||||
if track.FilePath == paths[2] {
|
||||
t.Errorf("removed track %q still present in queue", paths[2])
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestRemoveTrack_RemoveCurrentTrack(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 2, false)
|
||||
|
||||
q.RemoveTrack(2)
|
||||
|
||||
state := q.GetState()
|
||||
if got := len(state.Tracks); got != 4 {
|
||||
t.Errorf("track count: got %d, want 4", got)
|
||||
}
|
||||
|
||||
// After removing currentIndex=2, index should be clamped to valid range.
|
||||
if state.CurrentIndex < 0 || state.CurrentIndex >= len(state.Tracks) {
|
||||
t.Errorf("currentIndex out of range: got %d, track count %d", state.CurrentIndex, len(state.Tracks))
|
||||
}
|
||||
}
|
||||
|
||||
func TestClear_EmptiesQueue(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 0, false)
|
||||
q.Clear()
|
||||
|
||||
state := q.GetState()
|
||||
if got := len(state.Tracks); got != 0 {
|
||||
t.Errorf("track count after clear: got %d, want 0", got)
|
||||
}
|
||||
|
||||
if state.CurrentIndex != -1 {
|
||||
t.Errorf("currentIndex after clear: got %d, want -1", state.CurrentIndex)
|
||||
}
|
||||
}
|
||||
|
||||
func TestToggleShuffle_TogglesMode(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
paths := seedAudioFiles(t, db, 5)
|
||||
|
||||
q.SetQueue(paths, 0, false)
|
||||
|
||||
// Toggle on.
|
||||
q.ToggleShuffle()
|
||||
state := q.GetState()
|
||||
|
||||
if !state.ShuffleMode {
|
||||
t.Error("shuffleMode after first toggle: got false, want true")
|
||||
}
|
||||
|
||||
q.mu.Lock()
|
||||
soLen := len(q.shuffleOrder)
|
||||
q.mu.Unlock()
|
||||
|
||||
if soLen != 5 {
|
||||
t.Errorf("shuffleOrder length after toggle on: got %d, want 5", soLen)
|
||||
}
|
||||
|
||||
// Toggle off.
|
||||
q.ToggleShuffle()
|
||||
state = q.GetState()
|
||||
|
||||
if state.ShuffleMode {
|
||||
t.Error("shuffleMode after second toggle: got true, want false")
|
||||
}
|
||||
|
||||
q.mu.Lock()
|
||||
soLen = len(q.shuffleOrder)
|
||||
q.mu.Unlock()
|
||||
|
||||
if soLen != 0 {
|
||||
t.Errorf("shuffleOrder length after toggle off: got %d, want 0", soLen)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCycleRepeat_CyclesThroughModes(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
q, db := setupTestQueue(t)
|
||||
_ = seedAudioFiles(t, db, 1)
|
||||
|
||||
// Default is RepeatOff.
|
||||
state := q.GetState()
|
||||
if state.RepeatMode != RepeatOff {
|
||||
t.Errorf("initial repeatMode: got %q, want %q", state.RepeatMode, RepeatOff)
|
||||
}
|
||||
|
||||
// off -> all
|
||||
q.CycleRepeat()
|
||||
state = q.GetState()
|
||||
|
||||
if state.RepeatMode != RepeatAll {
|
||||
t.Errorf("after first cycle: got %q, want %q", state.RepeatMode, RepeatAll)
|
||||
}
|
||||
|
||||
// all -> one
|
||||
q.CycleRepeat()
|
||||
state = q.GetState()
|
||||
|
||||
if state.RepeatMode != RepeatOne {
|
||||
t.Errorf("after second cycle: got %q, want %q", state.RepeatMode, RepeatOne)
|
||||
}
|
||||
|
||||
// one -> off
|
||||
q.CycleRepeat()
|
||||
state = q.GetState()
|
||||
|
||||
if state.RepeatMode != RepeatOff {
|
||||
t.Errorf("after third cycle: got %q, want %q", state.RepeatMode, RepeatOff)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user