docs: name the guard that covers every cache table
The bullet added with the credit work names `TestTheCatalogSurvivesAStaleShape`, which pins the table and shape that failed. The general guard landed the same day and is the one that covers a table nobody remembered -- flipping the policy back fails it on five, including both artist-credit tables.
This commit is contained in:
@@ -271,6 +271,11 @@ rather than renaming them.
|
|||||||
the ~205 GB dump stream the `/cache` volume exists to avoid — so
|
the ~205 GB dump stream the `/cache` volume exists to avoid — so
|
||||||
`retireStaleCache` is false there (`staleshape_policy_indexbuild.go`)
|
`retireStaleCache` is false there (`staleshape_policy_indexbuild.go`)
|
||||||
and `TestTheCatalogSurvivesAStaleShape` fails the moment it is not.
|
and `TestTheCatalogSurvivesAStaleShape` fails the moment it is not.
|
||||||
|
`TestNoCacheTableIsRetiredHere` is the same assertion made of *every*
|
||||||
|
`datamap` Cache table rather than one, because the risk is not that
|
||||||
|
shape recurring — it is the next destructive repair added to
|
||||||
|
`database.NewDB`, the chokepoint every binary here shares, without
|
||||||
|
asking which binary it is in.
|
||||||
This is written down because it already happened: the repair shipped
|
This is written down because it already happened: the repair shipped
|
||||||
without the distinction and dropped the real CI catalog on its first
|
without the distinction and dropped the real CI catalog on its first
|
||||||
run, with `reason="column entity_type is TEXT, schema declares
|
run, with `reason="column entity_type is TEXT, schema declares
|
||||||
|
|||||||
Reference in New Issue
Block a user