From 52cbef27c452742c6da1e97fea02d6489f45208e Mon Sep 17 00:00:00 2001 From: Logan Date: Mon, 17 Aug 2026 14:01:28 -0400 Subject: [PATCH] docs: name the guard that covers every cache table The bullet added with the credit work names `TestTheCatalogSurvivesAStaleShape`, which pins the table and shape that failed. The general guard landed the same day and is the one that covers a table nobody remembered -- flipping the policy back fails it on five, including both artist-credit tables. --- CLAUDE.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CLAUDE.md b/CLAUDE.md index bd8865b..1c3fca4 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -271,6 +271,11 @@ rather than renaming them. the ~205 GB dump stream the `/cache` volume exists to avoid — so `retireStaleCache` is false there (`staleshape_policy_indexbuild.go`) and `TestTheCatalogSurvivesAStaleShape` fails the moment it is not. + `TestNoCacheTableIsRetiredHere` is the same assertion made of *every* + `datamap` Cache table rather than one, because the risk is not that + shape recurring — it is the next destructive repair added to + `database.NewDB`, the chokepoint every binary here shares, without + asking which binary it is in. This is written down because it already happened: the repair shipped without the distinction and dropped the real CI catalog on its first run, with `reason="column entity_type is TEXT, schema declares