• Joined on 2025-02-03
logan commented on issue yonlu/yellowjacket#146 2026-08-30 11:55:19 +00:00
Flaky: TestYtDlpSearchSkipsUnparseableLines failed once in a full make test run

PR: yonlu/yellowjacket#235 — CI green (run 18482, check and e2e both success).

The fix is syscall.ForkLock held across the write in stubYtDlp, which is on the…

logan commented on pull request yonlu/yellowjacket#235 2026-08-30 11:55:19 +00:00
test(download): write the yt-dlp stub under ForkLock

CI is green. Run 18482: check success, e2e success (chromium and WebKit both ran).

Not merging — leaving it for a human, with Status/In Progress still on #146.

logan created pull request yonlu/yellowjacket#235 2026-08-30 11:41:19 +00:00
test(download): write the yt-dlp stub under ForkLock
logan pushed to fix/146-stub-etxtbsy at yonlu/yellowjacket 2026-08-30 11:41:03 +00:00
49445ded77 test(download): write the yt-dlp stub under ForkLock
logan created branch fix/146-stub-etxtbsy in yonlu/yellowjacket 2026-08-30 11:41:03 +00:00
logan commented on issue yonlu/yellowjacket#146 2026-08-30 11:36:53 +00:00
Flaky: TestYtDlpSearchSkipsUnparseableLines failed once in a full make test run

Picking this up on fix/146-stub-etxtbsy.

The mechanism reproduces on demand, which is what makes it takeable rather than a blind chase. A standalone harness — 12 goroutines, each writing…

logan commented on issue yonlu/yellowjacket#175 2026-08-30 10:55:57 +00:00
The first-run wizard does not dismiss when a library appears by another route

PR: yonlu/yellowjacket#234 (fix/175-wizard-follows-the-library)

One subscription: the wizard dismisses on LibraryAdded rather than at the end of its own flow,…

logan commented on pull request yonlu/yellowjacket#234 2026-08-30 10:55:57 +00:00
fix(shell): dismiss the wizard when a library exists

CI green on b9e60bd — run 601, both required jobs.

  • check (job 29915): commit messages, lint, test, frontend typecheck, CSS literals, the component and store suite, bindings,…
logan created pull request yonlu/yellowjacket#234 2026-08-30 10:41:15 +00:00
fix(shell): dismiss the wizard when a library exists
logan pushed to fix/175-wizard-follows-the-library at yonlu/yellowjacket 2026-08-30 10:40:56 +00:00
b9e60bdb0a fix(shell): dismiss the wizard when a library exists
logan created branch fix/175-wizard-follows-the-library in yonlu/yellowjacket 2026-08-30 10:40:56 +00:00
logan commented on issue yonlu/yellowjacket#175 2026-08-30 10:33:29 +00:00
The first-run wizard does not dismiss when a library appears by another route

Picking this up on fix/175-wizard-follows-the-library.

Taking it on the Direction's second half, which is settled regardless of how its first question is answered: *the dismissal should follow…

logan commented on issue yonlu/yellowjacket#231 2026-08-30 09:55:04 +00:00
An invalid setter argument poisons the in-memory config, so nothing saves until restart

Fixed in PR #233 (fix/231-setter-rollback) — CI green (run 18472: check ✔, e2e ✔ on both chromium and webkit). Not merged.

Scope, since the Findings left it open. The previous…

logan commented on pull request yonlu/yellowjacket#233 2026-08-30 09:55:03 +00:00
fix(config): put the old value back when a setter is rejected

CI green — run 18472, both required jobs.

  • check success: commit messages, make lint, make test, frontend typecheck, CSS literals, make ui-test, make bindings-check, `make…
logan created pull request yonlu/yellowjacket#233 2026-08-30 09:41:41 +00:00
fix(config): put the old value back when a setter is rejected
logan pushed to fix/231-setter-rollback at yonlu/yellowjacket 2026-08-30 09:41:15 +00:00
bcf3856b6f fix(config): put the old value back when a setter is rejected
logan created branch fix/231-setter-rollback in yonlu/yellowjacket 2026-08-30 09:41:15 +00:00
logan commented on issue yonlu/yellowjacket#231 2026-08-30 09:33:17 +00:00
An invalid setter argument poisons the in-memory config, so nothing saves until restart

Picking this up on fix/231-setter-rollback.

Approach: restore the previous value when the setter's own validation rejects it, rather than the larger "validate a candidate copy" refactor.…

logan commented on pull request yonlu/yellowjacket#232 2026-08-30 09:02:08 +00:00
fix(settings): stop offering a column the backend rejects

CI is green on both jobs, first attempt.

  • check — run 22713, success (make lint, make test x3 configurations, tsc --noEmit, make ui-test, make bindings-check, make skill-check,…
logan commented on issue yonlu/yellowjacket#197 2026-08-30 09:02:08 +00:00
Settings lists two columns both called "Track Name", and one of them may be unselectable

PR: yonlu/yellowjacket#232 — CI green on both jobs (check 22713, e2e 22715), first attempt.

The configurator now lists CONFIGURABLE_COLUMN_IDS rather than `Objec…