logan
5ca6cad45a
A coding agent could develop this repo's Go packages and could not develop the application: every path to running YellowJacket ended in a blocking GTK window, so 265 bound methods, 46 events, 33 component directories and 13 stores had exactly one form of verification available — `tsc --noEmit`. The unlock is that `wails dev`'s dev server on :34115 serves the real frontend with the real generated bindings against the same Go backend a desktop window attaches to, so a plain Chromium under Xvfb gets a fully functional app. Four test tiers now exist, cheapest first: - `make ui-test` — 313 Vitest tests in a real browser in ~2 s, no app, no backend, no display. Works because `frontend/wailsjs/` is a pure passthrough to `window.go`/`window.runtime`, so faking just those two globals runs the real bindings and the real store code. - `make test` — services in-process, asserting on the payload the frontend would receive, via a new `events.Emit` wrapper. - `make dev-headless` + `playwright-cli` — the real app, driven interactively, with an event bridge on `window.__yjEvents` and a dev-only control surface at `/__test/`. - `make e2e` — 19 of those flows frozen as Playwright specs. `events.Emit(ctx, …)` replaces all 35 direct `runtime.EventsEmit` call sites: wails' `getEvents` `log.Fatalf`s on any context without its runtime, so those paths could not run under test and a background worker could take the app down. Four packages had each hand-rolled the same guard; nine more guarded on `ctx != nil`, which does not help. `TestNoDirectRuntimeEmits` fails the build on a new one. Fixtures are generated, not committed (`make testdata`), and seeds are built by *running the app* — never by hand-writing config and DB rows, which would be a second description of a valid YJ_HOME. `.gitea/workflows/ci.yml` is the first workflow here that tests anything; the other three only package, so `gitea_ci` reported only packaging jobs and misled anyone asking whether a push was healthy. Both jobs were prototyped to green in a bare ubuntu:24.04 container before the YAML was written, which immediately caught `make lint` linting three configurations that nothing builds: all three passes omitted `webkit2_41`, so wails resolved webkit2gtk-4.0 — which Arch still ships and Ubuntu 24.04 dropped. Operational instructions live in `.pi/skills/yellowjacket-dev/`, measured discoveries in `.planning/NOTES.md`, and architecture in `CLAUDE.md` — split by tense, not by topic, because a topical split gives every new fact two plausible homes. `make skill-check` fails a commit if the skill cites a make target that does not exist.
49 lines
1.7 KiB
Bash
Executable File
49 lines
1.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Every command in .pi/ is a `make` target on purpose: the Makefile is
|
|
# the source of truth for *how* to invoke something, and the skill only
|
|
# decides *which* and *in what order*. This check keeps that honest —
|
|
# a renamed or deleted target turns into a failing commit rather than
|
|
# into an agent confidently running a command that no longer exists.
|
|
#
|
|
# It extracts every `make <target>` mentioned under .pi/ and asserts the
|
|
# target exists. Usage: scripts/skill-check.sh
|
|
set -euo pipefail
|
|
|
|
cd "$(dirname "$0")/.."
|
|
|
|
[ -d .pi ] || exit 0
|
|
|
|
# `make -pq` prints the database including every rule, without running
|
|
# anything. It exits non-zero when a target is out of date, and under
|
|
# `pipefail` that would sink the whole assignment, so swallow it.
|
|
targets="$({ make -pqRr 2>/dev/null || true; } |
|
|
awk '/^[a-zA-Z0-9][^$#\/\t=]*:([^=]|$)/ {sub(/:.*/, "", $0); print}' |
|
|
sort -u)"
|
|
|
|
# A mention counts only when it is code: backticked (`make ui-test`) or
|
|
# the first thing on a line, as in a fenced block. Bare prose is not
|
|
# scanned, because English says things like "a renamed make target".
|
|
mentioned="$(grep -rhoE '(`|^)make [a-z][a-z0-9-]*' .pi --include='*.md' |
|
|
sed 's/^`//' | awk '{print $2}' | sort -u)"
|
|
|
|
missing=""
|
|
|
|
for t in $mentioned; do
|
|
if ! printf '%s\n' "$targets" | grep -qx -- "$t"; then
|
|
missing="$missing $t"
|
|
fi
|
|
done
|
|
|
|
if [ -n "$missing" ]; then
|
|
echo "skill-check: .pi/ documents make targets that do not exist:" >&2
|
|
for t in $missing; do
|
|
echo " make $t" >&2
|
|
grep -rln "make $t" .pi --include='*.md' | sed 's/^/ /' >&2
|
|
done
|
|
echo "Fix the docs, or restore the target." >&2
|
|
exit 1
|
|
fi
|
|
|
|
echo "skill-check: $(printf '%s\n' "$mentioned" | wc -w) documented make targets, all present"
|