yonluandClaude Opus 5
4471db3aef
Phases 2 and 3 of plan 009, plus the parts of phase 1 that could not
land before them. Nothing in the tree imports wails/v2 any more; all
three lint and test configurations are green and `go build .` produces
a running binary.
The point of the migration is one file. backend/events/emit.go probed
ctx.Value("events") — a v2-*private* context key — to decide whether
emitting was safe, because runtime.EventsEmit called log.Fatalf on a
context without the runtime and took the process down with it. v3's
emit takes no context, so that is now application.Get() == nil. D1
held: events.Emit keeps its ctx as the WithSink test seam, and all 45
call sites and 7 test files are untouched.
The bootstrap splits into application.New + Window.NewWithOptions +
Run. Ten bound services implement ServiceStartup instead of being
handed a context by hand from OnStartup, which also stops ten
SetContext methods being exported as bindings. jobs.Registry and
explore.SearchIndex keep theirs — neither is bound, so converting them
would be churn for no binding removed.
Four things differed from the plan and are written up in it: GPU policy
moved to the per-window LinuxWindow options rather than surviving on
LinuxOptions; there is no OnStartup/OnDomReady option, so app-level
wiring hangs off ApplicationStarted; application.NewService is generic,
so FEBindings []any could not survive (the binding generator is a
static analyser and would have seen nothing); and the quit veto had to
be restructured, because v3's dialog answers on a callback rather than
returning the button, so ShouldQuit vetoes, asks, and quits again from
the callback.
Window state saving moves to a WindowClosing hook — the size has to be
read while the window still exists, and v3's OnShutdown has neither
context nor window. backend/logging is deleted rather than ported:
v3 takes a *slog.Logger directly, so the v2 logger.Logger adapter had
no caller left.
Phase 1's tail rides along, now that it can: the Makefile's wails
invocations, all 50 webkit2_41 sites, lefthook, both packaging recipes
and ci.yml's apt lists. v3 builds against GTK4 + WebKitGTK 6.0, which
Arch and ubuntu:24.04 both ship, so the tag is a deletion rather than
a translation.
Phase 4 is next and the branch is not usable until it lands: the app
builds, but frontend/wailsjs/ is v2's tree and nothing regenerates it,
so the frontend cannot reach the backend yet.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDCbcCZQepnpSQYJ6SxxZm
60 lines
1.6 KiB
Go
60 lines
1.6 KiB
Go
package player
|
|
|
|
import (
|
|
"log/slog"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/wailsapp/wails/v3/pkg/application"
|
|
|
|
"yellowjacket/internal/testfixtures"
|
|
)
|
|
|
|
func TestPlayer(t *testing.T) {
|
|
// This is an integration test that requires:
|
|
// 1. A Wails runtime context (SetContext restores persisted state)
|
|
// 2. An audio output device (InitSpeaker)
|
|
//
|
|
// Skip unless the caller explicitly opts in via YELLOWJACKET_INTEGRATION=1.
|
|
if os.Getenv("YELLOWJACKET_INTEGRATION") == "" {
|
|
t.Skip(
|
|
"skipping: integration test requires Wails runtime and audio device (set YELLOWJACKET_INTEGRATION=1 to run)",
|
|
)
|
|
}
|
|
|
|
// One track per supported container, so a decoder regression in
|
|
// any of the four shows up here rather than only in whichever
|
|
// format the fixtures happened to lead with.
|
|
m := testfixtures.Load(t)
|
|
testQueue := []string{
|
|
m.Case(t, testfixtures.CaseCoverDedup)[0],
|
|
m.Case(t, testfixtures.CaseFLACAlbum)[0],
|
|
m.Case(t, testfixtures.CaseOGGAlbum)[0],
|
|
m.Case(t, testfixtures.CaseWAVTracks)[0],
|
|
}
|
|
|
|
t.Logf("Starting test")
|
|
|
|
p := NewPlayer(slog.Default(), nil)
|
|
|
|
if err := p.InitSpeaker(); err != nil {
|
|
t.Fatalf("could not initialize speaker: %s", err.Error())
|
|
}
|
|
|
|
// SetContext restores persisted state; only works with a real Wails context.
|
|
_ = p.ServiceStartup(t.Context(), application.ServiceOptions{})
|
|
t.Logf("initializing player")
|
|
|
|
for _, track := range testQueue {
|
|
t.Logf("loading file: %s", track)
|
|
|
|
if err := p.LoadFile(track); err != nil {
|
|
t.Fatalf("could not load file %s: %s", track, err.Error())
|
|
}
|
|
|
|
if err := p.Play(); err != nil {
|
|
t.Fatalf("could not play file %s: %s", track, err.Error())
|
|
}
|
|
}
|
|
}
|