Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
248 lines
6.2 KiB
Go
248 lines
6.2 KiB
Go
package library
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"fmt"
|
|
"image"
|
|
"image/jpeg"
|
|
_ "image/png" // Register PNG decoder.
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"golang.org/x/image/draw"
|
|
|
|
"yellowjacket/backend/coverart"
|
|
"yellowjacket/backend/metadata"
|
|
)
|
|
|
|
// thumbnailTier defines a single size tier for generated cover art thumbnails.
|
|
type thumbnailTier struct {
|
|
// Suffix appended to the content hash (e.g. "_sm", "_md", "_lg").
|
|
Suffix string
|
|
// MaxSize is the maximum width or height in pixels.
|
|
MaxSize int
|
|
// Quality is the JPEG encoding quality (1-100).
|
|
Quality int
|
|
}
|
|
|
|
// thumbnailWork is a unit of work for the async thumbnail worker pool.
|
|
type thumbnailWork struct {
|
|
imgData []byte
|
|
dir string
|
|
hashStr string
|
|
metrics *ScanMetrics
|
|
}
|
|
|
|
// thumbnailTiers lists all generated size variants, ordered smallest to largest.
|
|
var thumbnailTiers = []thumbnailTier{
|
|
{Suffix: "_sm", MaxSize: 100, Quality: 75},
|
|
{Suffix: "_md", MaxSize: 200, Quality: 80},
|
|
{Suffix: "_lg", MaxSize: 400, Quality: 85},
|
|
}
|
|
|
|
// largestTier is the tier stored as the cover's canonical file.
|
|
func largestTier() thumbnailTier {
|
|
return thumbnailTiers[len(thumbnailTiers)-1]
|
|
}
|
|
|
|
// CoverArtFileSet returns every file on disk belonging to one cover art
|
|
// entry: each generated size variant.
|
|
//
|
|
// Only one of them is recorded in cover_art.file_path — the others are
|
|
// derived filenames — so any code deleting cover art has to expand the
|
|
// set or the rest are orphaned.
|
|
func CoverArtFileSet(coverPath string) []string {
|
|
dir := filepath.Dir(coverPath)
|
|
base := filepath.Base(coverPath)
|
|
|
|
paths := make([]string, 0, len(thumbnailTiers))
|
|
|
|
for _, tier := range thumbnailTiers {
|
|
paths = append(paths, filepath.Join(
|
|
dir, coverart.SizedFilename(base, tier.Suffix),
|
|
))
|
|
}
|
|
|
|
return paths
|
|
}
|
|
|
|
// saveCoverArt saves embedded cover art to the cache directory.
|
|
// Returns the file path where the art was saved, or empty string
|
|
// if no picture data. Timing is recorded in the provided metrics.
|
|
// When thumbChan is non-nil, thumbnail generation is dispatched
|
|
// asynchronously to a worker pool instead of running inline.
|
|
func (l *Library) saveCoverArt(
|
|
pic *metadata.PictureData,
|
|
metrics *ScanMetrics,
|
|
thumbChan chan<- thumbnailWork,
|
|
) (string, error) {
|
|
if pic == nil || len(pic.Data) == 0 {
|
|
return "", nil
|
|
}
|
|
|
|
saveStart := time.Now()
|
|
|
|
// Get the covers directory for storing cover art.
|
|
coverDir, err := coverart.CoversDir()
|
|
if err != nil {
|
|
return "", fmt.Errorf(
|
|
"could not resolve covers directory: %w", err,
|
|
)
|
|
}
|
|
|
|
// Ensure directory exists.
|
|
if err := os.MkdirAll(coverDir, 0o755); err != nil {
|
|
return "", fmt.Errorf(
|
|
"could not create covers directory: %w", err,
|
|
)
|
|
}
|
|
|
|
// The content hash identifies the cover and dedupes it; the largest
|
|
// tier is what gets stored under that name.
|
|
//
|
|
// The full-resolution image used to be written here too, and it was
|
|
// 1,134 MB of a 1.4 GB covers directory on a real library - against
|
|
// 110 MB for all three tiers together - with nothing rendering it.
|
|
// The bytes are still in the audio file if a bigger one is ever
|
|
// needed, which is where these came from.
|
|
hash := sha256.Sum256(pic.Data)
|
|
hashStr := hex.EncodeToString(hash[:8]) // First 8 bytes = 16 hex chars.
|
|
|
|
filePath := filepath.Join(
|
|
coverDir, coverart.SizedFilename(hashStr, largestTier().Suffix),
|
|
)
|
|
|
|
// Skip if this cover has already been stored (same content hash).
|
|
if _, err := os.Stat(filePath); err == nil {
|
|
l.logger.Debug("cover art already stored", "path", filePath)
|
|
|
|
return filePath, nil
|
|
}
|
|
|
|
// Dispatch thumbnail generation to the async worker pool if
|
|
// available, otherwise generate inline.
|
|
if thumbChan != nil {
|
|
thumbChan <- thumbnailWork{
|
|
imgData: pic.Data,
|
|
dir: coverDir,
|
|
hashStr: hashStr,
|
|
metrics: metrics,
|
|
}
|
|
} else if err := l.generateSizedVariantsWithMetrics(
|
|
pic.Data, coverDir, hashStr, metrics,
|
|
); err != nil {
|
|
l.logger.Warn("could not generate sized variants",
|
|
"path", filePath, "err", err)
|
|
}
|
|
|
|
metrics.addCoverArtSave(time.Since(saveStart))
|
|
|
|
return filePath, nil
|
|
}
|
|
|
|
// generateSizedVariantsWithMetrics is like generateSizedVariants
|
|
// but records per-tier timing in the provided metrics.
|
|
func (l *Library) generateSizedVariantsWithMetrics(
|
|
imgData []byte,
|
|
dir, hashStr string,
|
|
metrics *ScanMetrics,
|
|
) error {
|
|
src, _, err := image.Decode(bytes.NewReader(imgData))
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"could not decode image for thumbnails: %w", err,
|
|
)
|
|
}
|
|
|
|
bounds := src.Bounds()
|
|
srcW := bounds.Dx()
|
|
srcH := bounds.Dy()
|
|
|
|
for _, tier := range thumbnailTiers {
|
|
tierStart := time.Now()
|
|
|
|
tierPath := filepath.Join(
|
|
dir,
|
|
fmt.Sprintf("%s%s.jpg", hashStr, tier.Suffix),
|
|
)
|
|
|
|
w, h := fitDimensions(srcW, srcH, tier.MaxSize)
|
|
|
|
if err := encodeAndSaveImage(
|
|
src, tierPath, w, h, tier.Quality,
|
|
); err != nil {
|
|
l.logger.Warn(
|
|
"could not generate sized variant",
|
|
"tier", tier.Suffix,
|
|
"path", tierPath,
|
|
"err", err,
|
|
)
|
|
|
|
continue
|
|
}
|
|
|
|
metrics.addThumbnailTier(
|
|
tier.Suffix, time.Since(tierStart),
|
|
)
|
|
|
|
l.logger.Debug(
|
|
"saved sized variant",
|
|
"tier", tier.Suffix,
|
|
"path", tierPath,
|
|
"dimensions", fmt.Sprintf("%dx%d", w, h),
|
|
)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// fitDimensions calculates the output dimensions that fit within maxSize
|
|
// while preserving the aspect ratio. If the source is already smaller
|
|
// than maxSize, the original dimensions are returned unchanged.
|
|
func fitDimensions(srcW, srcH, maxSize int) (int, int) {
|
|
if srcW <= maxSize && srcH <= maxSize {
|
|
return srcW, srcH
|
|
}
|
|
|
|
w, h := maxSize, maxSize
|
|
if srcW > srcH {
|
|
h = srcH * maxSize / srcW
|
|
} else {
|
|
w = srcW * maxSize / srcH
|
|
}
|
|
|
|
return w, h
|
|
}
|
|
|
|
// encodeAndSaveImage scales the source image to the given dimensions
|
|
// and saves it as a JPEG with the specified quality.
|
|
func encodeAndSaveImage(
|
|
src image.Image,
|
|
path string,
|
|
w, h, quality int,
|
|
) error {
|
|
dst := image.NewRGBA(image.Rect(0, 0, w, h))
|
|
draw.ApproxBiLinear.Scale(
|
|
dst, dst.Bounds(), src, src.Bounds(), draw.Over, nil,
|
|
)
|
|
|
|
var buf bytes.Buffer
|
|
|
|
if err := jpeg.Encode(
|
|
&buf, dst, &jpeg.Options{Quality: quality},
|
|
); err != nil {
|
|
return fmt.Errorf("could not encode image: %w", err)
|
|
}
|
|
|
|
if err := os.WriteFile(
|
|
path, buf.Bytes(), 0o644,
|
|
); err != nil {
|
|
return fmt.Errorf("could not write image: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|