Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
129 lines
4.4 KiB
TypeScript
129 lines
4.4 KiB
TypeScript
import {
|
|
test,
|
|
expect,
|
|
callBinding,
|
|
NO_QUEUE_SOURCE,
|
|
} from '../support/fixtures.js';
|
|
import type { Page } from '@playwright/test';
|
|
|
|
/**
|
|
* `a11y.11` — the queue's order can be changed without a mouse.
|
|
*
|
|
* The component tier pins the arithmetic against a faked binding. This
|
|
* one is here because the arithmetic is only half of it: `toIndex` is
|
|
* interpreted by `Queue.MoveQueueTracks`, whose contiguous-block guard
|
|
* turns the plausible-looking `i + 1` into a silent no-op. Nothing but
|
|
* the real backend can say whether the order actually moved.
|
|
*
|
|
* Reproduced first: with a row focused, Alt/Ctrl/Shift/Meta + arrows all
|
|
* left the order untouched.
|
|
*/
|
|
|
|
/** The queue's order, asked of the backend rather than of the DOM. */
|
|
async function order(app: Page): Promise<string[]> {
|
|
const state = await callBinding<{ tracks: { title: string }[] }>(
|
|
app,
|
|
'queue.Queue.GetState',
|
|
);
|
|
|
|
return state.tracks.map((t) => t.title);
|
|
}
|
|
|
|
async function queueFourAndOpen(app: Page): Promise<string[]> {
|
|
const paths: string[] = await app.evaluate(async () => {
|
|
// One argument, and 0 means every library: the scoped and
|
|
// unscoped list queries collapsed into one when the schema did
|
|
// (plan 013 R3), so `GetTracks()` no longer exists to call.
|
|
const tracks = await window.__yjEvents.call(
|
|
'library.Library.GetTracks',
|
|
[0],
|
|
10_000,
|
|
);
|
|
|
|
return (tracks as { FilePath: string }[]).slice(0, 4).map((t) => t.FilePath);
|
|
});
|
|
|
|
await callBinding(app, 'queue.Queue.SetQueue', [paths, 0, false, NO_QUEUE_SOURCE]);
|
|
|
|
// A closed panel renders no list at all, so there is no row to focus.
|
|
await app.locator('#queue-button').click();
|
|
await expect(app.locator('queue-panel .track-item').first()).toBeVisible();
|
|
|
|
return order(app);
|
|
}
|
|
|
|
test.describe('reordering the queue from the keyboard', () => {
|
|
// The 36 specs share one backend process in file order, and these
|
|
// leave two things behind that outlive the page: a reordered queue
|
|
// and an open panel. Both are put back, because a spec that spends
|
|
// state fails the *next* one, in a list that reads like a regression
|
|
// in whatever you are holding.
|
|
test.afterEach(async ({ app }) => {
|
|
await callBinding(app, 'queue.Queue.Clear').catch(() => {
|
|
/* nothing queued is the state we wanted anyway */
|
|
});
|
|
|
|
const open = await app.locator('queue-panel[open]').count();
|
|
|
|
if (open > 0) await app.locator('#queue-button').click();
|
|
});
|
|
|
|
test('Alt+Arrow moves the focused row, and puts it back', async ({ app }) => {
|
|
const start = await queueFourAndOpen(app);
|
|
|
|
expect(start.length).toBe(4);
|
|
|
|
await app.locator('queue-panel .track-item').nth(1).focus();
|
|
await app.keyboard.press('Alt+ArrowUp');
|
|
await expect.poll(() => order(app)).toEqual([start[1], start[0], ...start.slice(2)]);
|
|
|
|
// Down is the direction the obvious index arithmetic gets wrong: it
|
|
// has to ask for i + 2, because i + 1 is a no-op once the row's own
|
|
// removal is accounted for. A spec that only moved up would pass
|
|
// against a build where down does nothing.
|
|
await app.keyboard.press('Alt+ArrowDown');
|
|
await expect.poll(() => order(app)).toEqual(start);
|
|
});
|
|
|
|
test('says where the row went', async ({ app }) => {
|
|
await queueFourAndOpen(app);
|
|
|
|
await app.locator('queue-panel .track-item').nth(1).focus();
|
|
await app.keyboard.press('Alt+ArrowUp');
|
|
|
|
await expect(
|
|
app.locator('queue-panel [role="status"]'),
|
|
).toHaveText(/Moved to position 1 of 4/);
|
|
});
|
|
|
|
test('refuses at the ends without reordering anything', async ({ app }) => {
|
|
const start = await queueFourAndOpen(app);
|
|
|
|
await app.locator('queue-panel .track-item').first().focus();
|
|
await app.keyboard.press('Alt+ArrowUp');
|
|
|
|
await expect(
|
|
app.locator('queue-panel [role="status"]'),
|
|
).toHaveText(/Already first/);
|
|
expect(await order(app)).toEqual(start);
|
|
});
|
|
|
|
// The plain arrows belong to the roving tab stop, and must not reach
|
|
// the global volume binding from a focused row.
|
|
test('leaves the unmodified arrows roving', async ({ app }) => {
|
|
const start = await queueFourAndOpen(app);
|
|
|
|
await app.locator('queue-panel .track-item').first().focus();
|
|
await app.keyboard.press('ArrowDown');
|
|
|
|
const focused = await app.evaluate(
|
|
() =>
|
|
document
|
|
.querySelector('queue-panel')
|
|
?.shadowRoot?.activeElement?.getAttribute('data-index') ?? null,
|
|
);
|
|
|
|
expect([focused, await order(app)]).toEqual(['1', start]);
|
|
});
|
|
});
|