Files
yellowjacket/e2e/specs/reduced-motion.spec.ts
T
yonluandClaude Opus 5 e7748f1fd5
CI / check (push) Successful in 3m7s
CI / e2e (push) Canceled after 1m45s
feat(database): shape the library like files, and shrink the catalog
Plans 013 and 014, the album page that prompted them, and the smaller
fixes they turned up. Changelog, largest first.

## The local library is shaped like files, not like MusicBrainz

`audio_files` carries its own tags and points at `albums` and
`artists`; `file_genres` is the one real many-to-many. `recordings`,
`release_group_recordings`, `artist_credit`, `artist_credit_artist`,
`recording_genres`, `release_groups` and `release_to_rg` are gone from
the local side, and with them a six-way join in every read, a
`MIN(release_group_id)` subquery in eleven queries and a
first-credited-artist subquery in nine. Measured on a real 25,966-file
library, every many-to-many that model expressed was 1:1 in the data.

- Ownership is a file. `GetFilePathsByRecordingMBIDs`,
  `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and
  `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812
  orphaned recordings, 216 release groups and 260 artists that library
  carried are now structurally impossible.
- One projection: every track query selects from the `track_metadata`
  view, one row type, one mapper. Nine hand-rolled copies had drifted
  far enough to report different years on different screens.
- `library_id = 0` means every library, so each list query exists once
  instead of scoped and unscoped with a branch at every call site.
- No migration chain. `sql/schemas/` is the one description of the
  shape; `sql/migrations/`, `applyMigrations` and `schema_migrations`
  are squashed away, along with the drift between them that had sqlc
  generating against a stale schema.
- `database.InsertTestTrack` is the one test seeder; twenty test files
  had been assembling the old FK chain each in its own order.

## The catalog stores its ids as bytes

`explore_index`'s three 36-char MBID columns and its entity-type text
are 16 raw bytes and a small integer. The table and its six indexes go
780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh
install is ~0.6 GB rather than ~1.0 GB.

- `backend/explore/mbid.go` is the only place the encoding is known;
  everything above it speaks dashed strings.
- `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert
  rather than silently returning no rows, since SQLite does not coerce
  between TEXT and BLOB.
- The importer asks the artifact what encoding it carries and converts
  on the way in, so the artifact already published keeps working and no
  format bump is needed.
- `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column
  list, and `TestStoredEncodingRoundTrips` sweeps every read path.

## An album page that says how much of the album is yours

- One question, asked once: is there a file. `filePaths` is filled by a
  single batched lookup when the tracklist settles, and the badge, the
  Play count, the dimmed rows and every menu item read it — replacing
  four claims of decreasing confidence that could show a green tick on
  an album whose every action did nothing.
- Play, Play 7 of 12, or no play button at all.
- `total_tracks` on `explore_index` (~2 bytes over 400,677 release
  groups) and on `audio_files` from tags that have always carried it:
  a complete MBID-matched album now makes no catalog call at all, where
  it used to spend the most expensive request the app makes.
- A merged cluster shows the running order the most releases agree on,
  and the version list marks the release you own rather than standing a
  synthetic entry in for it.
- `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed
  one by a 12-second timer.
- Rows not in the library are dimmed in place (with `aria-disabled`)
  instead of the owned ones wearing a green tick and a legend.

## Caches and cover art get ceilings

- Only the three tiers of a cover are stored; the full-resolution copy
  nothing rendered was 1,134 MB of a 1.4 GB covers directory.
- One artist portrait is downloaded and the rest are remembered as
  URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads.
- `browsedArtBudget` and `httpCacheBudget` bound what an age cannot:
  the same install held art for 5,770 artists in a 1,301-artist
  library.
- `OrphanedArtistImagesJob` joined a bare MBID onto a sharded
  directory, so it deleted the rows that were the only record of the
  files it left behind. `explore.ArtistImageDir` is that layout's one
  definition now.

## The autotag queue asks whether there is work

`tagging_items` was a row per album folder, not a queue, and no query
read the `tag_status` column that held the answer. The four queue
queries ask the files, which matters most where it is least visible:
`startPrefetch` was scoring every album in a tagged library against
MusicBrainz.

## Phantom playlist tracks resolve in place

An M3U8 imported before its files leaves phantom rows; they now match
by path and fall back to position, keep their place in the playlist
when resolved, and pair best-first so two phantoms cannot claim the
same file.

## Playing a track plays the list it is in

Double-click, and Play on a single row's menu, queue the list as
displayed with `startIndex` on that row — the album page and the track
list used to queue one track and discard the album around it. A
multi-row selection still plays exactly itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
2026-08-16 13:58:15 -04:00

114 lines
4.1 KiB
TypeScript

import {
test,
expect,
callBinding,
waitForEvent,
NO_QUEUE_SOURCE,
} from '../support/fixtures.js';
import type { Page } from '@playwright/test';
/**
* `a11y.15` — WCAG 2.2.2. The bottom bar's title and artist scroll
* continuously while a track plays, re-armed in a loop by
* `transitionend`, with no pause mechanism and no reduced-motion guard.
*
* The component test for this fakes `window.matchMedia`, which is a
* stub of the thing being tested. This spec sets the real context
* option, so the real media query answers.
*
* Both directions are here on purpose. A guard that suppressed
* everything would pass the reduce case for free, and so would a bar
* whose text simply does not overflow at this viewport — which is what
* the component test failed on first.
*/
/** The fixture track whose title is long enough to overflow the bar. */
const LONG_TITLE = 'An Exhaustively Overlong Track Title';
/**
* Read the title line's classes from inside `now-playing`'s shadow root.
*
* `will-scroll` is the class that carries both the transition and the
* `padding-right` the scroll distance is measured against, so its
* absence is the whole fix: suppressing only the animation leaves the
* text translated off its own box with nothing to bring it back.
*/
async function titleClasses(app: Page): Promise<string> {
return app.evaluate(() => {
const np = document.querySelector('now-playing');
const title = np?.shadowRoot?.querySelector('.track-title');
return title?.className ?? '';
});
}
async function playTheLongOne(app: Page): Promise<void> {
await app.getByTestId('nav-tracks').click();
// The scroll mode defaults to `hover`, and a fresh context has no
// persisted setting — so without this the positive case never
// scrolls and reports the same thing a broken build would. Set it
// rather than hovering, because `always` is also the mode the
// finding is about: continuous motion for as long as the track
// plays, with nothing the user has to do to provoke it.
await app.evaluate(() => {
localStorage.setItem('yj-now-playing-scroll-mode', 'always');
window.dispatchEvent(new CustomEvent('yj-scroll-mode-changed'));
});
const paths: string[] = await app.evaluate(async (needle) => {
// One argument, and 0 means every library: the scoped and
// unscoped list queries collapsed into one when the schema did
// (plan 013 R3), so `GetTracks()` no longer exists to call.
const tracks = await window.__yjEvents.call(
'library.Library.GetTracks',
[0],
10_000,
);
return (tracks as { TrackName: string; FilePath: string }[])
.filter((t) => t.TrackName.startsWith(needle))
.map((t) => t.FilePath);
}, LONG_TITLE);
expect(paths.length).toBeGreaterThan(0);
await callBinding(app, 'queue.Queue.SetQueue', [paths, 0, false, NO_QUEUE_SOURCE]);
await waitForEvent(app, 'TrackChanged');
// The scroll cycle is armed 1500 ms after the geometry is measured,
// and the geometry is measured after the render that puts the title
// on screen. Reading before that reports "not scrolling" on a build
// that scrolls — the same shape as every probe read too early in
// plan 007.
await expect
.poll(() => titleClasses(app), { timeout: 10_000 })
.toContain('track-title');
}
test.describe('the marquee under prefers-reduced-motion', () => {
test.use({ contextOptions: { reducedMotion: 'reduce' } });
test('does not scroll the now-playing text at all', async ({ app }) => {
await playTheLongOne(app);
// Give the cycle longer than the 1500 ms arming delay to prove it
// never arms, rather than catching it before it would have.
await app.waitForTimeout(2500);
expect(await titleClasses(app)).not.toContain('will-scroll');
});
});
test.describe('the marquee without a motion preference', () => {
test.use({ contextOptions: { reducedMotion: 'no-preference' } });
test('still scrolls an overflowing title', async ({ app }) => {
await playTheLongOne(app);
await expect
.poll(() => titleClasses(app), { timeout: 10_000 })
.toContain('will-scroll');
});
});