Files
yellowjacket/frontend/src/components/cover-grid/album-selection.ts
T
yonluandClaude Opus 5 e7748f1fd5
CI / check (push) Successful in 3m7s
CI / e2e (push) Canceled after 1m45s
feat(database): shape the library like files, and shrink the catalog
Plans 013 and 014, the album page that prompted them, and the smaller
fixes they turned up. Changelog, largest first.

## The local library is shaped like files, not like MusicBrainz

`audio_files` carries its own tags and points at `albums` and
`artists`; `file_genres` is the one real many-to-many. `recordings`,
`release_group_recordings`, `artist_credit`, `artist_credit_artist`,
`recording_genres`, `release_groups` and `release_to_rg` are gone from
the local side, and with them a six-way join in every read, a
`MIN(release_group_id)` subquery in eleven queries and a
first-credited-artist subquery in nine. Measured on a real 25,966-file
library, every many-to-many that model expressed was 1:1 in the data.

- Ownership is a file. `GetFilePathsByRecordingMBIDs`,
  `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and
  `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812
  orphaned recordings, 216 release groups and 260 artists that library
  carried are now structurally impossible.
- One projection: every track query selects from the `track_metadata`
  view, one row type, one mapper. Nine hand-rolled copies had drifted
  far enough to report different years on different screens.
- `library_id = 0` means every library, so each list query exists once
  instead of scoped and unscoped with a branch at every call site.
- No migration chain. `sql/schemas/` is the one description of the
  shape; `sql/migrations/`, `applyMigrations` and `schema_migrations`
  are squashed away, along with the drift between them that had sqlc
  generating against a stale schema.
- `database.InsertTestTrack` is the one test seeder; twenty test files
  had been assembling the old FK chain each in its own order.

## The catalog stores its ids as bytes

`explore_index`'s three 36-char MBID columns and its entity-type text
are 16 raw bytes and a small integer. The table and its six indexes go
780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh
install is ~0.6 GB rather than ~1.0 GB.

- `backend/explore/mbid.go` is the only place the encoding is known;
  everything above it speaks dashed strings.
- `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert
  rather than silently returning no rows, since SQLite does not coerce
  between TEXT and BLOB.
- The importer asks the artifact what encoding it carries and converts
  on the way in, so the artifact already published keeps working and no
  format bump is needed.
- `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column
  list, and `TestStoredEncodingRoundTrips` sweeps every read path.

## An album page that says how much of the album is yours

- One question, asked once: is there a file. `filePaths` is filled by a
  single batched lookup when the tracklist settles, and the badge, the
  Play count, the dimmed rows and every menu item read it — replacing
  four claims of decreasing confidence that could show a green tick on
  an album whose every action did nothing.
- Play, Play 7 of 12, or no play button at all.
- `total_tracks` on `explore_index` (~2 bytes over 400,677 release
  groups) and on `audio_files` from tags that have always carried it:
  a complete MBID-matched album now makes no catalog call at all, where
  it used to spend the most expensive request the app makes.
- A merged cluster shows the running order the most releases agree on,
  and the version list marks the release you own rather than standing a
  synthetic entry in for it.
- `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed
  one by a 12-second timer.
- Rows not in the library are dimmed in place (with `aria-disabled`)
  instead of the owned ones wearing a green tick and a legend.

## Caches and cover art get ceilings

- Only the three tiers of a cover are stored; the full-resolution copy
  nothing rendered was 1,134 MB of a 1.4 GB covers directory.
- One artist portrait is downloaded and the rest are remembered as
  URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads.
- `browsedArtBudget` and `httpCacheBudget` bound what an age cannot:
  the same install held art for 5,770 artists in a 1,301-artist
  library.
- `OrphanedArtistImagesJob` joined a bare MBID onto a sharded
  directory, so it deleted the rows that were the only record of the
  files it left behind. `explore.ArtistImageDir` is that layout's one
  definition now.

## The autotag queue asks whether there is work

`tagging_items` was a row per album folder, not a queue, and no query
read the `tag_status` column that held the answer. The four queue
queries ask the files, which matters most where it is least visible:
`startPrefetch` was scoring every album in a tagged library against
MusicBrainz.

## Phantom playlist tracks resolve in place

An M3U8 imported before its files leaves phantom rows; they now match
by path and fall back to position, keep their place in the playlist
when resolved, and pair best-first so two phantoms cannot claim the
same file.

## Playing a track plays the list it is in

Double-click, and Play on a single row's menu, queue the list as
displayed with `startIndex` on that row — the album page and the track
list used to queue one track and discard the album around it. A
multi-row selection still plays exactly itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
2026-08-16 13:58:15 -04:00

406 lines
11 KiB
TypeScript

import {
GetAlbumTracks,
GetFilePathsByAlbums,
} from '@go/library/library.js';
import { libraryStore } from '@store/library-store';
import { dict, list } from '@utils/binding';
import type * as library from '@go/library/models.js';
import type { CoverArtUrls } from '@components/track-details/track-details.js';
/**
* Manages album and track selection, file-path resolution,
* and the drag-cache for the cover grid.
*
* This is a plain helper class (not a ReactiveController)
* because selection state is owned by the component's
* `@state()` properties — the manager only computes
* derived data (file paths, ranges, cache entries).
*/
export class AlbumSelectionManager {
/**
* Map from album ID to Album for O(1) lookups.
* Rebuilt via `setAlbums()` when the album list changes.
*/
private albumById = new Map<number, library.Album>();
/**
* Pre-resolved file paths for selected albums, keyed by album ID.
* Populated asynchronously when albums are selected so that
* dragstart can read them synchronously.
*/
private albumFilePathCache = new Map<
number,
string[]
>();
/**
* Update the album-by-ID index. Call this whenever
* the full album list changes (initial load, library
* rescan, external album prop change).
*
* Also clears the file-path cache since album IDs may
* have shifted after a rescan.
*/
setAlbums(albums: library.Album[]): void {
this.albumById = new Map(
albums.map((a) => [a.ID, a]),
);
this.albumFilePathCache.clear();
}
/**
* Fetch album tracks respecting the active
* library filter.
*/
private fetchAlbumTracks(
albumId: number,
): Promise<library.Track[]> {
const libId =
libraryStore.getSelectedLibraryId();
return list(GetAlbumTracks(albumId, libId ?? 0));
}
/**
* File paths for several albums in one call, keyed
* by album id.
*
* perf.m2: every caller below used to loop over the
* albums awaiting `GetAlbumTracks` per album, so
* Ctrl+A over 5 000 albums was 5 000 sequential
* round trips — each returning whole track rows to
* read one field off them.
*/
private async fetchAlbumPaths(
albumIds: Iterable<number>,
): Promise<Record<number, string[]>> {
const ids = Array.from(albumIds).filter((id) =>
this.albumById.has(id),
);
if (ids.length === 0) return {};
const libId =
libraryStore.getSelectedLibraryId();
return dict(GetFilePathsByAlbums(ids, libId ?? 0));
}
// ================================================================
// Album selection helpers
// ================================================================
/**
* Return the set of album IDs in the range
* [from, to] (inclusive, order-independent)
* within the filtered album list.
*/
selectAlbumRange(
from: number,
to: number,
filteredAlbums: library.Album[],
): Set<number> {
const start = Math.min(from, to);
const end = Math.max(from, to);
const ids = new Set<number>();
for (let i = start; i <= end; i++) {
const album = filteredAlbums[i];
if (album) {
ids.add(album.ID);
}
}
return ids;
}
/**
* Fetch file paths for all albums in the given
* selection set. Uses the albumById index for
* O(1) lookups instead of filtering the full list.
*/
async getSelectedAlbumFilePaths(
selectedAlbums: Set<number>,
): Promise<string[]> {
try {
const byAlbum = await this.fetchAlbumPaths(
selectedAlbums,
);
const allPaths: string[] = [];
for (const id of selectedAlbums) {
allPaths.push(...(byAlbum[id] ?? []));
}
return allPaths;
} catch (error) {
console.error(
'Error loading album tracks:',
error,
);
return [];
}
}
/**
* Return file paths for the context menu target.
* If the right-clicked album is part of the current
* selection, return paths for all selected albums.
* Otherwise return paths for the right-clicked
* album only.
*/
async getContextMenuAlbumFilePaths(
contextMenuAlbumId: number | null,
selectedAlbums: Set<number>,
): Promise<string[]> {
if (
contextMenuAlbumId !== null &&
!selectedAlbums.has(contextMenuAlbumId)
) {
const album = this.albumById.get(
contextMenuAlbumId,
);
if (album) {
return this.getAlbumFilePaths(album);
}
return [];
}
return this.getSelectedAlbumFilePaths(
selectedAlbums,
);
}
/**
* Fetch file paths for a single album by loading
* its tracks from the backend.
*/
async getAlbumFilePaths(
album: library.Album,
): Promise<string[]> {
try {
const tracks =
await this.fetchAlbumTracks(album.ID);
return tracks.map((t) => t.FilePath);
} catch (error) {
console.error(
'Error loading album tracks:',
error,
);
return [];
}
}
// ================================================================
// Drag file-path cache
// ================================================================
/**
* Pre-resolve file paths for all selected albums so
* that dragstart can read them synchronously. Called
* fire-and-forget whenever the album selection changes.
*
* After warming, prunes entries whose album ID is no
* longer in the selection to prevent unbounded growth.
*/
async warmCache(
selectedAlbums: Set<number>,
): Promise<void> {
const missing = [...selectedAlbums].filter(
(id) => !this.albumFilePathCache.has(id),
);
try {
const byAlbum =
await this.fetchAlbumPaths(missing);
for (const id of missing) {
const paths = byAlbum[id];
// Only store if still selected: the
// selection can have moved on while
// this was in flight.
if (paths && selectedAlbums.has(id)) {
this.albumFilePathCache.set(
id,
paths,
);
}
}
} catch {
// Silently skip — drag will just not
// include these albums' paths.
}
// Prune stale entries (6h).
for (const id of this.albumFilePathCache.keys()) {
if (!selectedAlbums.has(id)) {
this.albumFilePathCache.delete(id);
}
}
}
/**
* Read cached file paths for the current album
* selection. Returns concatenated paths (may be
* incomplete if some albums haven't been cached yet).
*/
getCachedSelectedPaths(
selectedAlbums: Set<number>,
): string[] {
const result: string[] = [];
for (const id of selectedAlbums) {
const paths =
this.albumFilePathCache.get(id);
if (paths) {
result.push(...paths);
}
}
return result;
}
/**
* Check whether a single album's paths are in the
* cache, and return them if so.
*/
getCachedAlbumPaths(
albumId: number,
): string[] | undefined {
return this.albumFilePathCache.get(albumId);
}
/**
* Warm a single album's cache entry (used by
* pointerdown before a potential dragstart).
*/
async warmSingleAlbum(
album: library.Album,
): Promise<void> {
if (this.albumFilePathCache.has(album.ID)) {
return;
}
const paths = await this.getAlbumFilePaths(
album,
);
if (paths.length > 0) {
this.albumFilePathCache.set(
album.ID,
paths,
);
}
}
// ================================================================
// Track selection helpers
// ================================================================
/**
* Return the set of track file paths in the range
* [from, to] (inclusive, order-independent).
*/
selectTrackRange(
from: number,
to: number,
expandedTracks: library.Track[],
): Set<string> {
const start = Math.min(from, to);
const end = Math.max(from, to);
const paths = new Set<string>();
for (let i = start; i <= end; i++) {
const track = expandedTracks[i];
if (track) {
paths.add(track.FilePath);
}
}
return paths;
}
/**
* Return selected track file paths in their
* original track order.
*/
getSelectedTrackFilePaths(
selectedTracks: Set<string>,
expandedTracks: library.Track[],
): string[] {
return expandedTracks
.filter((t) =>
selectedTracks.has(t.FilePath),
)
.map((t) => t.FilePath);
}
// ================================================================
// Cover art resolution
// ================================================================
/**
* Resolve cover art URLs for a track's album.
* Uses the albumById index with the expanded album ID
* for an O(1) lookup instead of a name-based O(n) scan.
*
* Falls back to name-based search if the expanded album
* doesn't match (defensive).
*/
resolveTrackCoverArt(
albumName: string,
expandedAlbumId: number | null,
): CoverArtUrls | null {
// Prefer the expanded album (we know the track
// belongs to it) for an O(1) lookup. This must
// run before the albumName guard because
// GetAlbumTracks returns tracks without an Album
// field, so albumName may be empty even when the
// album ID is known.
if (expandedAlbumId !== null) {
const album = this.albumById.get(
expandedAlbumId,
);
if (album?.CoverArtPath) {
return {
coverArtPath: album.CoverArtPath,
coverArtSmall: album.CoverArtSmall,
coverArtMedium:
album.CoverArtMedium,
coverArtLarge: album.CoverArtLarge,
};
}
}
if (!albumName) return null;
// Fallback: name-based search across all albums.
for (const album of this.albumById.values()) {
if (
album.Name === albumName &&
album.CoverArtPath
) {
return {
coverArtPath: album.CoverArtPath,
coverArtSmall: album.CoverArtSmall,
coverArtMedium:
album.CoverArtMedium,
coverArtLarge: album.CoverArtLarge,
};
}
}
return null;
}
}