yonluandClaude Opus 5
4471db3aef
Phases 2 and 3 of plan 009, plus the parts of phase 1 that could not
land before them. Nothing in the tree imports wails/v2 any more; all
three lint and test configurations are green and `go build .` produces
a running binary.
The point of the migration is one file. backend/events/emit.go probed
ctx.Value("events") — a v2-*private* context key — to decide whether
emitting was safe, because runtime.EventsEmit called log.Fatalf on a
context without the runtime and took the process down with it. v3's
emit takes no context, so that is now application.Get() == nil. D1
held: events.Emit keeps its ctx as the WithSink test seam, and all 45
call sites and 7 test files are untouched.
The bootstrap splits into application.New + Window.NewWithOptions +
Run. Ten bound services implement ServiceStartup instead of being
handed a context by hand from OnStartup, which also stops ten
SetContext methods being exported as bindings. jobs.Registry and
explore.SearchIndex keep theirs — neither is bound, so converting them
would be churn for no binding removed.
Four things differed from the plan and are written up in it: GPU policy
moved to the per-window LinuxWindow options rather than surviving on
LinuxOptions; there is no OnStartup/OnDomReady option, so app-level
wiring hangs off ApplicationStarted; application.NewService is generic,
so FEBindings []any could not survive (the binding generator is a
static analyser and would have seen nothing); and the quit veto had to
be restructured, because v3's dialog answers on a callback rather than
returning the button, so ShouldQuit vetoes, asks, and quits again from
the callback.
Window state saving moves to a WindowClosing hook — the size has to be
read while the window still exists, and v3's OnShutdown has neither
context nor window. backend/logging is deleted rather than ported:
v3 takes a *slog.Logger directly, so the v2 logger.Logger adapter had
no caller left.
Phase 1's tail rides along, now that it can: the Makefile's wails
invocations, all 50 webkit2_41 sites, lefthook, both packaging recipes
and ci.yml's apt lists. v3 builds against GTK4 + WebKitGTK 6.0, which
Arch and ubuntu:24.04 both ship, so the tag is a deletion rather than
a translation.
Phase 4 is next and the branch is not usable until it lands: the app
builds, but frontend/wailsjs/ is v2's tree and nothing regenerates it,
so the frontend cannot reach the backend yet.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDCbcCZQepnpSQYJ6SxxZm
44 lines
1.5 KiB
Bash
Executable File
44 lines
1.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Fails when frontend/wailsjs/ is stale against the bound Go structs.
|
|
#
|
|
# frontend/wailsjs/ is generated by `wails`, not by `go generate`, so the
|
|
# pre-commit codegen check does not cover it at all. Without this, a
|
|
# renamed Go struct field or a changed method signature first shows up at
|
|
# runtime, inside a window, as a binding that never settles.
|
|
#
|
|
# `wails generate module` builds the app with the `bindings` tag and runs
|
|
# it to dump the bindings — about three seconds, so it is cheap enough to
|
|
# gate a commit on.
|
|
|
|
set -euo pipefail
|
|
|
|
cd "$(dirname "$0")/.."
|
|
|
|
TARGET="frontend/wailsjs"
|
|
|
|
if [ -n "$(git status --porcelain -- "$TARGET")" ]; then
|
|
echo "bindings-check: $TARGET has uncommitted changes; stage or stash them first" >&2
|
|
git status --short -- "$TARGET" >&2
|
|
exit 1
|
|
fi
|
|
|
|
go tool wails generate module >/dev/null 2>&1
|
|
|
|
# `wails generate module` rewrites the three runtime files as 755 every
|
|
# time. That is not drift, so compare content only.
|
|
if ! git -c core.fileMode=false diff --quiet -- "$TARGET"; then
|
|
echo "bindings-check: $TARGET is out of date with the Go bindings." >&2
|
|
echo "Run 'make bindings' and stage the result." >&2
|
|
git -c core.fileMode=false diff --stat -- "$TARGET" >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Restore the modes the generator churned, so the tree is left clean.
|
|
chmod 644 \
|
|
frontend/wailsjs/runtime/runtime.js \
|
|
frontend/wailsjs/runtime/runtime.d.ts \
|
|
frontend/wailsjs/runtime/package.json
|
|
|
|
echo "bindings-check: frontend/wailsjs is current"
|