yonluandClaude Opus 5
e7748f1fd5
Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
98 lines
4.3 KiB
SQL
98 lines
4.3 KiB
SQL
-- The downloaded MusicBrainz/ListenBrainz catalog.
|
|
--
|
|
-- MusicBrainz ids are stored as their 16 raw bytes and entity types as
|
|
-- small integers, which is a size decision: on a real 2,052,200-row
|
|
-- catalog those four columns were 220 MB of a 383 MB table and were
|
|
-- carried again in every index keyed on them, and the conversion took
|
|
-- the table and its four indexes from 677 MB to 389 MB. See
|
|
-- backend/explore/mbid.go, which is the only place that encoding is
|
|
-- known -- everything above it speaks dashed strings and entity names.
|
|
--
|
|
-- The CHECK constraints are what make a mistake loud. SQLite does not
|
|
-- coerce between TEXT and BLOB, so a query comparing this column
|
|
-- against a 36-character string returns no rows rather than an error;
|
|
-- a *write* of one fails here instead, at the insert that made it.
|
|
CREATE TABLE IF NOT EXISTS explore_index (
|
|
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
|
entity_type INTEGER NOT NULL,
|
|
mbid BLOB NOT NULL CHECK(length(mbid) = 16),
|
|
title TEXT NOT NULL,
|
|
artist_name TEXT NOT NULL,
|
|
artist_mbid BLOB NOT NULL
|
|
CHECK(length(artist_mbid) IN (0, 16)),
|
|
aliases TEXT NOT NULL DEFAULT '',
|
|
|
|
-- Popularity signals, derived from the ListenBrainz listens dump.
|
|
popularity INTEGER NOT NULL DEFAULT 0,
|
|
listener_count INTEGER NOT NULL DEFAULT 0,
|
|
|
|
-- Recording-specific fields.
|
|
duration INTEGER NOT NULL DEFAULT 0,
|
|
caa_release_mbid BLOB NOT NULL DEFAULT x''
|
|
CHECK(length(caa_release_mbid) IN (0, 16)),
|
|
release_name TEXT NOT NULL DEFAULT '',
|
|
|
|
-- Release-group-specific fields.
|
|
primary_type TEXT NOT NULL DEFAULT '',
|
|
secondary_types TEXT NOT NULL DEFAULT '',
|
|
release_date TEXT NOT NULL DEFAULT '',
|
|
|
|
-- How many tracks the release group's canonical release has, so
|
|
-- "do I have all of this" is answerable offline for an album the
|
|
-- library holds no tags for. Zero means the catalog does not say,
|
|
-- which is the same third state the local answer has -- and is what
|
|
-- every row carries until a central dump build fills it.
|
|
total_tracks INTEGER NOT NULL DEFAULT 0,
|
|
|
|
-- Artist-specific fields.
|
|
artist_type TEXT NOT NULL DEFAULT '',
|
|
country TEXT NOT NULL DEFAULT '',
|
|
disambiguation TEXT NOT NULL DEFAULT '',
|
|
sort_name TEXT NOT NULL DEFAULT '',
|
|
|
|
-- Personalization flags.
|
|
in_library INTEGER NOT NULL DEFAULT 0,
|
|
is_similar INTEGER NOT NULL DEFAULT 0,
|
|
|
|
-- Cross-reference to local library tables. NULL when the
|
|
-- entity has no corresponding row in the library.
|
|
local_artist_id INTEGER,
|
|
local_release_group_id INTEGER,
|
|
local_recording_id INTEGER,
|
|
|
|
-- Set once an artist's full discography (release groups +
|
|
-- recordings) has been fetched, so EnsureArtistDiscography can
|
|
-- skip artists the catalog already covers.
|
|
discog_fetched INTEGER NOT NULL DEFAULT 0,
|
|
|
|
|
|
UNIQUE(mbid)
|
|
);
|
|
|
|
-- The exact-match tier's two indexes.
|
|
--
|
|
-- Their predicate is the champion set - the popular rows plus whatever
|
|
-- the user owns - and matching it to `ExactMatches`' own WHERE clause is
|
|
-- what makes them small. They used to say `popularity > 0`, which on a
|
|
-- real 2,052,200-row catalog covered 2,046,645 of them: a full index
|
|
-- wearing a partial index's clothes, 101 MB for the pair. Narrowed to
|
|
-- the set the tier can actually return, they are 3 MB and the query
|
|
-- plan is unchanged (measured, on that catalog).
|
|
CREATE INDEX IF NOT EXISTS idx_explore_artist_lower
|
|
ON explore_index(LOWER(artist_name))
|
|
WHERE popularity >= 10000 OR in_library = 1;
|
|
|
|
CREATE INDEX IF NOT EXISTS idx_explore_caa_release
|
|
ON explore_index(caa_release_mbid)
|
|
WHERE entity_type = 2 AND caa_release_mbid != x'';
|
|
|
|
CREATE INDEX IF NOT EXISTS idx_explore_index_artist_mbid
|
|
ON explore_index(artist_mbid, entity_type, popularity DESC);
|
|
|
|
CREATE INDEX IF NOT EXISTS idx_explore_index_entity_pop
|
|
ON explore_index(entity_type, popularity DESC);
|
|
|
|
CREATE INDEX IF NOT EXISTS idx_explore_title_lower
|
|
ON explore_index(LOWER(title))
|
|
WHERE popularity >= 10000 OR in_library = 1;
|