Files
yellowjacket/backend/database/database_test.go
T
yonluandClaude Opus 5 e7748f1fd5
CI / check (push) Successful in 3m7s
CI / e2e (push) Canceled after 1m45s
feat(database): shape the library like files, and shrink the catalog
Plans 013 and 014, the album page that prompted them, and the smaller
fixes they turned up. Changelog, largest first.

## The local library is shaped like files, not like MusicBrainz

`audio_files` carries its own tags and points at `albums` and
`artists`; `file_genres` is the one real many-to-many. `recordings`,
`release_group_recordings`, `artist_credit`, `artist_credit_artist`,
`recording_genres`, `release_groups` and `release_to_rg` are gone from
the local side, and with them a six-way join in every read, a
`MIN(release_group_id)` subquery in eleven queries and a
first-credited-artist subquery in nine. Measured on a real 25,966-file
library, every many-to-many that model expressed was 1:1 in the data.

- Ownership is a file. `GetFilePathsByRecordingMBIDs`,
  `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and
  `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812
  orphaned recordings, 216 release groups and 260 artists that library
  carried are now structurally impossible.
- One projection: every track query selects from the `track_metadata`
  view, one row type, one mapper. Nine hand-rolled copies had drifted
  far enough to report different years on different screens.
- `library_id = 0` means every library, so each list query exists once
  instead of scoped and unscoped with a branch at every call site.
- No migration chain. `sql/schemas/` is the one description of the
  shape; `sql/migrations/`, `applyMigrations` and `schema_migrations`
  are squashed away, along with the drift between them that had sqlc
  generating against a stale schema.
- `database.InsertTestTrack` is the one test seeder; twenty test files
  had been assembling the old FK chain each in its own order.

## The catalog stores its ids as bytes

`explore_index`'s three 36-char MBID columns and its entity-type text
are 16 raw bytes and a small integer. The table and its six indexes go
780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh
install is ~0.6 GB rather than ~1.0 GB.

- `backend/explore/mbid.go` is the only place the encoding is known;
  everything above it speaks dashed strings.
- `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert
  rather than silently returning no rows, since SQLite does not coerce
  between TEXT and BLOB.
- The importer asks the artifact what encoding it carries and converts
  on the way in, so the artifact already published keeps working and no
  format bump is needed.
- `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column
  list, and `TestStoredEncodingRoundTrips` sweeps every read path.

## An album page that says how much of the album is yours

- One question, asked once: is there a file. `filePaths` is filled by a
  single batched lookup when the tracklist settles, and the badge, the
  Play count, the dimmed rows and every menu item read it — replacing
  four claims of decreasing confidence that could show a green tick on
  an album whose every action did nothing.
- Play, Play 7 of 12, or no play button at all.
- `total_tracks` on `explore_index` (~2 bytes over 400,677 release
  groups) and on `audio_files` from tags that have always carried it:
  a complete MBID-matched album now makes no catalog call at all, where
  it used to spend the most expensive request the app makes.
- A merged cluster shows the running order the most releases agree on,
  and the version list marks the release you own rather than standing a
  synthetic entry in for it.
- `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed
  one by a 12-second timer.
- Rows not in the library are dimmed in place (with `aria-disabled`)
  instead of the owned ones wearing a green tick and a legend.

## Caches and cover art get ceilings

- Only the three tiers of a cover are stored; the full-resolution copy
  nothing rendered was 1,134 MB of a 1.4 GB covers directory.
- One artist portrait is downloaded and the rest are remembered as
  URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads.
- `browsedArtBudget` and `httpCacheBudget` bound what an age cannot:
  the same install held art for 5,770 artists in a 1,301-artist
  library.
- `OrphanedArtistImagesJob` joined a bare MBID onto a sharded
  directory, so it deleted the rows that were the only record of the
  files it left behind. `explore.ArtistImageDir` is that layout's one
  definition now.

## The autotag queue asks whether there is work

`tagging_items` was a row per album folder, not a queue, and no query
read the `tag_status` column that held the answer. The four queue
queries ask the files, which matters most where it is least visible:
`startPrefetch` was scoring every album in a tagged library against
MusicBrainz.

## Phantom playlist tracks resolve in place

An M3U8 imported before its files leaves phantom rows; they now match
by path and fall back to position, keep their place in the playlist
when resolved, and pair best-first so two phantoms cannot claim the
same file.

## Playing a track plays the list it is in

Double-click, and Play on a single row's menu, queue the list as
displayed with `startIndex` on that row — the album page and the track
list used to queue one track and discard the album around it. A
multi-row selection still plays exactly itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
2026-08-16 13:58:15 -04:00

1082 lines
22 KiB
Go

package database
import (
"database/sql"
"strings"
"testing"
"yellowjacket/backend/database/sql/sqlcgen"
)
// ---------------------------------------------------------------------------
// Migration 6 integration tests
// ---------------------------------------------------------------------------
func TestSchemaCreatesLibrariesTable(t *testing.T) {
t.Parallel()
db := NewTestDB(t)
// Verify libraries table exists.
var tableCount int64
rows, err := db.QueryContext(
"SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name='libraries'",
)
if err != nil {
t.Fatalf("query sqlite_master: %v", err)
}
if !rows.Next() {
_ = rows.Close()
t.Fatal("no row returned from sqlite_master query")
}
if err := rows.Scan(&tableCount); err != nil {
_ = rows.Close()
t.Fatalf("scan table count: %v", err)
}
_ = rows.Close()
if tableCount != 1 {
t.Errorf("libraries table count = %d, want 1", tableCount)
}
// Verify audio_files has library_id column.
hasLibraryID := false
afRows, err := db.QueryContext("PRAGMA table_info(audio_files)")
if err != nil {
t.Fatalf("PRAGMA table_info(audio_files): %v", err)
}
for afRows.Next() {
var (
cid int64
name string
colType string
notNull int64
dfltValue sql.NullString
pk int64
)
if err := afRows.Scan(
&cid, &name, &colType, &notNull, &dfltValue, &pk,
); err != nil {
_ = afRows.Close()
t.Fatalf("scan table_info row: %v", err)
}
if name == "library_id" {
hasLibraryID = true
}
}
_ = afRows.Close()
if !hasLibraryID {
t.Error("audio_files missing library_id column")
}
// Verify playlist_tracks has phantom columns and nullable
// audio_file_id.
phantomCols := map[string]bool{
"phantom_title": false,
"phantom_artist": false,
"phantom_album": false,
"phantom_duration_ms": false,
"phantom_genre": false,
"phantom_cover_art_path": false,
"phantom_file_path": false,
}
audioFileIDNullable := false
ptRows, err := db.QueryContext(
"PRAGMA table_info(playlist_tracks)",
)
if err != nil {
t.Fatalf("PRAGMA table_info(playlist_tracks): %v", err)
}
for ptRows.Next() {
var (
cid int64
name string
colType string
notNull int64
dfltValue sql.NullString
pk int64
)
if err := ptRows.Scan(
&cid, &name, &colType, &notNull, &dfltValue, &pk,
); err != nil {
_ = ptRows.Close()
t.Fatalf("scan playlist_tracks table_info: %v", err)
}
if _, ok := phantomCols[name]; ok {
phantomCols[name] = true
}
if name == "audio_file_id" && notNull == 0 {
audioFileIDNullable = true
}
}
_ = ptRows.Close()
for col, found := range phantomCols {
if !found {
t.Errorf("playlist_tracks missing column: %s", col)
}
}
if !audioFileIDNullable {
t.Error(
"playlist_tracks.audio_file_id should be nullable",
)
}
// Verify track_metadata VIEW includes library_id.
viewRows, err := db.QueryContext(
"SELECT sql FROM sqlite_master WHERE name='track_metadata'",
)
if err != nil {
t.Fatalf("query track_metadata view: %v", err)
}
if !viewRows.Next() {
_ = viewRows.Close()
t.Fatal("track_metadata view not found")
}
var viewSQL string
if err := viewRows.Scan(&viewSQL); err != nil {
_ = viewRows.Close()
t.Fatalf("scan view sql: %v", err)
}
_ = viewRows.Close()
if !strings.Contains(viewSQL, "library_id") {
t.Error("track_metadata VIEW does not contain library_id")
}
// Verify libraries table has only the sentinel row on fresh DB.
count, err := db.Queries.CountLibraries(db.Ctx)
if err != nil {
t.Fatalf("CountLibraries: %v", err)
}
// Sentinel library at id=0 is inserted by NewTestDB.
if count != 1 {
t.Errorf(
"CountLibraries on fresh DB = %d, want 1 (sentinel only)",
count,
)
}
}
func TestLibraryQueries(t *testing.T) {
t.Parallel()
db := NewTestDB(t)
// Create a library.
lib, err := db.Queries.CreateLibrary(
db.Ctx,
sqlcgen.CreateLibraryParams{
Name: "Music",
Path: "/home/user/Music",
},
)
if err != nil {
t.Fatalf("CreateLibrary: %v", err)
}
if lib.Name != "Music" {
t.Errorf("Name = %q, want %q", lib.Name, "Music")
}
if lib.Path != "/home/user/Music" {
t.Errorf("Path = %q, want %q", lib.Path, "/home/user/Music")
}
if lib.ID <= 0 {
t.Errorf("ID = %d, want > 0", lib.ID)
}
// Get by ID.
got, err := db.Queries.GetLibrary(db.Ctx, lib.ID)
if err != nil {
t.Fatalf("GetLibrary: %v", err)
}
if got.Name != lib.Name || got.Path != lib.Path {
t.Errorf(
"GetLibrary = {%q, %q}, want {%q, %q}",
got.Name, got.Path, lib.Name, lib.Path,
)
}
// Get by path.
gotByPath, err := db.Queries.GetLibraryByPath(
db.Ctx, "/home/user/Music",
)
if err != nil {
t.Fatalf("GetLibraryByPath: %v", err)
}
if gotByPath.ID != lib.ID {
t.Errorf(
"GetLibraryByPath ID = %d, want %d",
gotByPath.ID, lib.ID,
)
}
// Unique path constraint.
_, err = db.Queries.CreateLibrary(
db.Ctx,
sqlcgen.CreateLibraryParams{
Name: "Duplicate",
Path: "/home/user/Music",
},
)
if !IsUniqueViolation(err) {
t.Errorf(
"duplicate path insert: got %v, want unique violation",
err,
)
}
// List libraries (sentinel + Music).
libs, err := db.Queries.GetAllLibraries(db.Ctx)
if err != nil {
t.Fatalf("GetAllLibraries: %v", err)
}
if len(libs) != 2 {
t.Errorf("GetAllLibraries len = %d, want 2", len(libs))
}
// Update name.
err = db.Queries.UpdateLibraryName(
db.Ctx,
sqlcgen.UpdateLibraryNameParams{
Name: "My Music",
ID: lib.ID,
},
)
if err != nil {
t.Fatalf("UpdateLibraryName: %v", err)
}
updated, _ := db.Queries.GetLibrary(db.Ctx, lib.ID)
if updated.Name != "My Music" {
t.Errorf(
"after update Name = %q, want %q",
updated.Name, "My Music",
)
}
// Delete.
err = db.Queries.DeleteLibrary(db.Ctx, lib.ID)
if err != nil {
t.Fatalf("DeleteLibrary: %v", err)
}
count, _ := db.Queries.CountLibraries(db.Ctx)
// Only sentinel remains.
if count != 1 {
t.Errorf("after delete CountLibraries = %d, want 1", count)
}
}
func TestPhantomPlaylistTracksAreCleaned(t *testing.T) {
t.Parallel()
db, libID := NewTestDBWithLibrary(t, "Test", "/test/music")
// Create prerequisite data: artist_credit, recording,
// audio_file.
InsertTestTrack(t, db, TestTrack{
FilePath: "/test/music/song.mp3",
Title: "Test Song",
Artist: "Test Artist",
LengthMs: 180000,
LibraryID: libID,
})
// Create playlist.
playlist, err := db.Queries.CreatePlaylist(
db.Ctx, "Test Playlist",
)
if err != nil {
t.Fatalf("CreatePlaylist: %v", err)
}
// Add track with phantom metadata (eager population).
track, err := db.Queries.AddPlaylistTrack(
db.Ctx,
sqlcgen.AddPlaylistTrackParams{
PlaylistID: playlist.ID,
AudioFileID: sql.NullInt64{
Int64: 1,
Valid: true,
},
Position: 0,
PhantomTitle: sql.NullString{
String: "Test Song",
Valid: true,
},
PhantomArtist: sql.NullString{
String: "Test Artist",
Valid: true,
},
PhantomAlbum: sql.NullString{
String: "Test Album",
Valid: true,
},
PhantomDurationMs: sql.NullInt64{
Int64: 180000,
Valid: true,
},
PhantomGenre: sql.NullString{
String: "Rock",
Valid: true,
},
},
)
if err != nil {
t.Fatalf("AddPlaylistTrack: %v", err)
}
if track.ID <= 0 {
t.Errorf("track ID = %d, want > 0", track.ID)
}
// Delete the audio file — FK ON DELETE SET NULL should set
// audio_file_id to NULL without deleting the playlist_track.
_, err = db.ExecContext(
"DELETE FROM audio_files WHERE id = 1",
)
if err != nil {
t.Fatalf("delete audio_file: %v", err)
}
// Verify playlist track still exists with phantom data.
tracks, err := db.Queries.GetPlaylistTracksWithMetadata(
db.Ctx, playlist.ID,
)
if err != nil {
t.Fatalf("GetPlaylistTracksWithMetadata: %v", err)
}
if len(tracks) != 1 {
t.Fatalf(
"tracks after delete = %d, want 1", len(tracks),
)
}
row := tracks[0]
if row.AudioFileID.Valid {
t.Error(
"audio_file_id should be NULL after delete",
)
}
if row.Title != "Test Song" {
t.Errorf(
"phantom Title = %q, want %q",
row.Title, "Test Song",
)
}
if row.Artist != "Test Artist" {
t.Errorf(
"phantom Artist = %q, want %q",
row.Artist, "Test Artist",
)
}
if row.IsPhantom != 1 {
t.Errorf("IsPhantom = %d, want 1", row.IsPhantom)
}
}
func TestAudioFilesLibraryForeignKey(t *testing.T) {
t.Parallel()
db, libID := NewTestDBWithLibrary(t, "Test", "/test/fk-lib")
// Insert prerequisite recording.
InsertTestTrack(t, db, TestTrack{
FilePath: "/test/track.mp3",
Title: "Track",
Artist: "Test",
LibraryID: libID,
})
// Insert audio file with invalid library_id - should fail FK.
_, err := db.ExecContext(
"INSERT INTO audio_files " +
"(id, file_path, length_milliseconds, file_type_id, library_id) " +
"VALUES (2, '/test/song2.mp3', 200000, 0, 999)",
)
if err == nil {
t.Error(
"insert with invalid library_id should fail FK check",
)
}
// Count files by library.
count, err := db.Queries.CountAudioFiles(
db.Ctx, libID,
)
if err != nil {
t.Fatalf("CountAudioFiles: %v", err)
}
if count != 1 {
t.Errorf(
"CountAudioFiles = %d, want 1", count,
)
}
}
func TestTrackMetadataViewHasLibraryID(t *testing.T) {
t.Parallel()
db, libID := NewTestDBWithLibrary(t, "Test", "/test/view-lib")
// Insert prerequisites.
InsertTestTrack(t, db, TestTrack{
FilePath: "/test/view.mp3",
Title: "View Track",
Artist: "View Artist",
LengthMs: 200000,
LibraryID: libID,
})
// Query track_metadata VIEW and verify library_id is present
// with the correct value.
viewRows, err := db.QueryContext(
"SELECT library_id FROM track_metadata WHERE id = 1",
)
if err != nil {
t.Fatalf("query track_metadata: %v", err)
}
if !viewRows.Next() {
_ = viewRows.Close()
t.Fatal("track_metadata: no row returned")
}
var viewLibID int64
if err := viewRows.Scan(&viewLibID); err != nil {
_ = viewRows.Close()
t.Fatalf("scan library_id from view: %v", err)
}
_ = viewRows.Close()
if viewLibID != libID {
t.Errorf(
"track_metadata.library_id = %d, want %d",
viewLibID, libID,
)
}
}
// ---------------------------------------------------------------------------
// Migration 9 integration tests
// ---------------------------------------------------------------------------
func TestSmartPlaylistColumns(t *testing.T) {
t.Parallel()
db := NewTestDB(t)
// Verify playlists table has is_smart and smart_rules columns.
hasSmart := false
hasRules := false
ptRows, err := db.QueryContext(
"PRAGMA table_info(playlists)",
)
if err != nil {
t.Fatalf("PRAGMA table_info(playlists): %v", err)
}
for ptRows.Next() {
var (
cid int64
name string
colType string
notNull int64
dfltValue sql.NullString
pk int64
)
if err := ptRows.Scan(
&cid, &name, &colType, &notNull, &dfltValue, &pk,
); err != nil {
_ = ptRows.Close()
t.Fatalf("scan playlists table_info: %v", err)
}
if name == "is_smart" {
hasSmart = true
}
if name == "smart_rules" {
hasRules = true
}
}
_ = ptRows.Close()
if !hasSmart {
t.Error("playlists missing is_smart column")
}
if !hasRules {
t.Error("playlists missing smart_rules column")
}
// Insert a smart playlist with rules.
rulesJSON := `{"rules":[{"field":"genre","operator":"is","value":"Rock"}]}`
_, err = db.ExecContext(
"INSERT INTO playlists (name, is_smart, smart_rules) VALUES (?, 1, ?)",
"Rock Songs", rulesJSON,
)
if err != nil {
t.Fatalf("insert smart playlist: %v", err)
}
// Read it back and verify.
rows, err := db.QueryContext(
"SELECT is_smart, smart_rules FROM playlists WHERE name = ?",
"Rock Songs",
)
if err != nil {
t.Fatalf("query smart playlist: %v", err)
}
if !rows.Next() {
_ = rows.Close()
t.Fatal("smart playlist not found")
}
var (
isSmart int64
smartRules sql.NullString
)
if err := rows.Scan(&isSmart, &smartRules); err != nil {
_ = rows.Close()
t.Fatalf("scan smart playlist: %v", err)
}
_ = rows.Close()
if isSmart != 1 {
t.Errorf("is_smart = %d, want 1", isSmart)
}
if !smartRules.Valid || smartRules.String != rulesJSON {
t.Errorf(
"smart_rules = %q, want %q",
smartRules.String, rulesJSON,
)
}
// Insert a regular playlist (default is_smart) and verify
// it defaults to 0.
_, err = db.ExecContext(
"INSERT INTO playlists (name) VALUES (?)",
"Regular Playlist",
)
if err != nil {
t.Fatalf("insert regular playlist: %v", err)
}
regRows, err := db.QueryContext(
"SELECT is_smart, smart_rules FROM playlists WHERE name = ?",
"Regular Playlist",
)
if err != nil {
t.Fatalf("query regular playlist: %v", err)
}
if !regRows.Next() {
_ = regRows.Close()
t.Fatal("regular playlist not found")
}
var (
regSmart int64
regRules sql.NullString
)
if err := regRows.Scan(&regSmart, &regRules); err != nil {
_ = regRows.Close()
t.Fatalf("scan regular playlist: %v", err)
}
_ = regRows.Close()
if regSmart != 0 {
t.Errorf("regular playlist is_smart = %d, want 0", regSmart)
}
if regRules.Valid {
t.Errorf(
"regular playlist smart_rules should be NULL, got %q",
regRules.String,
)
}
}
// ---------------------------------------------------------------------------
// Migration 10 — play history tracking
// ---------------------------------------------------------------------------
func TestPlayHistoryTable(t *testing.T) {
t.Parallel()
db := NewTestDB(t)
// Verify play_history table exists.
var tableCount int64
tblRows, err := db.QueryContext(
"SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name='play_history'",
)
if err != nil {
t.Fatalf("query sqlite_master: %v", err)
}
if !tblRows.Next() {
_ = tblRows.Close()
t.Fatal("no row from sqlite_master query")
}
if err := tblRows.Scan(&tableCount); err != nil {
_ = tblRows.Close()
t.Fatalf("scan table count: %v", err)
}
_ = tblRows.Close()
if tableCount != 1 {
t.Errorf("play_history table count = %d, want 1", tableCount)
}
// Verify audio_files has play_count and last_played columns.
hasPlayCount := false
hasLastPlayed := false
colRows, err := db.QueryContext("PRAGMA table_info(audio_files)")
if err != nil {
t.Fatalf("PRAGMA table_info(audio_files): %v", err)
}
for colRows.Next() {
var (
cid int64
name string
colType string
notNull int64
dfltValue sql.NullString
pk int64
)
if err := colRows.Scan(
&cid, &name, &colType, &notNull, &dfltValue, &pk,
); err != nil {
_ = colRows.Close()
t.Fatalf("scan audio_files table_info: %v", err)
}
if name == "play_count" {
hasPlayCount = true
}
if name == "last_played" {
hasLastPlayed = true
}
}
_ = colRows.Close()
if !hasPlayCount {
t.Error("audio_files missing play_count column")
}
if !hasLastPlayed {
t.Error("audio_files missing last_played column")
}
// Verify track_metadata VIEW includes play_count and last_played.
viewCols := map[string]bool{}
vcRows, err := db.QueryContext("PRAGMA table_info(track_metadata)")
if err != nil {
t.Fatalf("PRAGMA table_info(track_metadata): %v", err)
}
for vcRows.Next() {
var (
cid int64
name string
colType string
notNull int64
dfltValue sql.NullString
pk int64
)
if err := vcRows.Scan(
&cid, &name, &colType, &notNull, &dfltValue, &pk,
); err != nil {
_ = vcRows.Close()
t.Fatalf("scan track_metadata table_info: %v", err)
}
viewCols[name] = true
}
_ = vcRows.Close()
if !viewCols["play_count"] {
t.Error("track_metadata VIEW missing play_count column")
}
if !viewCols["last_played"] {
t.Error("track_metadata VIEW missing last_played column")
}
// Round-trip: insert a play_history row and verify play_count update.
// First, set up test data. The test DB already has library id=0.
InsertTestTrack(t, db, TestTrack{
FilePath: "/test/play_history.mp3",
Title: "Test Track",
Artist: "Test Artist",
TrackNumber: 1,
DiscNumber: 1,
})
// Verify default play_count is 0.
var playCount int64
pcRows, err := db.QueryContext(
"SELECT play_count FROM audio_files WHERE id = 1",
)
if err != nil {
t.Fatalf("query play_count: %v", err)
}
if !pcRows.Next() {
_ = pcRows.Close()
t.Fatal("audio_file not found")
}
if err := pcRows.Scan(&playCount); err != nil {
_ = pcRows.Close()
t.Fatalf("scan play_count: %v", err)
}
_ = pcRows.Close()
if playCount != 0 {
t.Errorf("initial play_count = %d, want 0", playCount)
}
// Insert a play_history row and update play_count.
_, err = db.ExecContext(
"INSERT INTO play_history (audio_file_id) VALUES (1)",
)
if err != nil {
t.Fatalf("insert play_history: %v", err)
}
_, err = db.ExecContext(
`UPDATE audio_files
SET play_count = play_count + 1,
last_played = datetime('now')
WHERE id = 1`,
)
if err != nil {
t.Fatalf("update play_count: %v", err)
}
// Verify play_count is now 1.
pcRows2, err := db.QueryContext(
"SELECT play_count, last_played FROM audio_files WHERE id = 1",
)
if err != nil {
t.Fatalf("query play_count after update: %v", err)
}
if !pcRows2.Next() {
_ = pcRows2.Close()
t.Fatal("audio_file not found after update")
}
var (
updatedCount int64
lastPlayed sql.NullString
)
if err := pcRows2.Scan(&updatedCount, &lastPlayed); err != nil {
_ = pcRows2.Close()
t.Fatalf("scan updated play_count: %v", err)
}
_ = pcRows2.Close()
if updatedCount != 1 {
t.Errorf("play_count after update = %d, want 1", updatedCount)
}
if !lastPlayed.Valid {
t.Error("last_played should not be NULL after update")
}
// Verify track_metadata VIEW returns the play_count.
tmRows, err := db.QueryContext(
"SELECT play_count FROM track_metadata WHERE id = 1",
)
if err != nil {
t.Fatalf("query track_metadata play_count: %v", err)
}
if !tmRows.Next() {
_ = tmRows.Close()
t.Fatal("track_metadata row not found")
}
var viewPlayCount int64
if err := tmRows.Scan(&viewPlayCount); err != nil {
_ = tmRows.Close()
t.Fatalf("scan track_metadata play_count: %v", err)
}
_ = tmRows.Close()
if viewPlayCount != 1 {
t.Errorf("track_metadata play_count = %d, want 1", viewPlayCount)
}
}
// ---------------------------------------------------------------------------
// Migration 11 — explore_cache table
// ---------------------------------------------------------------------------
func TestHTTPCacheTable(t *testing.T) {
t.Parallel()
// explore_cache was split into http_cache + artist_metadata by
// migration 27 and is dropped on fresh installs. This test covers
// a table that no longer exists in a fresh DB; revisit once the
// explore cache tests are rewritten against the new schemas.
t.Skip("explore_cache dropped by migration 27; test is obsolete")
db := NewTestDB(t)
// Verify explore_cache table exists.
var tableCount int64
tblRows, err := db.QueryContext(
"SELECT COUNT(*) FROM sqlite_master WHERE type='table' AND name='explore_cache'",
)
if err != nil {
t.Fatalf("query sqlite_master: %v", err)
}
if !tblRows.Next() {
_ = tblRows.Close()
t.Fatal("no row from sqlite_master query")
}
if err := tblRows.Scan(&tableCount); err != nil {
_ = tblRows.Close()
t.Fatalf("scan table count: %v", err)
}
_ = tblRows.Close()
if tableCount != 1 {
t.Errorf("explore_cache table count = %d, want 1", tableCount)
}
// Verify all expected columns exist.
expectedCols := map[string]bool{
"url_key": false,
"response": false,
"mbid": false,
"entity_type": false,
"expires_at": false,
"created_at": false,
}
colRows, err := db.QueryContext(
"PRAGMA table_info(explore_cache)",
)
if err != nil {
t.Fatalf("PRAGMA table_info(explore_cache): %v", err)
}
for colRows.Next() {
var (
cid int64
name string
colType string
notNull int64
dfltValue sql.NullString
pk int64
)
if err := colRows.Scan(
&cid, &name, &colType, &notNull, &dfltValue, &pk,
); err != nil {
_ = colRows.Close()
t.Fatalf("scan table_info row: %v", err)
}
if _, ok := expectedCols[name]; ok {
expectedCols[name] = true
}
}
_ = colRows.Close()
for col, found := range expectedCols {
if !found {
t.Errorf("explore_cache missing column: %s", col)
}
}
// Verify indexes exist.
idxRows, err := db.QueryContext(
"SELECT name FROM sqlite_master WHERE type='index' AND tbl_name='explore_cache'",
)
if err != nil {
t.Fatalf("query indexes: %v", err)
}
indexes := map[string]bool{}
for idxRows.Next() {
var name string
if err := idxRows.Scan(&name); err != nil {
_ = idxRows.Close()
t.Fatalf("scan index name: %v", err)
}
indexes[name] = true
}
_ = idxRows.Close()
if !indexes["idx_explore_cache_expires"] {
t.Error("missing index: idx_explore_cache_expires")
}
if !indexes["idx_explore_cache_mbid"] {
t.Error("missing index: idx_explore_cache_mbid")
}
// Round-trip: insert and read back.
_, err = db.ExecContext(
`INSERT INTO explore_cache (url_key, response, mbid, entity_type, expires_at)
VALUES ('test-key', '{"data":"value"}', 'abc-123', 'artist', datetime('now', '+1 hour'))`,
)
if err != nil {
t.Fatalf("insert explore_cache: %v", err)
}
rows, err := db.QueryContext(
"SELECT url_key, response, mbid, entity_type FROM explore_cache WHERE url_key = 'test-key'",
)
if err != nil {
t.Fatalf("query explore_cache: %v", err)
}
if !rows.Next() {
_ = rows.Close()
t.Fatal("explore_cache row not found")
}
var (
urlKey string
response string
mbid sql.NullString
entityType sql.NullString
)
if err := rows.Scan(&urlKey, &response, &mbid, &entityType); err != nil {
_ = rows.Close()
t.Fatalf("scan explore_cache row: %v", err)
}
_ = rows.Close()
if urlKey != "test-key" {
t.Errorf("url_key = %q, want %q", urlKey, "test-key")
}
if response != `{"data":"value"}` {
t.Errorf("response = %q, want %q", response, `{"data":"value"}`)
}
if !mbid.Valid || mbid.String != "abc-123" {
t.Errorf("mbid = %v, want abc-123", mbid)
}
if !entityType.Valid || entityType.String != "artist" {
t.Errorf("entity_type = %v, want artist", entityType)
}
}