Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
138 lines
5.0 KiB
SQL
138 lines
5.0 KiB
SQL
-- Queries over albums (formerly release_groups).
|
|
--
|
|
-- The two-copy pattern is gone here too: one query answers both the
|
|
-- whole-library and the single-library case. The `fallback_ac`
|
|
-- subquery every album read used to carry -- "if the album has no album
|
|
-- artist credit, borrow one from any of its recordings" -- is gone with
|
|
-- it, because the album carries its own credit text now.
|
|
|
|
-- name: UpsertAlbum :one
|
|
INSERT INTO albums (name, artist_credit, artist_id, year, cover_art_id)
|
|
VALUES (?, ?, ?, ?, ?)
|
|
ON CONFLICT(name, artist_credit) DO UPDATE SET
|
|
artist_id = COALESCE(excluded.artist_id, albums.artist_id),
|
|
year = COALESCE(excluded.year, albums.year),
|
|
cover_art_id = COALESCE(excluded.cover_art_id, albums.cover_art_id)
|
|
RETURNING *;
|
|
|
|
-- name: GetAlbum :one
|
|
SELECT * FROM albums WHERE id = ? LIMIT 1;
|
|
|
|
-- name: SetAlbumMBID :exec
|
|
UPDATE albums SET mbid = ? WHERE id = ?;
|
|
|
|
-- name: SetAlbumOriginalYear :exec
|
|
UPDATE albums SET original_year = ? WHERE id = ?;
|
|
|
|
-- name: SetAlbumCoverArt :exec
|
|
UPDATE albums SET cover_art_id = ? WHERE id = ?;
|
|
|
|
-- name: SetAlbumPendingReleaseMBID :exec
|
|
UPDATE albums SET pending_release_mbid = ? WHERE id = ?;
|
|
|
|
-- name: ResolveAlbumPendingReleaseMBID :exec
|
|
-- Clears the pending marker once the release-group MBID it stood in for
|
|
-- has been resolved. Guarded so a real MBID is never overwritten.
|
|
UPDATE albums
|
|
SET mbid = ?, pending_release_mbid = NULL
|
|
WHERE id = ? AND (mbid IS NULL OR mbid = '');
|
|
|
|
-- name: GetAlbumsWithPendingReleaseMBID :many
|
|
SELECT id, pending_release_mbid FROM albums
|
|
WHERE pending_release_mbid IS NOT NULL AND pending_release_mbid != ''
|
|
AND (mbid IS NULL OR mbid = '');
|
|
|
|
-- name: DeleteAlbum :exec
|
|
DELETE FROM albums WHERE id = ?;
|
|
|
|
-- name: DeleteAllAlbums :exec
|
|
DELETE FROM albums;
|
|
|
|
-- name: GetEmptyAlbumIDs :many
|
|
-- Albums with no file left behind them. Under the old schema this was
|
|
-- one of three orphan sweeps that had to run by hand and did not;
|
|
-- audio_files is the only thing that can leave an album empty now, so
|
|
-- this is the whole of it.
|
|
SELECT id FROM albums al
|
|
WHERE NOT EXISTS (
|
|
SELECT 1 FROM audio_files af WHERE af.album_id = al.id
|
|
);
|
|
|
|
-- name: GetAlbums :many
|
|
SELECT
|
|
al.id,
|
|
al.name,
|
|
COALESCE(al.original_year, al.year) AS year,
|
|
COALESCE(al.year, 0) AS release_year,
|
|
al.mbid,
|
|
al.artist_credit AS artist_name,
|
|
CAST(COALESCE(ar.mbid, '') AS TEXT) AS artist_mbid,
|
|
COALESCE(ca.file_path, '') AS cover_art_path
|
|
FROM albums al
|
|
LEFT JOIN artists ar ON ar.id = al.artist_id
|
|
LEFT JOIN cover_art ca ON ca.id = al.cover_art_id
|
|
WHERE EXISTS (
|
|
SELECT 1 FROM audio_files af
|
|
WHERE af.album_id = al.id
|
|
AND af.library_id = COALESCE(NULLIF(CAST(sqlc.arg(library_id) AS INTEGER), 0), af.library_id)
|
|
)
|
|
ORDER BY al.name;
|
|
|
|
-- name: GetAlbumsByArtistName :many
|
|
SELECT
|
|
al.id,
|
|
al.name,
|
|
COALESCE(al.original_year, al.year) AS year,
|
|
COALESCE(al.year, 0) AS release_year,
|
|
al.mbid,
|
|
al.artist_credit AS artist_name,
|
|
CAST(COALESCE(ar.mbid, '') AS TEXT) AS artist_mbid,
|
|
COALESCE(ca.file_path, '') AS cover_art_path
|
|
FROM albums al
|
|
LEFT JOIN artists ar ON ar.id = al.artist_id
|
|
LEFT JOIN cover_art ca ON ca.id = al.cover_art_id
|
|
WHERE (al.artist_credit = sqlc.arg(artist) OR ar.name = sqlc.arg(artist))
|
|
AND EXISTS (
|
|
SELECT 1 FROM audio_files af
|
|
WHERE af.album_id = al.id
|
|
AND af.library_id = COALESCE(NULLIF(CAST(sqlc.arg(library_id) AS INTEGER), 0), af.library_id)
|
|
)
|
|
ORDER BY year, al.name;
|
|
|
|
-- name: GetAlbumCompleteness :one
|
|
-- "Do I have all of this album", answered from the tags on disk.
|
|
--
|
|
-- The expectation is a **sum over discs**, not one number: totals are
|
|
-- declared per disc ("5/12" on disc 2 means 12 tracks on disc 2), so a
|
|
-- multi-disc album's expectation is the sum of each disc's declared
|
|
-- total. A disc whose files declared nothing leaves the whole album
|
|
-- unknowable rather than being covered by the discs that did -- which is
|
|
-- what `known` reports.
|
|
--
|
|
-- Owned counts DISTINCT track numbers: this app detects duplicates, and
|
|
-- counting two files of track 3 twice would report a short album as
|
|
-- complete.
|
|
SELECT
|
|
-- Distinct (disc, track) pairs: this app detects duplicates, and
|
|
-- counting two files of track 3 twice would report a short album as
|
|
-- complete. A file with no track number falls back to its own id,
|
|
-- because three untagged files are three tracks, not one.
|
|
CAST(COUNT(DISTINCT CAST(COALESCE(a.disc_number, 1) AS TEXT) || ':' ||
|
|
COALESCE(CAST(a.track_number AS TEXT), 'f' || a.id)
|
|
) AS INTEGER) AS owned,
|
|
CAST(COALESCE((
|
|
SELECT SUM(per_disc.total)
|
|
FROM (
|
|
SELECT MAX(b.total_tracks) AS total
|
|
FROM audio_files b
|
|
WHERE b.album_id = sqlc.arg(album_id) AND b.total_tracks IS NOT NULL
|
|
GROUP BY COALESCE(b.disc_number, 1)
|
|
) per_disc
|
|
), 0) AS INTEGER) AS expected,
|
|
CAST((
|
|
SELECT COUNT(*) = 0 FROM audio_files c
|
|
WHERE c.album_id = sqlc.arg(album_id) AND c.total_tracks IS NULL
|
|
) AS INTEGER) AS known
|
|
FROM audio_files a
|
|
WHERE a.album_id = sqlc.arg(album_id);
|