Phases 2 and 3 of plan 009, plus the parts of phase 1 that could not
land before them. Nothing in the tree imports wails/v2 any more; all
three lint and test configurations are green and `go build .` produces
a running binary.
The point of the migration is one file. backend/events/emit.go probed
ctx.Value("events") — a v2-*private* context key — to decide whether
emitting was safe, because runtime.EventsEmit called log.Fatalf on a
context without the runtime and took the process down with it. v3's
emit takes no context, so that is now application.Get() == nil. D1
held: events.Emit keeps its ctx as the WithSink test seam, and all 45
call sites and 7 test files are untouched.
The bootstrap splits into application.New + Window.NewWithOptions +
Run. Ten bound services implement ServiceStartup instead of being
handed a context by hand from OnStartup, which also stops ten
SetContext methods being exported as bindings. jobs.Registry and
explore.SearchIndex keep theirs — neither is bound, so converting them
would be churn for no binding removed.
Four things differed from the plan and are written up in it: GPU policy
moved to the per-window LinuxWindow options rather than surviving on
LinuxOptions; there is no OnStartup/OnDomReady option, so app-level
wiring hangs off ApplicationStarted; application.NewService is generic,
so FEBindings []any could not survive (the binding generator is a
static analyser and would have seen nothing); and the quit veto had to
be restructured, because v3's dialog answers on a callback rather than
returning the button, so ShouldQuit vetoes, asks, and quits again from
the callback.
Window state saving moves to a WindowClosing hook — the size has to be
read while the window still exists, and v3's OnShutdown has neither
context nor window. backend/logging is deleted rather than ported:
v3 takes a *slog.Logger directly, so the v2 logger.Logger adapter had
no caller left.
Phase 1's tail rides along, now that it can: the Makefile's wails
invocations, all 50 webkit2_41 sites, lefthook, both packaging recipes
and ci.yml's apt lists. v3 builds against GTK4 + WebKitGTK 6.0, which
Arch and ubuntu:24.04 both ship, so the tag is a deletion rather than
a translation.
Phase 4 is next and the branch is not usable until it lands: the app
builds, but frontend/wailsjs/ is v2's tree and nothing regenerates it,
so the frontend cannot reach the backend yet.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDCbcCZQepnpSQYJ6SxxZm
202 lines
4.9 KiB
Go
202 lines
4.9 KiB
Go
package playlist
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"log/slog"
|
|
"testing"
|
|
|
|
"github.com/wailsapp/wails/v3/pkg/application"
|
|
|
|
"yellowjacket/backend/database"
|
|
"yellowjacket/backend/events"
|
|
)
|
|
|
|
// stubLibraryDir satisfies LibraryDirProvider.
|
|
type stubLibraryDir struct{ dir string }
|
|
|
|
func (s stubLibraryDir) GetLibraryDirectory() string { return s.dir }
|
|
|
|
// setupRecordedService builds a playlist service on an in-memory DB
|
|
// that writes its M3U8 files to a temp directory and records the events
|
|
// it would push to the frontend.
|
|
func setupRecordedService(
|
|
t *testing.T,
|
|
) (*Service, *database.DB, *events.Recorder) {
|
|
t.Helper()
|
|
|
|
db := database.NewTestDB(t)
|
|
libDir := t.TempDir()
|
|
|
|
svc := NewService(slog.Default(), db, stubLibraryDir{dir: libDir})
|
|
svc.dataDirOverride = t.TempDir()
|
|
|
|
rec := events.NewRecorder()
|
|
_ = svc.ServiceStartup(events.WithSink(context.Background(), rec), application.ServiceOptions{})
|
|
|
|
return svc, db, rec
|
|
}
|
|
|
|
// seedPlaylistTracks inserts `count` audio_file rows and returns their
|
|
// paths.
|
|
func seedPlaylistTracks(t *testing.T, db *database.DB, count int) []string {
|
|
t.Helper()
|
|
|
|
_, err := db.ExecContext(
|
|
"INSERT OR IGNORE INTO artist_credit (id, text) VALUES (1, 'Test Artist')",
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("insert artist_credit: %v", err)
|
|
}
|
|
|
|
paths := make([]string, count)
|
|
|
|
for i := range count {
|
|
id := i + 1
|
|
paths[i] = fmt.Sprintf("/test/pl-track%d.mp3", id)
|
|
|
|
if _, err := db.ExecContext(
|
|
"INSERT OR IGNORE INTO recordings (id, name, artist_credit_id) "+
|
|
"VALUES (?, ?, 1)",
|
|
id, fmt.Sprintf("Track %d", id),
|
|
); err != nil {
|
|
t.Fatalf("insert recording %d: %v", id, err)
|
|
}
|
|
|
|
if _, err := db.ExecContext(
|
|
"INSERT OR IGNORE INTO audio_files (id, file_path, "+
|
|
"length_milliseconds, file_type_id, recording_id) "+
|
|
"VALUES (?, ?, 180000, 0, ?)",
|
|
id, paths[i], id,
|
|
); err != nil {
|
|
t.Fatalf("insert audio_file %d: %v", id, err)
|
|
}
|
|
}
|
|
|
|
return paths
|
|
}
|
|
|
|
func TestEmit_CreatePlaylistAnnouncesTheNewRow(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
svc, _, rec := setupRecordedService(t)
|
|
|
|
created, err := svc.CreatePlaylist("Road Trip")
|
|
if err != nil {
|
|
t.Fatalf("CreatePlaylist: %v", err)
|
|
}
|
|
|
|
ev, ok := rec.Last(events.PlaylistCreated)
|
|
if !ok {
|
|
t.Fatalf("no PlaylistCreated; got %v", rec.Names())
|
|
}
|
|
|
|
summary, ok := ev.Payload().(Summary)
|
|
if !ok {
|
|
t.Fatalf("payload is %T, want playlist.Summary", ev.Payload())
|
|
}
|
|
|
|
// The frontend adds the sidebar entry straight from this payload
|
|
// rather than re-fetching, so an empty field here is a blank row.
|
|
if summary.ID != created.ID {
|
|
t.Errorf("emitted ID %d, want %d", summary.ID, created.ID)
|
|
}
|
|
|
|
if summary.Name != "Road Trip" {
|
|
t.Errorf("emitted name %q, want Road Trip", summary.Name)
|
|
}
|
|
|
|
if summary.CreatedAt == "" || summary.UpdatedAt == "" {
|
|
t.Errorf("emitted empty timestamps: %+v", summary)
|
|
}
|
|
}
|
|
|
|
func TestEmit_RejectedCreateIsSilent(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
svc, _, rec := setupRecordedService(t)
|
|
|
|
if _, err := svc.CreatePlaylist(" "); err == nil {
|
|
t.Fatal("CreatePlaylist accepted a blank name")
|
|
}
|
|
|
|
if got := rec.Count(events.PlaylistCreated); got != 0 {
|
|
t.Errorf("emitted %d PlaylistCreated for a rejected create, want 0", got)
|
|
}
|
|
}
|
|
|
|
// TestEmit_TracksChangedFiresAfterTheWriteIsVisible is the reason this
|
|
// package is worth covering as well as queue: the frontend re-reads the
|
|
// playlist when it sees PlaylistTracksChanged, so an event emitted
|
|
// before the rows were committed would have it read the old contents.
|
|
func TestEmit_TracksChangedFiresAfterTheWriteIsVisible(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
svc, db, rec := setupRecordedService(t)
|
|
paths := seedPlaylistTracks(t, db, 3)
|
|
|
|
created, err := svc.CreatePlaylist("Mix")
|
|
if err != nil {
|
|
t.Fatalf("CreatePlaylist: %v", err)
|
|
}
|
|
|
|
rec.Reset()
|
|
|
|
if err := svc.AddTracksToPlaylist(created.ID, paths); err != nil {
|
|
t.Fatalf("AddTracksToPlaylist: %v", err)
|
|
}
|
|
|
|
ev, ok := rec.Last(events.PlaylistTracksChanged)
|
|
if !ok {
|
|
t.Fatalf("no PlaylistTracksChanged; got %v", rec.Names())
|
|
}
|
|
|
|
id, ok := ev.Payload().(int64)
|
|
if !ok {
|
|
t.Fatalf("payload is %T, want int64", ev.Payload())
|
|
}
|
|
|
|
if id != created.ID {
|
|
t.Errorf("emitted playlist ID %d, want %d", id, created.ID)
|
|
}
|
|
|
|
// Read back the way the frontend would on receipt of the event.
|
|
tracks, err := svc.GetPlaylistTracks(created.ID)
|
|
if err != nil {
|
|
t.Fatalf("GetPlaylistTracks: %v", err)
|
|
}
|
|
|
|
if len(tracks) != len(paths) {
|
|
t.Errorf(
|
|
"a frontend reacting to the event reads %d tracks, want %d",
|
|
len(tracks), len(paths),
|
|
)
|
|
}
|
|
}
|
|
|
|
func TestEmit_DeletePlaylistAnnouncesTheID(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
svc, _, rec := setupRecordedService(t)
|
|
|
|
created, err := svc.CreatePlaylist("Temp")
|
|
if err != nil {
|
|
t.Fatalf("CreatePlaylist: %v", err)
|
|
}
|
|
|
|
rec.Reset()
|
|
|
|
if err := svc.DeletePlaylist(created.ID); err != nil {
|
|
t.Fatalf("DeletePlaylist: %v", err)
|
|
}
|
|
|
|
ev, ok := rec.Last(events.PlaylistDeleted)
|
|
if !ok {
|
|
t.Fatalf("no PlaylistDeleted; got %v", rec.Names())
|
|
}
|
|
|
|
if id, _ := ev.Payload().(int64); id != created.ID {
|
|
t.Errorf("emitted ID %v, want %d", ev.Payload(), created.ID)
|
|
}
|
|
}
|