Files
yellowjacket/backend/queue/playbackfailed_test.go
T
logan df11ef23f4 feat(player): report the real position, and skip an unplayable track
The seek bar was a setInterval counter reconciled only on track
change: measured 3 s behind during steady playback and 30 s behind
after four keyboard seeks, because the seek shortcut never told it.
And `loadCurrentTrack`/`playCurrentTrack` logged, returned false and
emitted nothing, so double-clicking a moved file did nothing, twice,
forever — while auto-advance onto a bad file stopped playback dead.

- A 1 Hz position ticker while playing, plus an immediate report on
  load, play, pause, seek and natural finish. The payload carries a
  `trackChangeId` (the store is a singleton, so a bar mounting later
  must not adopt a report about the previous track) and a `seq` (the
  same second reported twice still has to reset interpolation).
- `PlaybackFailed` from both failure paths, and `playCurrentOrSkip`
  steps over tracks that will not load — bounded by the queue length,
  so a disconnected drive stops after one pass instead of spinning
  through a RepeatAll wrap. `PlayIndex` still reverts: the user picked
  that track.
- `SeekFailed` is emitted when the seek itself fails, not only when
  nothing is loaded, and is followed by a position report so the
  optimistic move is taken back by the mechanism that fixed the drift.
- A queue that simply ran out no longer unloads the player, so the
  finished track stays on the bar at 0:00.
2026-08-12 01:17:54 -04:00

214 lines
4.8 KiB
Go

package queue
import (
"context"
"errors"
"log/slog"
"testing"
"yellowjacket/backend/database"
"yellowjacket/backend/events"
)
var errFileMissing = errors.New("no such file or directory")
// failingLoader is a TrackLoader that refuses to load a named set of
// paths — a moved file, in other words, which is the whole of
// errors.C1.
type failingLoader struct {
mockTrackLoader
fails map[string]bool
unloaded int
}
func (f *failingLoader) LoadFile(filePath string) error {
if f.fails[filePath] {
return errFileMissing
}
return f.mockTrackLoader.LoadFile(filePath)
}
func (f *failingLoader) UnloadTrack() { f.unloaded++ }
// setupFailingQueue is setupRecordedQueue with a loader that fails on
// the given paths.
func setupFailingQueue(
t *testing.T,
) (*Queue, *database.DB, *events.Recorder, *failingLoader) {
t.Helper()
db := database.NewTestDB(t)
q := NewQueue(slog.Default(), db)
loader := &failingLoader{fails: map[string]bool{}}
q.SetPlayer(loader)
rec := events.NewRecorder()
q.SetContext(events.WithSink(context.Background(), rec))
return q, db, rec, loader
}
// failureOf returns the payload of the most recent PlaybackFailed.
func failureOf(t *testing.T, rec *events.Recorder) PlaybackFailure {
t.Helper()
ev, ok := rec.Last(events.PlaybackFailed)
if !ok {
t.Fatalf("no PlaybackFailed emitted; got %v", rec.Names())
}
failure, ok := ev.Payload().(PlaybackFailure)
if !ok {
t.Fatalf(
"PlaybackFailed payload is %T, want queue.PlaybackFailure",
ev.Payload(),
)
}
return failure
}
func TestPlaybackFailed_EmittedForAMissingFile(t *testing.T) {
t.Parallel()
q, db, rec, loader := setupFailingQueue(t)
paths := seedAudioFiles(t, db, 3)
loader.fails[paths[1]] = true
q.SetQueue(paths, 0, false)
q.PlayIndex(1)
failure := failureOf(t, rec)
if failure.FilePath != paths[1] {
t.Errorf("filePath: got %q, want %q", failure.FilePath, paths[1])
}
if failure.Reason == "" {
t.Error("reason is empty; the frontend has nothing to log")
}
if failure.Title == "" {
t.Error("title is empty; a message cannot name the track")
}
}
func TestPlaybackFailed_AutoAdvanceSkipsPastIt(t *testing.T) {
t.Parallel()
q, db, rec, loader := setupFailingQueue(t)
paths := seedAudioFiles(t, db, 3)
loader.fails[paths[1]] = true
q.SetQueue(paths, 0, false)
q.Play()
// The first track finished: auto-advance lands on the missing
// file and must step over it rather than stopping dead.
q.OnPlaybackFinished()
if got := q.GetState().CurrentIndex; got != 2 {
t.Errorf("currentIndex after skipping: got %d, want 2", got)
}
if _, ok := rec.Last(events.PlaybackFailed); !ok {
t.Errorf("skipped silently; events were %v", rec.Names())
}
}
func TestPlaybackFailed_NextSkipsPastIt(t *testing.T) {
t.Parallel()
q, db, _, loader := setupFailingQueue(t)
paths := seedAudioFiles(t, db, 4)
loader.fails[paths[1]] = true
loader.fails[paths[2]] = true
q.SetQueue(paths, 0, false)
q.Next()
if got := q.GetState().CurrentIndex; got != 3 {
t.Errorf(
"currentIndex after two unplayable tracks: got %d, want 3",
got,
)
}
}
func TestPlaybackFailed_WholeQueueUnplayableStopsOnce(t *testing.T) {
t.Parallel()
q, db, rec, loader := setupFailingQueue(t)
paths := seedAudioFiles(t, db, 3)
for _, p := range paths {
loader.fails[p] = true
}
q.SetQueue(paths, 0, false)
q.repeatMode = RepeatAll
rec.Reset()
q.Next()
// Every file is gone (a disconnected drive). One pass, then
// stop — not an endless wrap around a RepeatAll queue.
if got := q.GetState().CurrentIndex; got != -1 {
t.Errorf("currentIndex: got %d, want -1 (exhausted)", got)
}
if got := rec.Count(events.PlaybackFailed); got != len(paths) {
t.Errorf(
"PlaybackFailed count: got %d, want %d (one pass)",
got, len(paths),
)
}
if loader.unloaded != 0 {
t.Errorf(
"player unloaded %d times; the finished track should stay "+
"on the now-playing bar",
loader.unloaded,
)
}
}
func TestQueueExhausted_KeepsTheFinishedTrackLoaded(t *testing.T) {
t.Parallel()
q, db, _, loader := setupFailingQueue(t)
paths := seedAudioFiles(t, db, 1)
q.SetQueue(paths, 0, false)
q.Play()
q.OnPlaybackFinished()
if q.GetState().CurrentIndex != -1 {
t.Errorf(
"currentIndex: got %d, want -1",
q.GetState().CurrentIndex,
)
}
// H-18: the bar used to blank while the queue panel still listed
// what had just played.
if loader.unloaded != 0 {
t.Errorf("player unloaded %d times, want 0", loader.unloaded)
}
}
func TestQueueExhausted_UnloadsWhenTheTrackIsRemoved(t *testing.T) {
t.Parallel()
q, db, _, loader := setupFailingQueue(t)
paths := seedAudioFiles(t, db, 1)
q.SetQueue(paths, 0, false)
q.RemoveTrack(0)
// Nothing left to show, so the bar clears.
if loader.unloaded == 0 {
t.Error("player not unloaded after its track left the queue")
}
}