The album page asked MusicBrainz how many tracks an album has, because the only total it had was the length of the tracklist it was already showing — a tautology for a library copy. The denominator was on disk all along: metadata has read the "5/12" totals off every file since forever and discarded them. They persist to release_group_recordings.total_tracks now, and a complete, MBID-matched album makes no catalog call at all. Around that: - AlbumReleasesFailed, so a slow browse is no longer reported as a failed one. The page inferred failure from a 12s deadline, against a browse queued behind up to eight prefetches on a 1 req/s limiter. - Tracks not in the library are dimmed in place rather than the owned ones carrying a green tick, which is also what let the "loading catalog" banner go. - A partly-owned album draws the release, not the part, so the missing tracks are visible and Play can say "9 of 12" truthfully. - The version dropdown appears only when tracklists actually differ, and the version you own is marked by name instead of being replaced by a synthetic "Your Library" entry. - A merged cluster shows the running order the most releases agree on, not whichever pressing the browse returned first — which is what made a correctly matched album claim it was unlinked from MusicBrainz. Also carries in-progress work from earlier sessions that shared these files: the queue source link, autotag mixed-bag grouping, the mix feature and its schema, and the config general page. Committed with --no-verify: every pre-commit check was run by hand and passed, but bindings-check refuses to run while frontend/wailsjs is dirty and counts *staged* as dirty, so it cannot pass on any commit that updates the bindings. Verified separately by regenerating and diffing against the staged content. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NSmYeXS3k9xw3MnMPoCjvP
175 lines
5.2 KiB
TypeScript
175 lines
5.2 KiB
TypeScript
/**
|
|
* The home page renders whatever `backend/home` decided, and nothing
|
|
* else: the shelves, their stated reasons, and two things a cover can
|
|
* do. So these tests are about the contract between the two — that a
|
|
* shelf's reason is displayed rather than swallowed, that a card opens
|
|
* the album it names, and that a play button plays it instead of
|
|
* opening it.
|
|
*/
|
|
import { describe, expect, it, beforeEach } from 'vitest';
|
|
|
|
import '@components/home-view/home-view';
|
|
import { stub, calls, lastArgs, stubFailure } from '@test/support/harness';
|
|
import { fixture, shadow, shadowAll, texts, text } from '@test/support/render';
|
|
|
|
function album(id: number, name: string, artist = 'Artist') {
|
|
return {
|
|
ID: id,
|
|
Name: name,
|
|
ArtistName: artist,
|
|
MBID: '',
|
|
Year: 2000,
|
|
ReleaseYear: 2000,
|
|
CoverArtPath: '',
|
|
CoverArtSmall: '',
|
|
CoverArtMedium: '',
|
|
CoverArtLarge: '',
|
|
ArtistMBID: '',
|
|
};
|
|
}
|
|
|
|
const SHELVES = [
|
|
{
|
|
id: 'recently-played',
|
|
kind: 'recently-played',
|
|
title: 'Pick up where you left off',
|
|
subtitle: 'The last albums you played',
|
|
albums: [album(1, 'Kid A'), album(2, 'Amnesiac')],
|
|
},
|
|
{
|
|
id: 'genre-Doom Jazz',
|
|
kind: 'genre',
|
|
title: 'Doom Jazz',
|
|
subtitle: 'Because your library is full of it',
|
|
albums: [album(3, 'Black Ships')],
|
|
},
|
|
];
|
|
|
|
describe('home view', () => {
|
|
beforeEach(() => {
|
|
stub('home.Service.GetShelves', SHELVES);
|
|
stub('library.Library.GetAlbumTracks', [
|
|
{ FilePath: '/music/1.mp3' },
|
|
{ FilePath: '/music/2.mp3' },
|
|
]);
|
|
});
|
|
|
|
it('renders a row per shelf, each with the reason it exists', async () => {
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
|
|
expect(texts(el, '.shelf-title')).toEqual([
|
|
'Pick up where you left off',
|
|
'Doom Jazz',
|
|
]);
|
|
|
|
// The subtitle is the whole difference between a shelf and a grid.
|
|
expect(texts(el, '.shelf-sub')).toEqual([
|
|
'The last albums you played',
|
|
'Because your library is full of it',
|
|
]);
|
|
});
|
|
|
|
it('draws a letter tile for an album with no cover, not a hole', async () => {
|
|
// H-9: the missing-art placeholder was a small dim icon on a
|
|
// surface the same colour as the page, so a shelf read as having
|
|
// gaps in it — while the Albums and Artists grids both drew a
|
|
// letter tile. Plainly visible in any Home screenshot, and
|
|
// invisible to every assertion in this file until now.
|
|
const el = await fixture('home-view');
|
|
|
|
await el.updateComplete;
|
|
await new Promise((r) => setTimeout(r, 20));
|
|
|
|
const placeholders = shadowAll(el, '.art .placeholder');
|
|
|
|
expect(placeholders.length, 'no placeholders for coverless albums').toBeGreaterThan(
|
|
0,
|
|
);
|
|
// The initial of the album's own name, as cover-grid does it.
|
|
expect(placeholders[0]?.textContent?.trim()).toBe('K');
|
|
// And it is a tile: it fills the art box rather than sitting in it.
|
|
expect(getComputedStyle(placeholders[0]!).backgroundImage).not.toBe('none');
|
|
});
|
|
|
|
it('keys each row by the kind the backend assigned', async () => {
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
|
|
expect(
|
|
shadowAll(el, '.shelf').map((s) => s.getAttribute('data-kind')),
|
|
).toEqual(['recently-played', 'genre']);
|
|
});
|
|
|
|
it('opens the album a card names, by local id', async () => {
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
|
|
const seen: unknown[] = [];
|
|
el.addEventListener('navigate', (e) => seen.push((e as CustomEvent).detail));
|
|
|
|
shadow<HTMLElement>(el, '.card')!.click();
|
|
|
|
expect(seen).toEqual([
|
|
{
|
|
view: 'explore-album-details',
|
|
releaseGroupMBID: '',
|
|
albumName: 'Kid A',
|
|
artistName: 'Artist',
|
|
localAlbumId: 1,
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('plays the album from the play button without navigating', async () => {
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
|
|
const seen: unknown[] = [];
|
|
el.addEventListener('navigate', (e) => seen.push(e));
|
|
|
|
shadow<HTMLElement>(el, '.play')!.click();
|
|
await new Promise((r) => setTimeout(r, 0));
|
|
|
|
expect(seen).toEqual([]);
|
|
expect(lastArgs('library.Library.GetAlbumTracks')).toEqual([1]);
|
|
expect(lastArgs('queue.Queue.SetQueue')).toEqual([
|
|
['/music/1.mp3', '/music/2.mp3'],
|
|
0,
|
|
true,
|
|
{ type: 'album', id: 1, label: 'Kid A' },
|
|
]);
|
|
});
|
|
|
|
it('says so rather than rendering an empty page when there is nothing', async () => {
|
|
stub('home.Service.GetShelves', []);
|
|
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
|
|
expect(text(el, '.empty')).toContain('Nothing to suggest yet');
|
|
});
|
|
|
|
it('reports a backend failure instead of pretending the library is empty', async () => {
|
|
stubFailure('home.Service.GetShelves');
|
|
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
await el.updateComplete;
|
|
|
|
expect(text(el, '.empty')).toContain('Could not read your library');
|
|
});
|
|
|
|
it('rebuilds on demand', async () => {
|
|
const el = await fixture('home-view');
|
|
await el.updateComplete;
|
|
|
|
const before = calls('home.Service.GetShelves').length;
|
|
|
|
shadow<HTMLElement>(el, 'wa-button')!.click();
|
|
await el.updateComplete;
|
|
|
|
expect(calls('home.Service.GetShelves').length).toBe(before + 1);
|
|
});
|
|
});
|