Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
179 lines
5.7 KiB
TypeScript
179 lines
5.7 KiB
TypeScript
/**
|
|
* Every custom element in the tree, mounted against an empty backend.
|
|
*
|
|
* This is deliberately shallow: it asserts each component renders
|
|
* *something* and logs no error, which is the state an agent's change
|
|
* most often breaks and which nothing else here would notice. Depth
|
|
* belongs in the per-component specs and in e2e; breadth belongs here,
|
|
* because 46 elements is more than anyone will write specs for.
|
|
*/
|
|
import { describe, expect, it, beforeEach, afterEach, vi } from 'vitest';
|
|
|
|
// One import per component module, so a component that fails to even
|
|
// load is a failure here rather than a silent absence.
|
|
import '@components/artist-details/artist-details';
|
|
import '@components/artists-view/artists-view';
|
|
import '@components/audio-player/audio-player';
|
|
import '@components/audio-player/controls/player-controls';
|
|
import '@components/audio-player/seekbar/seek-bar';
|
|
import '@components/audio-player/volume-control/volume-control';
|
|
import '@components/autotag-view/autotag-view';
|
|
import '@components/combobox/combobox';
|
|
import '@components/config-page/config-page';
|
|
import '@components/config-page/config-field';
|
|
import '@components/config-page/config-section';
|
|
import '@components/config-page/download-clients';
|
|
import '@components/config-page/shortcut-capture';
|
|
import '@components/cover-grid/cover-grid';
|
|
import '@components/cover-grid/album-dropdown';
|
|
import '@components/download-picker/download-picker';
|
|
import '@components/download-picker/candidate-row';
|
|
import '@components/downloads-view/downloads-view';
|
|
import '@components/duplicate-tracks-dialog/duplicate-tracks-dialog';
|
|
import '@components/explore-album-details/explore-album-details';
|
|
import '@components/explore-artist-details/explore-artist-details';
|
|
import '@components/explore-view/explore-view';
|
|
import '@components/first-run-wizard/first-run-wizard';
|
|
import '@components/genre-details/genre-details';
|
|
import '@components/genres-view/genres-view';
|
|
import '@components/jobs/job-details-drawer';
|
|
import '@components/jobs/job-indicator';
|
|
import '@components/jobs/job-log-view';
|
|
import '@components/jobs/job-row';
|
|
import '@components/jobs/jobs-view';
|
|
import '@components/library-filter/library-filter';
|
|
import '@components/library-status-indicator/library-status-indicator';
|
|
import '@components/now-playing/now-playing';
|
|
import '@components/phantom-resolver/phantom-resolver';
|
|
import '@components/playlist-details/playlist-details';
|
|
import '@components/playlist-picker/playlist-picker';
|
|
import '@components/playlist-view/playlist-view';
|
|
import '@components/queue-panel/queue-panel';
|
|
import '@components/search-bar/search-bar';
|
|
import '@components/sidebar/app-sidebar';
|
|
import '@components/smart-playlist-details/smart-playlist-details';
|
|
import '@components/smart-playlist-editor/smart-playlist-editor';
|
|
import '@components/top-results-row/top-results-row';
|
|
import '@components/track-details/track-details';
|
|
import '@components/track-info/track-info';
|
|
import '@components/track-list/track-list';
|
|
|
|
import { flush, stub } from '@test/support/harness';
|
|
import { fixture } from '@test/support/render';
|
|
|
|
/** Every element the app registers, in registration order. */
|
|
const TAGS = [
|
|
'album-dropdown',
|
|
'app-sidebar',
|
|
'artist-details',
|
|
'artists-view',
|
|
'audio-player',
|
|
'autotag-view',
|
|
'candidate-row',
|
|
'config-field',
|
|
'config-page',
|
|
'config-section',
|
|
'cover-grid',
|
|
'download-clients',
|
|
'download-picker',
|
|
'downloads-view',
|
|
'duplicate-tracks-dialog',
|
|
'explore-album-details',
|
|
'explore-artist-details',
|
|
'explore-view',
|
|
'first-run-wizard',
|
|
'genre-details',
|
|
'genres-view',
|
|
'job-details-drawer',
|
|
'job-indicator',
|
|
'job-log-view',
|
|
'job-row',
|
|
'jobs-view',
|
|
'library-filter',
|
|
'library-status-indicator',
|
|
'now-playing',
|
|
'phantom-resolver',
|
|
'player-controls',
|
|
'playlist-details',
|
|
'playlist-picker',
|
|
'playlist-view',
|
|
'queue-panel',
|
|
'search-bar',
|
|
'seek-bar',
|
|
'shortcut-capture',
|
|
'smart-playlist-details',
|
|
'smart-playlist-editor',
|
|
'top-results-row',
|
|
'track-details',
|
|
'track-info',
|
|
'track-list',
|
|
'volume-control',
|
|
'yj-combobox',
|
|
];
|
|
|
|
/**
|
|
* An empty-but-valid backend. Unstubbed bindings resolve undefined,
|
|
* which is not what Go sends — an empty list is.
|
|
*/
|
|
function stubEmptyBackend(): void {
|
|
const emptyLists = [
|
|
'library.Library.GetTracks',
|
|
'library.Library.GetAlbums',
|
|
'library.Library.GetArtists',
|
|
'library.Library.GetGenres',
|
|
'library.Library.GetAllLibrariesWithTrackCounts',
|
|
'playlist.Service.GetAllPlaylists',
|
|
'playlist.Service.GetAllPlaylistsWithTracks',
|
|
'playlist.Service.GetDefaultPlaylistTrackPaths',
|
|
'jobs.Service.GetJobs',
|
|
'download.Service.ListProviders',
|
|
'download.Service.ListDownloads',
|
|
'download.Service.ListRequests',
|
|
'download.Service.ProviderKinds',
|
|
];
|
|
|
|
for (const path of emptyLists) stub(path, []);
|
|
|
|
stub('config.Config.GetShortcuts', {});
|
|
stub('config.Config.GetDownloadPreferences', {});
|
|
stub('config.Config.GetThemeAccentColor', '#ffd43b');
|
|
stub('config.Config.GetThemeBackgroundShade', 'dark');
|
|
}
|
|
|
|
describe('every component mounts on an empty library', () => {
|
|
let errors: unknown[][] = [];
|
|
|
|
beforeEach(() => {
|
|
stubEmptyBackend();
|
|
errors = [];
|
|
vi.spyOn(console, 'error').mockImplementation((...args: unknown[]) => {
|
|
errors.push(args);
|
|
});
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it('registers every element it defines', () => {
|
|
const missing = TAGS.filter((tag) => !customElements.get(tag));
|
|
|
|
expect(missing).toEqual([]);
|
|
});
|
|
|
|
for (const tag of TAGS) {
|
|
it(`<${tag}> renders without logging an error`, async () => {
|
|
const el = await fixture(tag);
|
|
|
|
await flush();
|
|
await el.updateComplete;
|
|
|
|
expect({ tag, root: el.shadowRoot !== null, errors }).toEqual({
|
|
tag,
|
|
root: true,
|
|
errors: [],
|
|
});
|
|
});
|
|
}
|
|
});
|