Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
205 lines
5.1 KiB
Go
205 lines
5.1 KiB
Go
// Code generated by sqlc. DO NOT EDIT.
|
|
// versions:
|
|
// sqlc v1.30.0
|
|
// source: artists.sql
|
|
|
|
package sqlcgen
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
)
|
|
|
|
const deleteAllArtists = `-- name: DeleteAllArtists :exec
|
|
DELETE FROM artists
|
|
`
|
|
|
|
func (q *Queries) DeleteAllArtists(ctx context.Context) error {
|
|
_, err := q.db.ExecContext(ctx, deleteAllArtists)
|
|
return err
|
|
}
|
|
|
|
const deleteArtist = `-- name: DeleteArtist :exec
|
|
DELETE FROM artists WHERE id = ?
|
|
`
|
|
|
|
func (q *Queries) DeleteArtist(ctx context.Context, id int64) error {
|
|
_, err := q.db.ExecContext(ctx, deleteArtist, id)
|
|
return err
|
|
}
|
|
|
|
const getAlbumArtists = `-- name: GetAlbumArtists :many
|
|
SELECT DISTINCT a.id, a.name, a.mbid
|
|
FROM artists a
|
|
JOIN albums al ON al.artist_id = a.id
|
|
WHERE EXISTS (
|
|
SELECT 1 FROM audio_files af
|
|
WHERE af.album_id = al.id
|
|
AND af.library_id = COALESCE(NULLIF(CAST(?1 AS INTEGER), 0), af.library_id)
|
|
)
|
|
ORDER BY a.name
|
|
`
|
|
|
|
func (q *Queries) GetAlbumArtists(ctx context.Context, libraryID int64) ([]Artist, error) {
|
|
rows, err := q.db.QueryContext(ctx, getAlbumArtists, libraryID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer rows.Close()
|
|
var items []Artist
|
|
for rows.Next() {
|
|
var i Artist
|
|
if err := rows.Scan(&i.ID, &i.Name, &i.Mbid); err != nil {
|
|
return nil, err
|
|
}
|
|
items = append(items, i)
|
|
}
|
|
if err := rows.Close(); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
return items, nil
|
|
}
|
|
|
|
const getAllArtists = `-- name: GetAllArtists :many
|
|
SELECT id, name, mbid FROM artists ORDER BY name
|
|
`
|
|
|
|
func (q *Queries) GetAllArtists(ctx context.Context) ([]Artist, error) {
|
|
rows, err := q.db.QueryContext(ctx, getAllArtists)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer rows.Close()
|
|
var items []Artist
|
|
for rows.Next() {
|
|
var i Artist
|
|
if err := rows.Scan(&i.ID, &i.Name, &i.Mbid); err != nil {
|
|
return nil, err
|
|
}
|
|
items = append(items, i)
|
|
}
|
|
if err := rows.Close(); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
return items, nil
|
|
}
|
|
|
|
const getArtist = `-- name: GetArtist :one
|
|
SELECT id, name, mbid FROM artists WHERE id = ? LIMIT 1
|
|
`
|
|
|
|
func (q *Queries) GetArtist(ctx context.Context, id int64) (Artist, error) {
|
|
row := q.db.QueryRowContext(ctx, getArtist, id)
|
|
var i Artist
|
|
err := row.Scan(&i.ID, &i.Name, &i.Mbid)
|
|
return i, err
|
|
}
|
|
|
|
const getArtistByFilePath = `-- name: GetArtistByFilePath :one
|
|
SELECT COALESCE(a.name, '') AS artist_name, COALESCE(a.mbid, '') AS artist_mbid
|
|
FROM audio_files af
|
|
LEFT JOIN artists a ON a.id = af.artist_id
|
|
WHERE af.file_path = ?
|
|
LIMIT 1
|
|
`
|
|
|
|
type GetArtistByFilePathRow struct {
|
|
ArtistName string
|
|
ArtistMbid string
|
|
}
|
|
|
|
func (q *Queries) GetArtistByFilePath(ctx context.Context, filePath string) (GetArtistByFilePathRow, error) {
|
|
row := q.db.QueryRowContext(ctx, getArtistByFilePath, filePath)
|
|
var i GetArtistByFilePathRow
|
|
err := row.Scan(&i.ArtistName, &i.ArtistMbid)
|
|
return i, err
|
|
}
|
|
|
|
const getArtistByName = `-- name: GetArtistByName :one
|
|
SELECT id, name, mbid FROM artists WHERE name = ? LIMIT 1
|
|
`
|
|
|
|
func (q *Queries) GetArtistByName(ctx context.Context, name string) (Artist, error) {
|
|
row := q.db.QueryRowContext(ctx, getArtistByName, name)
|
|
var i Artist
|
|
err := row.Scan(&i.ID, &i.Name, &i.Mbid)
|
|
return i, err
|
|
}
|
|
|
|
const getUnreferencedArtistIDs = `-- name: GetUnreferencedArtistIDs :many
|
|
SELECT id FROM artists a
|
|
WHERE NOT EXISTS (SELECT 1 FROM audio_files af WHERE af.artist_id = a.id)
|
|
AND NOT EXISTS (SELECT 1 FROM albums al WHERE al.artist_id = a.id)
|
|
`
|
|
|
|
// Artists no file and no album points at any more.
|
|
func (q *Queries) GetUnreferencedArtistIDs(ctx context.Context) ([]int64, error) {
|
|
rows, err := q.db.QueryContext(ctx, getUnreferencedArtistIDs)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer rows.Close()
|
|
var items []int64
|
|
for rows.Next() {
|
|
var id int64
|
|
if err := rows.Scan(&id); err != nil {
|
|
return nil, err
|
|
}
|
|
items = append(items, id)
|
|
}
|
|
if err := rows.Close(); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
return items, nil
|
|
}
|
|
|
|
const setArtistMBID = `-- name: SetArtistMBID :exec
|
|
UPDATE artists SET mbid = ? WHERE id = ?
|
|
`
|
|
|
|
type SetArtistMBIDParams struct {
|
|
Mbid sql.NullString
|
|
ID int64
|
|
}
|
|
|
|
func (q *Queries) SetArtistMBID(ctx context.Context, arg SetArtistMBIDParams) error {
|
|
_, err := q.db.ExecContext(ctx, setArtistMBID, arg.Mbid, arg.ID)
|
|
return err
|
|
}
|
|
|
|
const upsertArtist = `-- name: UpsertArtist :one
|
|
|
|
INSERT INTO artists (name, mbid) VALUES (?, ?)
|
|
ON CONFLICT(name) DO UPDATE SET
|
|
mbid = COALESCE(excluded.mbid, artists.mbid)
|
|
RETURNING id, name, mbid
|
|
`
|
|
|
|
type UpsertArtistParams struct {
|
|
Name string
|
|
Mbid sql.NullString
|
|
}
|
|
|
|
// Queries over artists.
|
|
//
|
|
// An artist row is reachable two ways: as a file's primary artist
|
|
// (audio_files.artist_id) and as an album's artist (albums.artist_id).
|
|
// Both used to route through artist_credit + artist_credit_artist,
|
|
// which is how "which album artists are in library 2" came to be a
|
|
// five-join subquery inside a three-join query.
|
|
func (q *Queries) UpsertArtist(ctx context.Context, arg UpsertArtistParams) (Artist, error) {
|
|
row := q.db.QueryRowContext(ctx, upsertArtist, arg.Name, arg.Mbid)
|
|
var i Artist
|
|
err := row.Scan(&i.ID, &i.Name, &i.Mbid)
|
|
return i, err
|
|
}
|