Files
yellowjacket/frontend/test/components/chrome.test.ts
T
yonluandClaude Opus 5 e7748f1fd5
CI / check (push) Successful in 3m7s
CI / e2e (push) Canceled after 1m45s
feat(database): shape the library like files, and shrink the catalog
Plans 013 and 014, the album page that prompted them, and the smaller
fixes they turned up. Changelog, largest first.

## The local library is shaped like files, not like MusicBrainz

`audio_files` carries its own tags and points at `albums` and
`artists`; `file_genres` is the one real many-to-many. `recordings`,
`release_group_recordings`, `artist_credit`, `artist_credit_artist`,
`recording_genres`, `release_groups` and `release_to_rg` are gone from
the local side, and with them a six-way join in every read, a
`MIN(release_group_id)` subquery in eleven queries and a
first-credited-artist subquery in nine. Measured on a real 25,966-file
library, every many-to-many that model expressed was 1:1 in the data.

- Ownership is a file. `GetFilePathsByRecordingMBIDs`,
  `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and
  `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812
  orphaned recordings, 216 release groups and 260 artists that library
  carried are now structurally impossible.
- One projection: every track query selects from the `track_metadata`
  view, one row type, one mapper. Nine hand-rolled copies had drifted
  far enough to report different years on different screens.
- `library_id = 0` means every library, so each list query exists once
  instead of scoped and unscoped with a branch at every call site.
- No migration chain. `sql/schemas/` is the one description of the
  shape; `sql/migrations/`, `applyMigrations` and `schema_migrations`
  are squashed away, along with the drift between them that had sqlc
  generating against a stale schema.
- `database.InsertTestTrack` is the one test seeder; twenty test files
  had been assembling the old FK chain each in its own order.

## The catalog stores its ids as bytes

`explore_index`'s three 36-char MBID columns and its entity-type text
are 16 raw bytes and a small integer. The table and its six indexes go
780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh
install is ~0.6 GB rather than ~1.0 GB.

- `backend/explore/mbid.go` is the only place the encoding is known;
  everything above it speaks dashed strings.
- `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert
  rather than silently returning no rows, since SQLite does not coerce
  between TEXT and BLOB.
- The importer asks the artifact what encoding it carries and converts
  on the way in, so the artifact already published keeps working and no
  format bump is needed.
- `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column
  list, and `TestStoredEncodingRoundTrips` sweeps every read path.

## An album page that says how much of the album is yours

- One question, asked once: is there a file. `filePaths` is filled by a
  single batched lookup when the tracklist settles, and the badge, the
  Play count, the dimmed rows and every menu item read it — replacing
  four claims of decreasing confidence that could show a green tick on
  an album whose every action did nothing.
- Play, Play 7 of 12, or no play button at all.
- `total_tracks` on `explore_index` (~2 bytes over 400,677 release
  groups) and on `audio_files` from tags that have always carried it:
  a complete MBID-matched album now makes no catalog call at all, where
  it used to spend the most expensive request the app makes.
- A merged cluster shows the running order the most releases agree on,
  and the version list marks the release you own rather than standing a
  synthetic entry in for it.
- `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed
  one by a 12-second timer.
- Rows not in the library are dimmed in place (with `aria-disabled`)
  instead of the owned ones wearing a green tick and a legend.

## Caches and cover art get ceilings

- Only the three tiers of a cover are stored; the full-resolution copy
  nothing rendered was 1,134 MB of a 1.4 GB covers directory.
- One artist portrait is downloaded and the rest are remembered as
  URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads.
- `browsedArtBudget` and `httpCacheBudget` bound what an age cannot:
  the same install held art for 5,770 artists in a 1,301-artist
  library.
- `OrphanedArtistImagesJob` joined a bare MBID onto a sharded
  directory, so it deleted the rows that were the only record of the
  files it left behind. `explore.ArtistImageDir` is that layout's one
  definition now.

## The autotag queue asks whether there is work

`tagging_items` was a row per album folder, not a queue, and no query
read the `tag_status` column that held the answer. The four queue
queries ask the files, which matters most where it is least visible:
`startPrefetch` was scoring every album in a tagged library against
MusicBrainz.

## Phantom playlist tracks resolve in place

An M3U8 imported before its files leaves phantom rows; they now match
by path and fall back to position, keep their place in the playlist
when resolved, and pair best-first so two phantoms cannot claim the
same file.

## Playing a track plays the list it is in

Double-click, and Play on a single row's menu, queue the list as
displayed with `startIndex` on that row — the album page and the track
list used to queue one track and discard the album around it. A
multi-row selection still plays exactly itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
2026-08-16 13:58:15 -04:00

285 lines
8.2 KiB
TypeScript

/**
* The app chrome: sidebar navigation, the library filter dropdown and
* the tri-state library status indicator. All three are small, all
* three are on screen constantly, and the sidebar's testids and
* aria-current are what the e2e tier navigates by.
*/
import { describe, expect, it, beforeEach, vi, afterEach } from 'vitest';
import '@components/sidebar/app-sidebar';
import '@components/library-filter/library-filter';
import '@components/library-status-indicator/library-status-indicator';
import { Events } from '../../src/events';
import { emit, stub, flush, calls, lastArgs } from '@test/support/harness';
import {
fixture,
shadow,
shadowAll,
texts,
update,
visual,
} from '@test/support/render';
describe('<app-sidebar>', () => {
it('renders a testid per destination, which is how e2e navigates', async () => {
const el = await fixture('app-sidebar');
expect(
shadowAll(el, 'li button').map((item) =>
item.getAttribute('data-testid'),
),
).toEqual([
'nav-home',
'nav-playlists',
'nav-artists',
'nav-genres',
'nav-albums',
'nav-tracks',
'nav-explore',
'nav-downloads',
'nav-autotag',
'nav-jobs',
'nav-settings',
]);
});
it('marks exactly one item as the current page', async () => {
const el = await fixture('app-sidebar');
const current = shadowAll(el, 'li button').filter(
(item) => item.getAttribute('aria-current') === 'page',
);
expect(current).toHaveLength(1);
});
it('announces a navigation as a composed event, so the shell hears it through the shadow root', async () => {
const el = await fixture('app-sidebar');
const seen: string[] = [];
document.addEventListener('navigate', (e) => {
seen.push((e as CustomEvent<{ view: string }>).detail.view);
}, { once: true });
shadow<HTMLElement>(el, '[data-testid="nav-artists"]')?.click();
await el.updateComplete;
expect(seen).toEqual(['artists']);
});
it('moves aria-current to the clicked destination', async () => {
const el = await fixture('app-sidebar');
shadow<HTMLElement>(el, '[data-testid="nav-genres"]')?.click();
await el.updateComplete;
expect(
shadow(el, '[data-testid="nav-genres"]')?.getAttribute('aria-current'),
).toBe('page');
});
it('looks the way it did last time', async () => {
const el = await fixture('app-sidebar');
await visual(el, 'app-sidebar');
expect(shadowAll(el, 'li').length).toBeGreaterThan(0);
});
});
describe('<library-filter>', () => {
beforeEach(() => {
stub('library.Library.GetAllLibrariesWithTrackCounts', [
{ id: 7, name: 'Music' },
{ id: 8, name: 'Field Recordings' },
]);
});
it('offers every library plus the merged view', async () => {
const el = await fixture('library-filter');
await flush();
await el.updateComplete;
expect(texts(el, 'option')).toEqual([
'All Libraries',
'Music',
'Field Recordings',
]);
});
it('carries an accessible name — it is a bare select otherwise', async () => {
const el = await fixture('library-filter');
expect(shadow(el, 'select')?.getAttribute('aria-label')).toBe(
'Library filter',
);
});
it('selects a library by id, and the merged view by empty string', async () => {
const el = await fixture('library-filter');
await flush();
await el.updateComplete;
const select = shadow<HTMLSelectElement>(el, 'select');
if (select) select.value = '8';
select?.dispatchEvent(new Event('change'));
await flush();
expect(lastArgs('library.Library.GetTracks')).toEqual([8]);
});
it('picks up a library added while it was on screen', async () => {
const el = await fixture('library-filter');
await flush();
await el.updateComplete;
stub('library.Library.GetAllLibrariesWithTrackCounts', [
{ id: 7, name: 'Music' },
{ id: 8, name: 'Field Recordings' },
{ id: 9, name: 'Podcasts' },
]);
emit(Events.LibraryAdded, { id: 9 });
await flush();
await el.updateComplete;
expect(texts(el, 'option')).toContain('Podcasts');
});
});
describe('<library-status-indicator>', () => {
it('defaults to "not in library"', async () => {
const el = await fixture('library-status-indicator');
expect(shadow(el, 'wa-icon')?.getAttribute('name')).toBe('plus');
});
it('uses a distinct glyph per state', async () => {
const glyphs: (string | null | undefined)[] = [];
for (const status of ['in-library', 'queued', 'not-in-library']) {
const el = await fixture('library-status-indicator', { status });
glyphs.push(shadow(el, 'wa-icon')?.getAttribute('name'));
}
expect(glyphs).toEqual(['check', 'hourglass-half', 'plus']);
});
it('phrases its label around the entity it describes', async () => {
const el = await fixture('library-status-indicator', {
status: 'in-library',
entityType: 'album',
label: 'Abbey Road',
});
expect(shadow(el, '.badge')?.getAttribute('aria-label')).toBe(
'Album "Abbey Road" is in your library',
);
});
it('states an unowned entity rather than offering to add it', async () => {
// The old copy was "Add artist “Eno” to library", which is the
// promise the inert button was making. Nothing here adds anything.
const el = await fixture('library-status-indicator', {
entityType: 'artist',
label: 'Eno',
});
expect(shadow(el, '.badge')?.getAttribute('aria-label')).toBe(
'Artist "Eno" is not in your library',
);
});
it('is a badge, not a keyboard stop', async () => {
// 20 of the 66 tab stops on an Explore results page were these,
// each announcing itself as a button and doing nothing.
const el = await fixture('library-status-indicator', {
status: 'in-library',
});
expect(shadow(el, 'button')).toBeNull();
const badge = shadow(el, '.badge');
expect(badge?.getAttribute('role')).toBe('img');
expect(badge?.hasAttribute('tabindex')).toBe(false);
});
it('drops the quoted name when it has none', async () => {
const el = await fixture('library-status-indicator', { status: 'queued' });
expect(shadow(el, '.badge')?.getAttribute('aria-label')).toBe(
'Track is queued for download',
);
});
it('mirrors the label into the tooltip', async () => {
const el = await fixture('library-status-indicator', {
status: 'in-library',
});
const badge = shadow(el, '.badge');
expect(badge?.getAttribute('title')).toBe(badge?.getAttribute('aria-label'));
});
it('lets a click reach the card it sits on, and calls nothing itself', async () => {
// It used to stopPropagation() so its own no-op click would not
// navigate the card. With no click of its own, the badge is part
// of the card and a click on it means what the card means.
const el = await fixture('library-status-indicator');
let bubbled = 0;
el.addEventListener('click', () => {
bubbled += 1;
});
shadow<HTMLElement>(el, '.badge')?.click();
expect([bubbled, calls()]).toEqual([1, []]);
});
it('honours a non-default size', async () => {
const el = await fixture('library-status-indicator', { size: 32 });
expect(el.style.getPropertyValue('--indicator-size')).toBe('32px');
});
it('looks the way it did last time', async () => {
const el = await fixture('library-status-indicator', {
status: 'in-library',
});
await update(el, { size: 40 });
await visual(el, 'library-status-indicator-in-library');
expect(shadow(el, '.badge')).not.toBeNull();
});
});
describe('<library-filter> resilience', () => {
afterEach(() => {
vi.restoreAllMocks();
});
it('renders the merged view even when the library list cannot be loaded', async () => {
vi.spyOn(console, 'error').mockImplementation(() => undefined);
stub('library.Library.GetAllLibrariesWithTrackCounts', () => {
throw new Error('database locked');
});
// The store caches the library list; drop it so the failing stub is
// actually reached.
emit(Events.LibraryRemoved, { id: 7 });
const el = await fixture('library-filter');
await flush();
await el.updateComplete;
expect(texts(el, 'option')).toEqual(['All Libraries']);
});
});