Files
yellowjacket/backend/playlist/emit_test.go
yonluandClaude Opus 5 e7748f1fd5
CI / check (push) Successful in 3m7s
CI / e2e (push) Canceled after 1m45s
feat(database): shape the library like files, and shrink the catalog
Plans 013 and 014, the album page that prompted them, and the smaller
fixes they turned up. Changelog, largest first.

## The local library is shaped like files, not like MusicBrainz

`audio_files` carries its own tags and points at `albums` and
`artists`; `file_genres` is the one real many-to-many. `recordings`,
`release_group_recordings`, `artist_credit`, `artist_credit_artist`,
`recording_genres`, `release_groups` and `release_to_rg` are gone from
the local side, and with them a six-way join in every read, a
`MIN(release_group_id)` subquery in eleven queries and a
first-credited-artist subquery in nine. Measured on a real 25,966-file
library, every many-to-many that model expressed was 1:1 in the data.

- Ownership is a file. `GetFilePathsByRecordingMBIDs`,
  `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and
  `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812
  orphaned recordings, 216 release groups and 260 artists that library
  carried are now structurally impossible.
- One projection: every track query selects from the `track_metadata`
  view, one row type, one mapper. Nine hand-rolled copies had drifted
  far enough to report different years on different screens.
- `library_id = 0` means every library, so each list query exists once
  instead of scoped and unscoped with a branch at every call site.
- No migration chain. `sql/schemas/` is the one description of the
  shape; `sql/migrations/`, `applyMigrations` and `schema_migrations`
  are squashed away, along with the drift between them that had sqlc
  generating against a stale schema.
- `database.InsertTestTrack` is the one test seeder; twenty test files
  had been assembling the old FK chain each in its own order.

## The catalog stores its ids as bytes

`explore_index`'s three 36-char MBID columns and its entity-type text
are 16 raw bytes and a small integer. The table and its six indexes go
780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh
install is ~0.6 GB rather than ~1.0 GB.

- `backend/explore/mbid.go` is the only place the encoding is known;
  everything above it speaks dashed strings.
- `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert
  rather than silently returning no rows, since SQLite does not coerce
  between TEXT and BLOB.
- The importer asks the artifact what encoding it carries and converts
  on the way in, so the artifact already published keeps working and no
  format bump is needed.
- `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column
  list, and `TestStoredEncodingRoundTrips` sweeps every read path.

## An album page that says how much of the album is yours

- One question, asked once: is there a file. `filePaths` is filled by a
  single batched lookup when the tracklist settles, and the badge, the
  Play count, the dimmed rows and every menu item read it — replacing
  four claims of decreasing confidence that could show a green tick on
  an album whose every action did nothing.
- Play, Play 7 of 12, or no play button at all.
- `total_tracks` on `explore_index` (~2 bytes over 400,677 release
  groups) and on `audio_files` from tags that have always carried it:
  a complete MBID-matched album now makes no catalog call at all, where
  it used to spend the most expensive request the app makes.
- A merged cluster shows the running order the most releases agree on,
  and the version list marks the release you own rather than standing a
  synthetic entry in for it.
- `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed
  one by a 12-second timer.
- Rows not in the library are dimmed in place (with `aria-disabled`)
  instead of the owned ones wearing a green tick and a legend.

## Caches and cover art get ceilings

- Only the three tiers of a cover are stored; the full-resolution copy
  nothing rendered was 1,134 MB of a 1.4 GB covers directory.
- One artist portrait is downloaded and the rest are remembered as
  URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads.
- `browsedArtBudget` and `httpCacheBudget` bound what an age cannot:
  the same install held art for 5,770 artists in a 1,301-artist
  library.
- `OrphanedArtistImagesJob` joined a bare MBID onto a sharded
  directory, so it deleted the rows that were the only record of the
  files it left behind. `explore.ArtistImageDir` is that layout's one
  definition now.

## The autotag queue asks whether there is work

`tagging_items` was a row per album folder, not a queue, and no query
read the `tag_status` column that held the answer. The four queue
queries ask the files, which matters most where it is least visible:
`startPrefetch` was scoring every album in a tagged library against
MusicBrainz.

## Phantom playlist tracks resolve in place

An M3U8 imported before its files leaves phantom rows; they now match
by path and fall back to position, keep their place in the playlist
when resolved, and pair best-first so two phantoms cannot claim the
same file.

## Playing a track plays the list it is in

Double-click, and Play on a single row's menu, queue the list as
displayed with `startIndex` on that row — the album page and the track
list used to queue one track and discard the album around it. A
multi-row selection still plays exactly itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
2026-08-16 13:58:15 -04:00

184 lines
4.4 KiB
Go

package playlist
import (
"context"
"fmt"
"log/slog"
"testing"
"github.com/wailsapp/wails/v3/pkg/application"
"yellowjacket/backend/database"
"yellowjacket/backend/events"
)
// stubLibraryDir satisfies LibraryDirProvider.
type stubLibraryDir struct{ dir string }
func (s stubLibraryDir) GetLibraryDirectory() string { return s.dir }
// setupRecordedService builds a playlist service on an in-memory DB
// that writes its M3U8 files to a temp directory and records the events
// it would push to the frontend.
func setupRecordedService(
t *testing.T,
) (*Service, *database.DB, *events.Recorder) {
t.Helper()
db := database.NewTestDB(t)
libDir := t.TempDir()
svc := NewService(slog.Default(), db, stubLibraryDir{dir: libDir})
svc.dataDirOverride = t.TempDir()
rec := events.NewRecorder()
_ = svc.ServiceStartup(events.WithSink(context.Background(), rec), application.ServiceOptions{})
return svc, db, rec
}
// seedPlaylistTracks inserts `count` audio_file rows and returns their
// paths.
func seedPlaylistTracks(t *testing.T, db *database.DB, count int) []string {
t.Helper()
paths := make([]string, count)
for i := range count {
paths[i] = fmt.Sprintf("/test/pl-track%d.mp3", i+1)
database.InsertTestTrack(t, db, database.TestTrack{
FilePath: paths[i],
Title: fmt.Sprintf("Track %d", i+1),
Artist: "Test Artist",
LengthMs: 180000,
})
}
return paths
}
func TestEmit_CreatePlaylistAnnouncesTheNewRow(t *testing.T) {
t.Parallel()
svc, _, rec := setupRecordedService(t)
created, err := svc.CreatePlaylist("Road Trip")
if err != nil {
t.Fatalf("CreatePlaylist: %v", err)
}
ev, ok := rec.Last(events.PlaylistCreated)
if !ok {
t.Fatalf("no PlaylistCreated; got %v", rec.Names())
}
summary, ok := ev.Payload().(Summary)
if !ok {
t.Fatalf("payload is %T, want playlist.Summary", ev.Payload())
}
// The frontend adds the sidebar entry straight from this payload
// rather than re-fetching, so an empty field here is a blank row.
if summary.ID != created.ID {
t.Errorf("emitted ID %d, want %d", summary.ID, created.ID)
}
if summary.Name != "Road Trip" {
t.Errorf("emitted name %q, want Road Trip", summary.Name)
}
if summary.CreatedAt == "" || summary.UpdatedAt == "" {
t.Errorf("emitted empty timestamps: %+v", summary)
}
}
func TestEmit_RejectedCreateIsSilent(t *testing.T) {
t.Parallel()
svc, _, rec := setupRecordedService(t)
if _, err := svc.CreatePlaylist(" "); err == nil {
t.Fatal("CreatePlaylist accepted a blank name")
}
if got := rec.Count(events.PlaylistCreated); got != 0 {
t.Errorf("emitted %d PlaylistCreated for a rejected create, want 0", got)
}
}
// TestEmit_TracksChangedFiresAfterTheWriteIsVisible is the reason this
// package is worth covering as well as queue: the frontend re-reads the
// playlist when it sees PlaylistTracksChanged, so an event emitted
// before the rows were committed would have it read the old contents.
func TestEmit_TracksChangedFiresAfterTheWriteIsVisible(t *testing.T) {
t.Parallel()
svc, db, rec := setupRecordedService(t)
paths := seedPlaylistTracks(t, db, 3)
created, err := svc.CreatePlaylist("Mix")
if err != nil {
t.Fatalf("CreatePlaylist: %v", err)
}
rec.Reset()
if err := svc.AddTracksToPlaylist(created.ID, paths); err != nil {
t.Fatalf("AddTracksToPlaylist: %v", err)
}
ev, ok := rec.Last(events.PlaylistTracksChanged)
if !ok {
t.Fatalf("no PlaylistTracksChanged; got %v", rec.Names())
}
id, ok := ev.Payload().(int64)
if !ok {
t.Fatalf("payload is %T, want int64", ev.Payload())
}
if id != created.ID {
t.Errorf("emitted playlist ID %d, want %d", id, created.ID)
}
// Read back the way the frontend would on receipt of the event.
tracks, err := svc.GetPlaylistTracks(created.ID)
if err != nil {
t.Fatalf("GetPlaylistTracks: %v", err)
}
if len(tracks) != len(paths) {
t.Errorf(
"a frontend reacting to the event reads %d tracks, want %d",
len(tracks), len(paths),
)
}
}
func TestEmit_DeletePlaylistAnnouncesTheID(t *testing.T) {
t.Parallel()
svc, _, rec := setupRecordedService(t)
created, err := svc.CreatePlaylist("Temp")
if err != nil {
t.Fatalf("CreatePlaylist: %v", err)
}
rec.Reset()
if err := svc.DeletePlaylist(created.ID); err != nil {
t.Fatalf("DeletePlaylist: %v", err)
}
ev, ok := rec.Last(events.PlaylistDeleted)
if !ok {
t.Fatalf("no PlaylistDeleted; got %v", rec.Names())
}
if id, _ := ev.Payload().(int64); id != created.ID {
t.Errorf("emitted ID %v, want %d", ev.Payload(), created.ID)
}
}