Plans 013 and 014, the album page that prompted them, and the smaller fixes they turned up. Changelog, largest first. ## The local library is shaped like files, not like MusicBrainz `audio_files` carries its own tags and points at `albums` and `artists`; `file_genres` is the one real many-to-many. `recordings`, `release_group_recordings`, `artist_credit`, `artist_credit_artist`, `recording_genres`, `release_groups` and `release_to_rg` are gone from the local side, and with them a six-way join in every read, a `MIN(release_group_id)` subquery in eleven queries and a first-credited-artist subquery in nine. Measured on a real 25,966-file library, every many-to-many that model expressed was 1:1 in the data. - Ownership is a file. `GetFilePathsByRecordingMBIDs`, `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812 orphaned recordings, 216 release groups and 260 artists that library carried are now structurally impossible. - One projection: every track query selects from the `track_metadata` view, one row type, one mapper. Nine hand-rolled copies had drifted far enough to report different years on different screens. - `library_id = 0` means every library, so each list query exists once instead of scoped and unscoped with a branch at every call site. - No migration chain. `sql/schemas/` is the one description of the shape; `sql/migrations/`, `applyMigrations` and `schema_migrations` are squashed away, along with the drift between them that had sqlc generating against a stale schema. - `database.InsertTestTrack` is the one test seeder; twenty test files had been assembling the old FK chain each in its own order. ## The catalog stores its ids as bytes `explore_index`'s three 36-char MBID columns and its entity-type text are 16 raw bytes and a small integer. The table and its six indexes go 780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh install is ~0.6 GB rather than ~1.0 GB. - `backend/explore/mbid.go` is the only place the encoding is known; everything above it speaks dashed strings. - `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert rather than silently returning no rows, since SQLite does not coerce between TEXT and BLOB. - The importer asks the artifact what encoding it carries and converts on the way in, so the artifact already published keeps working and no format bump is needed. - `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column list, and `TestStoredEncodingRoundTrips` sweeps every read path. ## An album page that says how much of the album is yours - One question, asked once: is there a file. `filePaths` is filled by a single batched lookup when the tracklist settles, and the badge, the Play count, the dimmed rows and every menu item read it — replacing four claims of decreasing confidence that could show a green tick on an album whose every action did nothing. - Play, Play 7 of 12, or no play button at all. - `total_tracks` on `explore_index` (~2 bytes over 400,677 release groups) and on `audio_files` from tags that have always carried it: a complete MBID-matched album now makes no catalog call at all, where it used to spend the most expensive request the app makes. - A merged cluster shows the running order the most releases agree on, and the version list marks the release you own rather than standing a synthetic entry in for it. - `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed one by a 12-second timer. - Rows not in the library are dimmed in place (with `aria-disabled`) instead of the owned ones wearing a green tick and a legend. ## Caches and cover art get ceilings - Only the three tiers of a cover are stored; the full-resolution copy nothing rendered was 1,134 MB of a 1.4 GB covers directory. - One artist portrait is downloaded and the rest are remembered as URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads. - `browsedArtBudget` and `httpCacheBudget` bound what an age cannot: the same install held art for 5,770 artists in a 1,301-artist library. - `OrphanedArtistImagesJob` joined a bare MBID onto a sharded directory, so it deleted the rows that were the only record of the files it left behind. `explore.ArtistImageDir` is that layout's one definition now. ## The autotag queue asks whether there is work `tagging_items` was a row per album folder, not a queue, and no query read the `tag_status` column that held the answer. The four queue queries ask the files, which matters most where it is least visible: `startPrefetch` was scoring every album in a tagged library against MusicBrainz. ## Phantom playlist tracks resolve in place An M3U8 imported before its files leaves phantom rows; they now match by path and fall back to position, keep their place in the playlist when resolved, and pair best-first so two phantoms cannot claim the same file. ## Playing a track plays the list it is in Double-click, and Play on a single row's menu, queue the list as displayed with `startIndex` on that row — the album page and the track list used to queue one track and discard the album around it. A multi-row selection still plays exactly itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
212 lines
5.6 KiB
Go
212 lines
5.6 KiB
Go
//go:build dev
|
|
|
|
package testctl
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"yellowjacket/backend/events"
|
|
"yellowjacket/backend/system"
|
|
)
|
|
|
|
// handleHealth answers the one question every spec starts with: is the
|
|
// backend up, and is it looking at the library it should be?
|
|
//
|
|
// The frontend can answer parts of this, but only after it has rendered
|
|
// — which is exactly the thing under test. This answers before a
|
|
// single component has mounted, so it is usable as a gate.
|
|
func handleHealth(d Deps, _ *http.Request) (any, error) {
|
|
out := map[string]any{
|
|
"ok": true,
|
|
"home": os.Getenv("YJ_HOME"),
|
|
"dbPath": dbPath(),
|
|
"pid": os.Getpid(),
|
|
"context": d.Context() != nil,
|
|
}
|
|
|
|
counts := map[string]int64{}
|
|
|
|
// The catalog is asked whether it has rows, not how many. A real
|
|
// one is ~1.1M rows over ~400 MB, and a cold `COUNT(*)` on it is a
|
|
// full scan off disk: **65 seconds** on the first call after a seed
|
|
// is extracted, then 7 ms once the page cache is warm. That is a
|
|
// health endpoint every spec gates on, so the first spec to run
|
|
// timed out and the rest passed - which reads as one flaky spec.
|
|
//
|
|
// This is the same rule the app itself follows for this table
|
|
// (`GetIndexStatus().TotalRows` is stale and `IsReady()` is set
|
|
// once, so the shelves ask `SELECT 1 ... LIMIT 1`). Nothing wants
|
|
// the exact number: the only caller asks whether it is > 0.
|
|
for table, query := range map[string]string{
|
|
"tracks": "SELECT COUNT(*) FROM audio_files",
|
|
"libraries": "SELECT COUNT(*) FROM libraries",
|
|
"playlists": "SELECT COUNT(*) FROM playlists",
|
|
"queueTracks": "SELECT COUNT(*) FROM queue_tracks",
|
|
"exploreIndex": "SELECT COUNT(*) FROM " +
|
|
"(SELECT 1 FROM explore_index LIMIT 1)",
|
|
} {
|
|
var n int64
|
|
if err := d.DB.QueryRowWriter(query).Scan(&n); err != nil {
|
|
counts[table] = -1
|
|
|
|
continue
|
|
}
|
|
|
|
counts[table] = n
|
|
}
|
|
|
|
out["counts"] = counts
|
|
|
|
libs, err := libraryRows(d)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
out["libraries"] = libs
|
|
|
|
return out, nil
|
|
}
|
|
|
|
// libraryRows lists the configured libraries by name and path, so a
|
|
// spec can assert it is driving the fixture library and not somebody's
|
|
// real music collection.
|
|
func libraryRows(d Deps) ([]map[string]any, error) {
|
|
rows, err := d.DB.QueryContext(
|
|
"SELECT id, name, path FROM libraries ORDER BY id",
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer func() { _ = rows.Close() }()
|
|
|
|
out := []map[string]any{}
|
|
|
|
for rows.Next() {
|
|
var (
|
|
id int64
|
|
name, path string
|
|
)
|
|
|
|
if err := rows.Scan(&id, &name, &path); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
out = append(out, map[string]any{
|
|
"id": id, "name": name, "path": path,
|
|
})
|
|
}
|
|
|
|
return out, rows.Err()
|
|
}
|
|
|
|
// handleEmit pushes a backend event into every connected frontend.
|
|
//
|
|
// This is the biggest lever the surface has. Half this app is
|
|
// push-driven, and several of those events are only produced by work
|
|
// that takes minutes to hours (a full scan, a download, an artifact
|
|
// import). Emitting one directly renders the view that consumes it
|
|
// without staging the work that would normally produce it.
|
|
//
|
|
// POST /__test/emit {"name":"LibraryScanProgress","data":[{"...":1}]}
|
|
func handleEmit(d Deps, r *http.Request) (any, error) {
|
|
var body struct {
|
|
Name string `json:"name"`
|
|
Data []any `json:"data"`
|
|
}
|
|
|
|
if err := decode(r, &body); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if body.Name == "" {
|
|
return nil, errNoEventName
|
|
}
|
|
|
|
// events.Deliver rather than events.Emit: an ordinary emitter wants
|
|
// an event with nowhere to go dropped, but this endpoint exists to
|
|
// impersonate one, and reporting a 200 for an event that never
|
|
// reached a frontend would send a caller debugging the wrong half of
|
|
// the app.
|
|
if err := events.Deliver(d.Context(), body.Name, body.Data...); err != nil {
|
|
return nil, fmt.Errorf("emit %s: %w", body.Name, err)
|
|
}
|
|
|
|
return map[string]any{"emitted": body.Name, "args": len(body.Data)}, nil
|
|
}
|
|
|
|
// handleSQL runs a statement against the writer connection.
|
|
//
|
|
// One general escape hatch rather than a bespoke endpoint per piece of
|
|
// forced state — "mark this track played", "insert a wanted-list row",
|
|
// "age this cache entry" — each of which would otherwise arrive one at
|
|
// a time and never be removed.
|
|
//
|
|
// POST /__test/sql {"sql":"UPDATE ...","args":[1,"x"]}
|
|
func handleSQL(d Deps, r *http.Request) (any, error) {
|
|
var body struct {
|
|
SQL string `json:"sql"`
|
|
Args []any `json:"args"`
|
|
}
|
|
|
|
if err := decode(r, &body); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if body.SQL == "" {
|
|
return nil, errNoSQL
|
|
}
|
|
|
|
// Route by statement kind rather than by trying one and falling
|
|
// back: the read pool is opened query_only, so sending a write
|
|
// there fails in a way that looks like a bug in the caller's SQL.
|
|
if isQuery(body.SQL) {
|
|
rows, err := d.DB.QueryContextWith(r.Context(), body.SQL, body.Args...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer func() { _ = rows.Close() }()
|
|
|
|
return scanAll(rows)
|
|
}
|
|
|
|
res, err := d.DB.ExecContext(body.SQL, body.Args...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
affected, err := res.RowsAffected()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return map[string]any{"rowsAffected": affected}, nil
|
|
}
|
|
|
|
// isQuery reports whether a statement returns rows.
|
|
func isQuery(sql string) bool {
|
|
first, _, _ := strings.Cut(strings.TrimSpace(sql), " ")
|
|
|
|
switch strings.ToUpper(first) {
|
|
case "SELECT", "WITH", "PRAGMA", "EXPLAIN":
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// dbPath reports where the SQLite file lives, mirroring database.NewDB.
|
|
func dbPath() string {
|
|
dir, err := system.GetUserDataDirPath()
|
|
if err != nil {
|
|
return ""
|
|
}
|
|
|
|
return filepath.Join(dir, "yj.db")
|
|
}
|