Files
yellowjacket/backend/events/emit_test.go
logan 5ca6cad45a
Build & publish Arch package / arch-package (push) Successful in 2m8s
CI / check (push) Failing after 1m56s
CI / e2e (push) Skipped
Search index maintenance / maintain-index (push) Successful in 13s
feat(harness): agent-drivable dev harness and CI that gates
A coding agent could develop this repo's Go packages and could not
develop the application: every path to running YellowJacket ended in a
blocking GTK window, so 265 bound methods, 46 events, 33 component
directories and 13 stores had exactly one form of verification
available — `tsc --noEmit`.

The unlock is that `wails dev`'s dev server on :34115 serves the real
frontend with the real generated bindings against the same Go backend a
desktop window attaches to, so a plain Chromium under Xvfb gets a fully
functional app. Four test tiers now exist, cheapest first:

- `make ui-test` — 313 Vitest tests in a real browser in ~2 s, no app,
  no backend, no display. Works because `frontend/wailsjs/` is a pure
  passthrough to `window.go`/`window.runtime`, so faking just those two
  globals runs the real bindings and the real store code.
- `make test` — services in-process, asserting on the payload the
  frontend would receive, via a new `events.Emit` wrapper.
- `make dev-headless` + `playwright-cli` — the real app, driven
  interactively, with an event bridge on `window.__yjEvents` and a
  dev-only control surface at `/__test/`.
- `make e2e` — 19 of those flows frozen as Playwright specs.

`events.Emit(ctx, …)` replaces all 35 direct `runtime.EventsEmit` call
sites: wails' `getEvents` `log.Fatalf`s on any context without its
runtime, so those paths could not run under test and a background
worker could take the app down. Four packages had each hand-rolled the
same guard; nine more guarded on `ctx != nil`, which does not help.
`TestNoDirectRuntimeEmits` fails the build on a new one.

Fixtures are generated, not committed (`make testdata`), and seeds are
built by *running the app* — never by hand-writing config and DB rows,
which would be a second description of a valid YJ_HOME.

`.gitea/workflows/ci.yml` is the first workflow here that tests
anything; the other three only package, so `gitea_ci` reported only
packaging jobs and misled anyone asking whether a push was healthy.
Both jobs were prototyped to green in a bare ubuntu:24.04 container
before the YAML was written, which immediately caught `make lint`
linting three configurations that nothing builds: all three passes
omitted `webkit2_41`, so wails resolved webkit2gtk-4.0 — which Arch
still ships and Ubuntu 24.04 dropped.

Operational instructions live in `.pi/skills/yellowjacket-dev/`,
measured discoveries in `.planning/NOTES.md`, and architecture in
`CLAUDE.md` — split by tense, not by topic, because a topical split
gives every new fact two plausible homes. `make skill-check` fails a
commit if the skill cites a make target that does not exist.
2026-08-10 23:20:42 -04:00

187 lines
3.8 KiB
Go

package events_test
import (
"context"
"errors"
"sync"
"testing"
"time"
"yellowjacket/backend/events"
)
func TestEmitDropsWithoutRuntimeOrSink(t *testing.T) {
t.Parallel()
// The point of the wrapper: neither of these may reach
// runtime.EventsEmit, which would log.Fatalf and take the test
// binary down with it.
events.Emit(context.Background(), events.QueueChanged, "payload")
//nolint:staticcheck // a nil context is the case under test.
events.Emit(nil, events.QueueChanged, "payload")
}
func TestDeliverReportsMissingRuntime(t *testing.T) {
t.Parallel()
tests := []struct {
name string
ctx context.Context
}{
{name: "nil context", ctx: nil},
{name: "no runtime", ctx: context.Background()},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
err := events.Deliver(tt.ctx, events.QueueChanged)
if !errors.Is(err, events.ErrNoRuntime) {
t.Fatalf("got %v, want ErrNoRuntime", err)
}
})
}
}
func TestSinkReceivesEmittedEvents(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
ctx := events.WithSink(context.Background(), rec)
events.Emit(ctx, events.QueueChanged, "one")
events.Emit(ctx, events.VolumeChanged, 42)
if err := events.Deliver(ctx, events.TrackChanged); err != nil {
t.Fatalf("Deliver with a sink installed: %v", err)
}
want := []string{
events.QueueChanged,
events.VolumeChanged,
events.TrackChanged,
}
got := rec.Names()
if len(got) != len(want) {
t.Fatalf("recorded %v, want %v", got, want)
}
for i := range want {
if got[i] != want[i] {
t.Errorf("event %d = %q, want %q", i, got[i], want[i])
}
}
ev, ok := rec.Last(events.VolumeChanged)
if !ok {
t.Fatal("VolumeChanged not recorded")
}
if ev.Payload() != 42 {
t.Errorf("VolumeChanged payload = %v, want 42", ev.Payload())
}
}
func TestRecorderPayloadOfArgumentlessEvent(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
rec.Emit(events.SeekFailed)
ev, ok := rec.Last(events.SeekFailed)
if !ok {
t.Fatal("SeekFailed not recorded")
}
if ev.Payload() != nil {
t.Errorf("payload = %v, want nil", ev.Payload())
}
}
func TestRecorderWaitSeesEventsAlreadyRecorded(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
rec.Emit(events.LibraryScanComplete, 31)
ev, ok := rec.Wait(events.LibraryScanComplete, time.Second)
if !ok {
t.Fatal("Wait missed an event recorded before the call")
}
if ev.Payload() != 31 {
t.Errorf("payload = %v, want 31", ev.Payload())
}
}
func TestRecorderWaitBlocksForBackgroundEmit(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
ctx := events.WithSink(context.Background(), rec)
go func() {
time.Sleep(10 * time.Millisecond)
events.Emit(ctx, events.LibraryScanProgress, 1)
events.Emit(ctx, events.LibraryScanComplete, 2)
}()
if _, ok := rec.Wait(events.LibraryScanComplete, 2*time.Second); !ok {
t.Fatal("Wait timed out on a background emit")
}
}
func TestRecorderWaitTimesOut(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
if _, ok := rec.Wait(events.QueueChanged, 20*time.Millisecond); ok {
t.Fatal("Wait returned an event that was never emitted")
}
}
func TestRecorderIsConcurrencySafe(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
ctx := events.WithSink(context.Background(), rec)
const emitters, each = 8, 25
var wg sync.WaitGroup
wg.Add(emitters)
for range emitters {
go func() {
defer wg.Done()
for range each {
events.Emit(ctx, events.QueueChanged, 1)
}
}()
}
wg.Wait()
if got := rec.Count(events.QueueChanged); got != emitters*each {
t.Errorf("recorded %d events, want %d", got, emitters*each)
}
}
func TestRecorderReset(t *testing.T) {
t.Parallel()
rec := events.NewRecorder()
rec.Emit(events.QueueChanged)
rec.Reset()
if got := rec.Events(); len(got) != 0 {
t.Errorf("after Reset: %v, want empty", got)
}
}