Files
yellowjacket/e2e/support/fixtures.ts
yonluandClaude Opus 5 deb3f3da7e feat(wails): move the e2e harness and headless launch onto v3
make e2e is green on chromium: 92 passed. The harness is rebuilt on
what v3 actually offers, and three of the four things it replaced turn
out to be better than what they replaced.

The headless launch is v3's own server mode. scripts/dev-headless.sh
ran a `-tags dev` binary whose app_dev.go parsed -devserver/-assetdir
out of os.Args; that file went with v2, so the harness had no server at
all. `-tags dev,server` is a first-class mode and needs no display, so
Xvfb is gone from the script and from CI.

The bridge hooks two places, neither of them EventsOn. Inbound is
window._wails.dispatchWailsEvent, wrapped by pre-creating the object
the runtime keeps and putting an accessor on the one property.
Outbound is fetch: v3 routes every runtime call through one POST, so
the bridge sees binding calls and event emits from any module, needs no
walk of an object graph, and cannot miss a call made before it looked.

__yjEvents.call posts to that endpoint by method name, so it depends on
nothing in the app's bundle and works on a page with no init script.
That is what lets seed-sandbox.sh drop playwright-cli entirely — it
drove AddLibrary through a browser only because window.go was v2's one
way in — and with it a global npm install and a second Chromium in CI.

measure.mjs and one spec lose their window.go walks and read the
bridge's log instead; e2e/support/method-ids.mjs derives id -> name
from frontend/bindings/ (phase 6b option 1, so it cannot go stale
silently). Plain .mjs because measure.mjs runs under bare node and one
derivation beats two that can disagree.

Four bugs surfaced, and the migration is how.

The cross-service wiring never ran headless. It hung off
Common.ApplicationStarted, which server mode never emits —
setupCommonEvents is an explicit no-op there — so the queue had no
TrackLoader and playing a track changed the queue and then silently did
nothing. It is a service registered last now (backend/startup.go):
services start in registration order, which is the ordering the wiring
needs, in every mode.

Six specs called SetQueue with 3 of its 4 arguments. v2 accepted that
and filled the gap; v3 answers "expects 4 arguments, got 3".

requested-badge's cleanup read window.go and returned early on
`if (!svc)` — the silent cleanup its own comment was written to
prevent, one migration later. It posts to the runtime endpoint now,
which any page can do.

SearchIndex.Search trusted a startup latch, so rows a spec staged
afterwards were unsearchable and three specs passed only when an
earlier one happened to flip it. shelves.go fixed exactly this and left
hasCatalogRows behind; the search path now uses it as the fallback,
with the latch still the fast path.

Two spec edits are deletions of assertions about v2. harness.spec
checked Object.keys(window.go) and that a bad call *hung*; it now
checks the real runtime is loaded and that the backend rejects with a
TypeError naming the argument. album-actions asserted a tracklist
legend that dcc40b1 deleted on main — that spec has been failing since,
and what replaced it is covered in frontend/test/components.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDCbcCZQepnpSQYJ6SxxZm
2026-08-14 20:58:20 -04:00

216 lines
6.6 KiB
TypeScript
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { fileURLToPath } from 'node:url';
import { dirname, resolve } from 'node:path';
import { test as base, expect, type Page } from '@playwright/test';
import { nameOf } from './method-ids.mjs';
const here = dirname(fileURLToPath(import.meta.url));
/** The same bridge `playwright-cli` loads, so an exploratory session and
* a committed spec see an identical page. */
const INIT_SCRIPT = resolve(here, '../../.playwright/init-events.js');
/**
* The fourth argument to `queue.Queue.SetQueue`, for a queue with no
* single source — the whole library, or a handful of ad-hoc tracks,
* which is what every spec here builds.
*
* It is passed explicitly because v3 rejects a call with the wrong
* argument count (`expects 4 arguments, got 3`) where v2 accepted one
* and filled the gap with a zero value. The specs had been three-arg
* since the parameter was added; nothing said so.
*/
export const NO_QUEUE_SOURCE = { type: '', id: 0, label: '' };
/**
* The 90-second fixture track (`cmd/gentestdata`, case `edge-lengths`).
*
* Every other fixture is 26 seconds, which is shorter than the time a
* spec takes to click something — a "pause it" test against one of
* those races the track finishing and fails on a UI that is correct.
*/
export const LONG_TRACK = 'Long Player';
/** Shape of the recorder installed by .playwright/init-events.js. */
export type YjEvent = {
seq: number;
name: string;
data: unknown[];
dir: 'in' | 'out';
t: number;
};
/**
* Await a backend event instead of a timeout.
*
* Half of this app is push-driven, and the events that matter
* (scan progress, job updates, playback state) arrive whenever the
* backend gets to them. `waitForEvent` resolves against events already
* buffered as well as future ones, so there is no race between doing
* the thing and starting to listen.
*/
export async function waitForEvent(
page: Page,
name: string,
opts: { timeoutMs?: number; since?: number } = {},
): Promise<YjEvent> {
return page.evaluate(
([n, o]) => window.__yjEvents.wait(n as string, o as object),
[name, { timeoutMs: 10_000, ...opts }] as const,
) as Promise<YjEvent>;
}
/** Drop the event buffer. Never re-register a recorder: listeners
* survive across evaluate calls and a second recorder double-counts. */
export async function resetEvents(page: Page): Promise<void> {
await page.evaluate(() => void window.__yjEvents.reset());
}
/** name -> count, for asserting on (or debugging) what actually fired. */
export async function eventNames(
page: Page,
): Promise<Record<string, number>> {
return page.evaluate(() => window.__yjEvents.names());
}
/**
* Call a bound Go method by name, over the runtime's own endpoint.
*
* v3 rejects a bad call rather than never firing its callback the way
* v2 did: a wrong argument type comes back as a TypeError naming the
* argument, a wrong count as `expects 4 arguments, got 3`, an unknown
* method as a ReferenceError. The timeout is a backstop for a hung
* request, not the mechanism that makes a mistake visible.
*/
export async function callBinding<T = unknown>(
page: Page,
path: string,
args: unknown[] = [],
timeoutMs = 10_000,
): Promise<T> {
return page.evaluate(
([p, a, t]) =>
window.__yjEvents.call(p as string, a as unknown[], t as number),
[path, args, timeoutMs] as const,
) as Promise<T>;
}
/**
* The binding calls the *app* made, newest last, as `pkg.Type.Method`.
*
* This is what replaces v2's trick of wrapping `window.go` in place:
* `.playwright/init-events.js` records every call off the one POST v3
* routes them all through, and `method-ids.ts` names them from the
* generated tree. It sees calls from any module and cannot miss one
* made before a wrapper was installed.
*/
export async function bindingCalls(page: Page): Promise<string[]> {
const calls = await page.evaluate(() => window.__yjEvents.bindings);
return calls.map(nameOf);
}
/** Thin client for the dev-only /__test/ surface (backend/testctl). */
export class TestCtl {
constructor(private readonly baseURL: string) {}
private async req(path: string, init?: RequestInit) {
const res = await fetch(`${this.baseURL}${path}`, {
signal: AbortSignal.timeout(120_000),
...init,
});
const body = await res.json();
if (!res.ok) {
throw new Error(`testctl ${path}: ${body.error ?? res.status}`);
}
return body;
}
health() {
return this.req('/__test/health');
}
snapshot(name: string) {
return this.req(`/__test/db/snapshot?name=${name}`, { method: 'POST' });
}
restore(name: string) {
return this.req(`/__test/db/restore?name=${name}`, { method: 'POST' });
}
emit(name: string, ...data: unknown[]) {
return this.req('/__test/emit', {
method: 'POST',
body: JSON.stringify({ name, data }),
});
}
sql(sql: string, args: unknown[] = []) {
return this.req('/__test/sql', {
method: 'POST',
body: JSON.stringify({ sql, args }),
});
}
}
export const test = base.extend<{ app: Page; testctl: TestCtl }>({
/** A page with the event bridge installed and the app loaded and
* actually talking to the backend — not merely DOM-ready, which is
* earlier and lies. */
app: async ({ page, baseURL }, use) => {
await page.addInitScript({ path: INIT_SCRIPT });
await page.goto(baseURL!);
await page.evaluate(() => window.__yjEvents.ready(20_000));
await use(page);
},
testctl: async ({ baseURL }, use) => {
await use(new TestCtl(baseURL!));
},
});
export { expect };
declare global {
interface Window {
__yjEvents: {
version: number;
seq: number;
log: YjEvent[];
reset(): number;
all(name?: string): YjEvent[];
count(name?: string): number;
last(name?: string): YjEvent | null;
since(seq: number): YjEvent[];
names(): Record<string, number>;
wait(
name: string,
opts?: {
timeoutMs?: number;
since?: number;
match?: (data: unknown[], entry: YjEvent) => boolean;
},
): Promise<YjEvent>;
ready(timeoutMs?: number): Promise<boolean>;
call(path: string, args?: unknown[], timeoutMs?: number): Promise<any>;
/** Every binding call the app itself made; see init-events.js. */
bindings: {
methodID: number | null;
methodName: string | null;
start: number;
ms: number;
bytes: number;
}[];
measureBytes: boolean;
};
/** The v3 runtime's own namespace, installed by @wailsio/runtime. */
_wails?: {
dispatchWailsEvent?: (event: unknown) => void;
clientId?: string;
};
}
}