Files
yellowjacket/backend/explore/mix_test.go
yonluandClaude Opus 5 e7748f1fd5
CI / check (push) Successful in 3m7s
CI / e2e (push) Canceled after 1m45s
feat(database): shape the library like files, and shrink the catalog
Plans 013 and 014, the album page that prompted them, and the smaller
fixes they turned up. Changelog, largest first.

## The local library is shaped like files, not like MusicBrainz

`audio_files` carries its own tags and points at `albums` and
`artists`; `file_genres` is the one real many-to-many. `recordings`,
`release_group_recordings`, `artist_credit`, `artist_credit_artist`,
`recording_genres`, `release_groups` and `release_to_rg` are gone from
the local side, and with them a six-way join in every read, a
`MIN(release_group_id)` subquery in eleven queries and a
first-credited-artist subquery in nine. Measured on a real 25,966-file
library, every many-to-many that model expressed was 1:1 in the data.

- Ownership is a file. `GetFilePathsByRecordingMBIDs`,
  `LibraryMBIDIndex.CheckMBIDs`, `collectLibraryEntities` and
  `pruneStaleLocalCrossReferences` all join `audio_files`, so the 812
  orphaned recordings, 216 release groups and 260 artists that library
  carried are now structurally impossible.
- One projection: every track query selects from the `track_metadata`
  view, one row type, one mapper. Nine hand-rolled copies had drifted
  far enough to report different years on different screens.
- `library_id = 0` means every library, so each list query exists once
  instead of scoped and unscoped with a branch at every call site.
- No migration chain. `sql/schemas/` is the one description of the
  shape; `sql/migrations/`, `applyMigrations` and `schema_migrations`
  are squashed away, along with the drift between them that had sqlc
  generating against a stale schema.
- `database.InsertTestTrack` is the one test seeder; twenty test files
  had been assembling the old FK chain each in its own order.

## The catalog stores its ids as bytes

`explore_index`'s three 36-char MBID columns and its entity-type text
are 16 raw bytes and a small integer. The table and its six indexes go
780 MB to 405 MB on a real 2,052,200-row catalog, which is why a fresh
install is ~0.6 GB rather than ~1.0 GB.

- `backend/explore/mbid.go` is the only place the encoding is known;
  everything above it speaks dashed strings.
- `CHECK(length(mbid) = 16)` makes a stringly write fail at the insert
  rather than silently returning no rows, since SQLite does not coerce
  between TEXT and BLOB.
- The importer asks the artifact what encoding it carries and converts
  on the way in, so the artifact already published keeps working and no
  format bump is needed.
- `indexRowColumns`/`scanIndexRow` replace four copies of a 22-column
  list, and `TestStoredEncodingRoundTrips` sweeps every read path.

## An album page that says how much of the album is yours

- One question, asked once: is there a file. `filePaths` is filled by a
  single batched lookup when the tracklist settles, and the badge, the
  Play count, the dimmed rows and every menu item read it — replacing
  four claims of decreasing confidence that could show a green tick on
  an album whose every action did nothing.
- Play, Play 7 of 12, or no play button at all.
- `total_tracks` on `explore_index` (~2 bytes over 400,677 release
  groups) and on `audio_files` from tags that have always carried it:
  a complete MBID-matched album now makes no catalog call at all, where
  it used to spend the most expensive request the app makes.
- A merged cluster shows the running order the most releases agree on,
  and the version list marks the release you own rather than standing a
  synthetic entry in for it.
- `AlbumReleasesFailed`: a slow fetch is no longer reported as a failed
  one by a 12-second timer.
- Rows not in the library are dimmed in place (with `aria-disabled`)
  instead of the owned ones wearing a green tick and a legend.

## Caches and cover art get ceilings

- Only the three tiers of a cover are stored; the full-resolution copy
  nothing rendered was 1,134 MB of a 1.4 GB covers directory.
- One artist portrait is downloaded and the rest are remembered as
  URLs — 4.1 GB of a 5.3 GB cache was candidates no code path reads.
- `browsedArtBudget` and `httpCacheBudget` bound what an age cannot:
  the same install held art for 5,770 artists in a 1,301-artist
  library.
- `OrphanedArtistImagesJob` joined a bare MBID onto a sharded
  directory, so it deleted the rows that were the only record of the
  files it left behind. `explore.ArtistImageDir` is that layout's one
  definition now.

## The autotag queue asks whether there is work

`tagging_items` was a row per album folder, not a queue, and no query
read the `tag_status` column that held the answer. The four queue
queries ask the files, which matters most where it is least visible:
`startPrefetch` was scoring every album in a tagged library against
MusicBrainz.

## Phantom playlist tracks resolve in place

An M3U8 imported before its files leaves phantom rows; they now match
by path and fall back to position, keep their place in the playlist
when resolved, and pair best-first so two phantoms cannot claim the
same file.

## Playing a track plays the list it is in

Double-click, and Play on a single row's menu, queue the list as
displayed with `startIndex` on that row — the album page and the track
list used to queue one track and discard the album around it. A
multi-row selection still plays exactly itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfVYUVExXsx1nSWrXN8mAh
2026-08-16 13:58:15 -04:00

213 lines
5.8 KiB
Go

package explore
import (
"context"
"fmt"
"log/slog"
"testing"
"yellowjacket/backend/database"
)
// seedMixTrack inserts one owned track by the given artist (creating
// the artist/artist_credit/recording/audio_file chain as needed),
// tagged with the given genres.
func seedMixTrack(
t *testing.T,
db *database.DB,
id int,
artistName, artistMBID string,
genreNames ...string,
) string {
t.Helper()
fp := fmt.Sprintf("/music/%s/track%d.mp3", artistName, id)
database.InsertTestTrack(t, db, database.TestTrack{
FilePath: fp,
Title: fmt.Sprintf("Track %d", id),
Artist: artistName,
ArtistMBID: artistMBID,
Genres: genreNames,
LengthMs: 180000,
})
return fp
}
// seedSimilarArtist records a pre-computed similarity row, as the
// Tier 4 index build / lazy LB fetch would.
func seedSimilarArtist(
t *testing.T,
db *database.DB,
sourceMBID, similarMBID, similarName string,
score int,
) {
t.Helper()
_, err := db.ExecContext(
"INSERT INTO similar_artist_map "+
"(source_artist_mbid, similar_artist_mbid, similar_artist_name, score) "+
"VALUES (?, ?, ?, ?)",
sourceMBID, similarMBID, similarName, score,
)
if err != nil {
t.Fatalf("insert similar_artist_map row: %v", err)
}
}
func newMixTestService(db *database.DB) *Service {
return &Service{db: db, logger: slog.Default()}
}
func TestGenerateMix_ExpandsToSimilarLibraryArtists(t *testing.T) {
t.Parallel()
db := database.NewTestDB(t)
e := newMixTestService(db)
seedPath := seedMixTrack(t, db, 1, "Seed Artist", "mbid-seed")
similarPath := seedMixTrack(t, db, 2, "Similar Artist", "mbid-similar")
unrelatedPath := seedMixTrack(t, db, 3, "Unrelated Artist", "mbid-unrelated")
seedSimilarArtist(t, db, "mbid-seed", "mbid-similar", "Similar Artist", 90)
paths, label, err := e.GenerateMix(context.Background(), []string{seedPath}, false)
if err != nil {
t.Fatalf("GenerateMix: %v", err)
}
if len(paths) != 1 || paths[0] != similarPath {
t.Errorf("paths: got %v, want [%q]", paths, similarPath)
}
for _, p := range paths {
if p == unrelatedPath {
t.Error("mix included a track by an artist with no recorded similarity")
}
}
if label == "" {
t.Error("label: got empty string, want a seed-derived label")
}
}
func TestGenerateMix_BoostsSharedGenre(t *testing.T) {
t.Parallel()
db := database.NewTestDB(t)
e := newMixTestService(db)
seedPath := seedMixTrack(t, db, 1, "Seed Artist", "mbid-seed", "Shoegaze")
matchingGenrePath := seedMixTrack(t, db, 2, "Similar A", "mbid-similar-a", "Shoegaze")
differentGenrePath := seedMixTrack(t, db, 3, "Similar B", "mbid-similar-b", "Ambient")
// Same base similarity score for both, so genre is what breaks the tie.
seedSimilarArtist(t, db, "mbid-seed", "mbid-similar-a", "Similar A", 50)
seedSimilarArtist(t, db, "mbid-seed", "mbid-similar-b", "Similar B", 50)
candidates := e.mixCandidates(
context.Background(),
map[string]int{"mbid-seed": 1},
map[string]bool{"Shoegaze": true},
[]string{seedPath},
nil,
)
if candidates[matchingGenrePath] <= candidates[differentGenrePath] {
t.Errorf(
"weight: shared-genre candidate (%v) should outweigh the other (%v)",
candidates[matchingGenrePath], candidates[differentGenrePath],
)
}
}
func TestGenerateMix_ExcludesAlreadyPlayed(t *testing.T) {
t.Parallel()
db := database.NewTestDB(t)
e := newMixTestService(db)
seedPath := seedMixTrack(t, db, 1, "Seed Artist", "mbid-seed")
similarPath := seedMixTrack(t, db, 2, "Similar Artist", "mbid-similar")
seedSimilarArtist(t, db, "mbid-seed", "mbid-similar", "Similar Artist", 90)
ctx := context.Background()
first, _, err := e.GenerateMix(ctx, []string{seedPath}, false)
if err != nil {
t.Fatalf("first GenerateMix: %v", err)
}
if len(first) != 1 || first[0] != similarPath {
t.Fatalf("first batch: got %v, want [%q]", first, similarPath)
}
// Continuing the same session, with nothing new to offer: rather
// than dead-ending, it should replay from the pool instead of
// returning nothing.
second, _, err := e.GenerateMix(ctx, nil, true)
if err != nil {
t.Fatalf("second GenerateMix: %v", err)
}
if len(second) != 1 || second[0] != similarPath {
t.Errorf(
"second batch: got %v, want [%q] (replayed after exhausting the pool)",
second, similarPath,
)
}
}
func TestGenerateMix_ContinuingIgnoresNewSeed(t *testing.T) {
t.Parallel()
db := database.NewTestDB(t)
e := newMixTestService(db)
originalSeed := seedMixTrack(t, db, 1, "Seed Artist", "mbid-seed")
_ = seedMixTrack(t, db, 2, "Similar Artist", "mbid-similar")
unrelatedSeed := seedMixTrack(t, db, 3, "Other Artist", "mbid-other")
similarToUnrelated := seedMixTrack(t, db, 4, "Other Similar", "mbid-other-similar")
seedSimilarArtist(t, db, "mbid-seed", "mbid-similar", "Similar Artist", 90)
seedSimilarArtist(t, db, "mbid-other", "mbid-other-similar", "Other Similar", 90)
ctx := context.Background()
if _, _, err := e.GenerateMix(ctx, []string{originalSeed}, false); err != nil {
t.Fatalf("GenerateMix: %v", err)
}
// A second, unrelated seed passed while "continuing" is ignored —
// the mix stays anchored to what it started with.
paths, _, err := e.GenerateMix(ctx, []string{unrelatedSeed}, true)
if err != nil {
t.Fatalf("GenerateMix (continuing): %v", err)
}
for _, p := range paths {
if p == similarToUnrelated {
t.Error("continuing mix drifted to the newly passed seed instead of the original")
}
}
}
func TestGenerateMix_NoSeedArtistDataReturnsNothing(t *testing.T) {
t.Parallel()
db := database.NewTestDB(t)
e := newMixTestService(db)
// A file path with no matching audio_files row at all.
paths, label, err := e.GenerateMix(context.Background(), []string{"/nowhere.mp3"}, false)
if err != nil {
t.Fatalf("GenerateMix: %v", err)
}
if len(paths) != 0 || label != "" {
t.Errorf("got (%v, %q), want (nil, \"\")", paths, label)
}
}