logan
26251badda
The check asserts that every make target named in a doc exists, and its scanned set was .pi/ plus CLAUDE.md. Since #50, CONTRIBUTING.md is the document a *human* goes to for a build command, and it names 21 targets that nothing verified; README.md names none today and is in for the same reason. The script's own header sentence is the argument — a renamed target sends a person off the same cliff it sends an agent off. The file list is now one `docs` variable used twice, because the failure message carried a second copy of it and a second list is a second thing to forget. The `[ -d .pi ]` guard went with it: gating the whole run on .pi/ would make the human-facing half conditional on the agent-facing one, and an empty list is the same "nothing to scan" exit without the coupling. The lefthook glob is that scanned set now rather than {Makefile,.pi/**/*.md} — #220's smaller half, and it did not fire on CLAUDE.md either, which the script had read for months. Verified by planting a bad target rather than by reading the diff: both matched forms in each of the four scanned surfaces, each naming the right file; the same two plants pass on the pre-change script; unfenced prose still does not match; and the hook fires on a staged CONTRIBUTING.md under the new glob where the old one skipped it. The count is unchanged at 47 — the set is a union — so coverage is the only thing that moved. Closes #220
98 lines
3.6 KiB
YAML
98 lines
3.6 KiB
YAML
# lefthook.yml — local git hooks for yellowjacket
|
|
# Install with: lefthook install
|
|
# Docs: https://github.com/evilmartians/lefthook
|
|
|
|
# Conventional Commits. CI runs the same script over every commit in a
|
|
# push, so skipping this locally only defers the failure.
|
|
commit-msg:
|
|
commands:
|
|
commit-check:
|
|
run: ./scripts/commit-check.sh {1}
|
|
|
|
pre-commit:
|
|
parallel: true
|
|
commands:
|
|
go-vet:
|
|
glob: "*.go"
|
|
run: go vet ./...
|
|
|
|
golangci-lint:
|
|
glob: "*.go"
|
|
run: go tool golangci-lint run --timeout 5m ./...
|
|
|
|
# Snapshots the tree either side of the generators and reports only
|
|
# what moved across them. This used to be `go generate` plus a bare
|
|
# `git diff --name-only`, which is the *whole unstaged worktree* — so
|
|
# any unrelated edit sitting there was reported as stale generated
|
|
# code, and `make generate` then fixed nothing. See the script.
|
|
codegen-check:
|
|
glob: "*.{go,sql,templ}"
|
|
run: ./scripts/codegen-check.sh
|
|
|
|
# frontend/bindings is generated by `wails3`, not `go generate`, so
|
|
# the check above does not cover it. ~3.5s warm, ~20s on a cold
|
|
# build cache: v3's generator is a static analyser over the whole
|
|
# package graph, where v2's built the app with a `bindings` tag and
|
|
# ran it.
|
|
bindings-check:
|
|
glob: "*.go"
|
|
run: ./scripts/bindings-check.sh
|
|
|
|
# The docs document make targets; a stale one sends an agent — or a
|
|
# contributor reading CONTRIBUTING.md — off a cliff with total
|
|
# confidence. The glob is the script's own scanned set, because a
|
|
# hook that does not fire on a file the check reads is the drift the
|
|
# check exists to prevent: it was `{Makefile,.pi/**/*.md}` while the
|
|
# script already read CLAUDE.md. Instant.
|
|
skill-check:
|
|
glob: "{Makefile,.pi/**/*.md,AGENTS.md,CLAUDE.md,README.md,CONTRIBUTING.md}"
|
|
run: ./scripts/skill-check.sh
|
|
|
|
frontend-typecheck:
|
|
glob: "frontend/**/*.{ts,tsx}"
|
|
root: "frontend/"
|
|
run: ./node_modules/.bin/tsc --noEmit
|
|
|
|
# A backtick in a comment inside a css`` literal ends the literal.
|
|
# tsc does catch it, as "Class static side incorrectly extends base
|
|
# class static side" pointing at a line of prose; this says what
|
|
# actually happened. Instant.
|
|
css-literals:
|
|
glob: "frontend/**/*.ts"
|
|
root: "frontend/"
|
|
run: node scripts/check-css-literals.mjs
|
|
|
|
# A nested rule whose selector starts with an element name is
|
|
# silently dropped by the device's Chrome 113, and by nothing else --
|
|
# so every tier here renders it correctly and only a screenshot of
|
|
# the phone disagrees. Instant.
|
|
css-nesting:
|
|
glob: "frontend/**/*.{ts,css}"
|
|
root: "frontend/"
|
|
run: node scripts/check-css-nesting.mjs
|
|
|
|
# Deliberately sequential, unlike pre-commit. `go test -race`
|
|
# saturates every core for the better part of a minute and the UI tier
|
|
# is a real browser with wall-clock timeouts, so run together the
|
|
# browser loses: setup took 106s inside the hook against 63s
|
|
# standalone, and a different suite failed each time -- three suites
|
|
# failing to fetch setup.ts from Vitest's own dev server on one run, a
|
|
# 15s "did not mount itself" on the next, against a suite that passes
|
|
# 898/898 on its own. A gate that fails at random is not a gate. The
|
|
# ~15s saved is not worth it.
|
|
pre-push:
|
|
parallel: false
|
|
commands:
|
|
go-test:
|
|
glob: "*.go"
|
|
run: go test -race -count=1 -timeout 120s ./...
|
|
|
|
go-mod-verify:
|
|
run: go mod verify
|
|
|
|
# The component and store tier: a real browser, no app. ~2s.
|
|
ui-test:
|
|
glob: "frontend/**/*.ts"
|
|
root: "frontend/"
|
|
run: ./node_modules/.bin/vitest run
|