From ec4961ae50fda9296ad8441117a64469b178566c Mon Sep 17 00:00:00 2001 From: Logan Date: Wed, 26 Aug 2026 07:42:11 -0400 Subject: [PATCH] test(e2e): name the fixture tracks that really have no album `queueSixAndOpen` filters the queue down to tracks that have an album, because `explore-link` renders a name it cannot route as plain text and one test clicks that name. The filter is right and unchanged; the comment explaining it named the wrong two files. Since #104 read a WAV's `id3 ` chunk, the two tracks under `Field Recordings/Test Tones` are tagged, scanned and ordinary. Asked of a seeded app rather than of the comment, exactly two tracks in the fixture library have no album: `unsorted/no-tags-at-all.mp3` and `unsorted/title-only.mp3`. The clause saying which change made the old names wrong is there so the next reader does not restore them. Closes #217 --- e2e/specs/queue-selection.spec.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/e2e/specs/queue-selection.spec.ts b/e2e/specs/queue-selection.spec.ts index 56f5254..0e5023a 100644 --- a/e2e/specs/queue-selection.spec.ts +++ b/e2e/specs/queue-selection.spec.ts @@ -103,12 +103,17 @@ async function queueSixAndOpen(app: Page): Promise { * * `explore-link` routes a track name to its *album's* page, so a * track with no album renders a name that navigates nowhere — and - * the fixture library deliberately contains two (`01 Tone A`, - * `02 Tone B`). Which tracks arrive first is `audio_files.id` - * order, i.e. the order the **scan** inserted them, which depends - * on concurrency and directory traversal: locally the first eight - * all had albums and the spec passed twice over, and CI rebuilds - * its seed with a real scan and got a different eight. + * the fixture library deliberately contains two, + * `unsorted/no-tags-at-all.mp3` and `unsorted/title-only.mp3`. + * (It contained four until #104: the two WAVs under `Field + * Recordings/Test Tones` had been tagged on disk all along and + * scan in with their album now, so they are ordinary tracks and + * not examples of this.) Which tracks arrive first is + * `audio_files.id` order, i.e. the order the **scan** inserted + * them, which depends on concurrency and directory traversal: + * locally the first eight all had albums and the spec passed twice + * over, and CI rebuilds its seed with a real scan and got a + * different eight. * * Asking for what the test needs is the fix. It is not a * narrowing: every assertion here wants an ordinary track, and -- 2.54.0