yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Explore: materialise multi-artist credits locally so they survive an absent catalog #89

New Issue
Open
opened 2026-08-18 20:05:28 +00:00 by yonlu · 0 comments
yonlu commented 2026-08-18 20:05:28 +00:00
Owner
Copy Link
Copy Source

Multi-artist credits are read from the catalog tables (artist_credit_part / artist_credit_ref), keyed on the recording MBID. That works for both Explore and the library's own lists, which is why it needed no local table — but it means credits vanish when the catalog is absent or still downloading, which is precisely the no-index state ShelfPage.State exists to describe.

A library ought to stand on its own. Materialising the decomposition into a local file_artists table is what makes it.

Phase 3 of .planning/plans/active/015-multi-artist-credits.md, deleted in favour of this issue and its sibling.

Why it is not built yet, deliberately

file_artists is not declared in sql/schemas/. Nothing writes or reads it, and a schema file plus a datamap entry describing behaviour that does not exist is a claim the code cannot back. Declaring it is part of this work, not a prerequisite done in advance.

It was originally a prerequisite for rendering credits at all; Phase 4 landed without it, which demoted this from blocker to offline-resilience.

What it involves

  • Declare the table in sql/schemas/ and classify it in backend/datamap — it is Derived (rebuildable from the catalog), not Authored, so it is free to retire on a stale shape.
  • Materialise on the path that already knows a file's recording MBID, so a scanned or retagged file gets its decomposition without a separate pass.
  • Read locally first and fall back to the catalog, which is the shape every other read in explore already has.

Ordering

There is no point doing this before the credit tables actually ship in a published artifact — there would be nothing to materialise from. Do it after that lands.

Done when

A track credited to more than one artist still renders every artist as a link with the catalog absent.

Multi-artist credits are read from the catalog tables (`artist_credit_part` / `artist_credit_ref`), keyed on the recording MBID. That works for both Explore and the library's own lists, which is why it needed no local table — but it means **credits vanish when the catalog is absent or still downloading**, which is precisely the `no-index` state `ShelfPage.State` exists to describe. A library ought to stand on its own. Materialising the decomposition into a local `file_artists` table is what makes it. Phase 3 of `.planning/plans/active/015-multi-artist-credits.md`, deleted in favour of this issue and its sibling. ## Why it is not built yet, deliberately `file_artists` is **not declared** in `sql/schemas/`. Nothing writes or reads it, and a schema file plus a `datamap` entry describing behaviour that does not exist is a claim the code cannot back. Declaring it is part of this work, not a prerequisite done in advance. It was originally a prerequisite for rendering credits at all; Phase 4 landed without it, which demoted this from blocker to offline-resilience. ## What it involves - Declare the table in `sql/schemas/` and classify it in `backend/datamap` — it is **Derived** (rebuildable from the catalog), not Authored, so it is free to retire on a stale shape. - Materialise on the path that already knows a file's recording MBID, so a scanned or retagged file gets its decomposition without a separate pass. - Read locally first and fall back to the catalog, which is the shape every other read in `explore` already has. ## Ordering There is no point doing this before the credit tables actually ship in a published artifact — there would be nothing to materialise from. Do it after that lands. ## Done when A track credited to more than one artist still renders every artist as a link with the catalog absent.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Explore Area/Metadata Kind/Enhancement Platform/Android Platform/Desktop
Priority
Low
4
Status
Blocked
1
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#88 Explore: run the credit ingest against the real dump and publish an artifact that carries credits
yonlu/yellowjacket
Reference: yonlu/yellowjacket#89