yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Six backend methods are bound to the frontend and called by nothing — wire or remove #86

New Issue
Open
opened 2026-08-18 20:05:18 +00:00 by yonlu · 0 comments
yonlu commented 2026-08-18 20:05:18 +00:00
Owner
Copy Link
Copy Source

Six methods are bound to the frontend and have no call site in frontend/src:

  • GetPopularityBatch
  • GetTrackLyrics
  • GenerateMix
  • GetArtistPlayCount
  • GetLibrarySimilarArtists
  • GetCandidateThumbnail

Each is either a feature that was never wired up or a batch shape nobody reached for. They cost a binding, a generated TypeScript surface and a maintenance claim, and their existence is presumably why the N+1s the API-call audit found were not noticed — the batch helper existed, so the problem looked solved.

Converted from finding 3 of .planning/plans/pending/012-api-call-audit.md, whose other three findings have shipped; the plan moves to completed/.

What the decision is

For each: wire it to the call site it was written for, or delete it and its binding. GenerateMix and GetTrackLyrics in particular are worth a separate answer about whether the feature is live at all — a bound method for a feature that does not exist is a promise the UI never makes.

Two traps, both already sprung once

Grep both languages before removing a bound method. CheckLibraryMBIDs was reported as dead in the same audit and is not: downloadcatalog.go:152 calls it from Go, one MBID at a time. Deleting it broke the build, which is how that was found. Read "no frontend caller" as exactly that.

GetArtistImages is not the batch helper it looks like. It resolves names through libMBID.AllArtistMBIDs(), so it only answers for artists in the library — the exact set Explore's search results are not. It needs an MBID-keyed sibling or a replacement, not a call site. (GetArtistImagesCachedPaths is the one that landed for the Explore path.)

Done when

Every method bound to the frontend has a caller in frontend/src, or is gone.

Six methods are bound to the frontend and have **no call site in `frontend/src`**: - `GetPopularityBatch` - `GetTrackLyrics` - `GenerateMix` - `GetArtistPlayCount` - `GetLibrarySimilarArtists` - `GetCandidateThumbnail` Each is either a feature that was never wired up or a batch shape nobody reached for. They cost a binding, a generated TypeScript surface and a maintenance claim, and their existence is presumably why the N+1s the API-call audit found were not noticed — the batch helper existed, so the problem looked solved. Converted from finding 3 of `.planning/plans/pending/012-api-call-audit.md`, whose other three findings have shipped; the plan moves to `completed/`. ## What the decision is For each: wire it to the call site it was written for, or delete it and its binding. `GenerateMix` and `GetTrackLyrics` in particular are worth a separate answer about whether the feature is live at all — a bound method for a feature that does not exist is a promise the UI never makes. ## Two traps, both already sprung once **Grep both languages before removing a bound method.** `CheckLibraryMBIDs` was reported as dead in the same audit and is not: `downloadcatalog.go:152` calls it from Go, one MBID at a time. Deleting it broke the build, which is how that was found. Read "no frontend caller" as exactly that. **`GetArtistImages` is not the batch helper it looks like.** It resolves names through `libMBID.AllArtistMBIDs()`, so it only answers for artists **in the library** — the exact set Explore's search results are not. It needs an MBID-keyed sibling or a replacement, not a call site. (`GetArtistImagesCachedPaths` is the one that landed for the Explore path.) ## Done when Every method bound to the frontend has a caller in `frontend/src`, or is gone.
yonlu added the
Priority
Low
4
Platform/DesktopArea/ExploreKind/Enhancement labels 2026-08-18 20:05:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Explore Kind/Enhancement Platform/Desktop
Priority
Low
4
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#86