fix(explore): stop labelling the album tracklist "TRACKLIST" #76

2026-08-18T15:06:29Z

logan commented

2026-08-18 15:06:29 +00:00

Closes #9.

The heading labelled the only thing on the page that was already obvious. What goes is the ink, not the element — the section is a landmark and the page’s heading structure runs through it, so the <h3> stays and is clipped by sr-only (clip-path, never display: none, which would take it out of the accessibility tree along with the layout).

All four render branches — loading, no-release-data, empty tracklist and the real one — are changed together, since a heading that is visible in the error case and hidden in the normal one is worse than either.

Test. frontend/test/components/album-tracklist-heading.test.ts: the heading is still in the tree, occupies no space, and is neither display: none nor visibility: hidden.

Closes #9. The heading labelled the only thing on the page that was already obvious. What goes is the **ink, not the element** — the section is a landmark and the page’s heading structure runs through it, so the `<h3>` stays and is clipped by `sr-only` (`clip-path`, never `display: none`, which would take it out of the accessibility tree along with the layout). All four render branches — loading, no-release-data, empty tracklist and the real one — are changed together, since a heading that is visible in the error case and hidden in the normal one is worse than either. **Test.** `frontend/test/components/album-tracklist-heading.test.ts`: the heading is still in the tree, occupies no space, and is neither `display: none` nor `visibility: hidden`.

logan added 1 commit 2026-08-18 15:06:30 +00:00

fix(explore): stop labelling the album tracklist "TRACKLIST"

CI / check (push) Skipped

CI / e2e (push) Skipped

CI / check (pull_request) Successful in 2m31s

Details

CI / e2e (pull_request) Successful in 6m9s

Details

266e7032dd

A list of numbered titles with durations, under the album's cover, was
the one thing on the page carrying a word above it saying what it is.

What goes is the ink and not the element: the section is a landmark and
the page's heading structure runs through it, so the h3 stays and is
clipped the way sr-only clips -- never display:none, which would take
it out of the accessibility tree along with the layout.

Refs #9

logan referenced this pull request

2026-08-18 15:41:56 +00:00

Small-fix batch: eleven issues from the desktop backlog #83

logan commented

2026-08-18 15:44:23 +00:00

Rolled into #83 and closed here — the commit is preserved as a merge on that branch, so it lands with its authorship and this PR's diff intact.

Batched deliberately: release.yml cuts a release on every push to main, so merging these one at a time would produce seven or eight releases for one afternoon of small fixes. #83 is one push and therefore one version.

The full gate was run against the combined tree rather than per branch: make lint (3 configs), make test (3 configs, -race), make ui-test (836), make e2e chromium (114), plus bindings/skill/commit checks.

Rolled into #83 and closed here — the commit is preserved as a merge on that branch, so it lands with its authorship and this PR's diff intact. Batched deliberately: `release.yml` cuts a release on **every** push to `main`, so merging these one at a time would produce seven or eight releases for one afternoon of small fixes. #83 is one push and therefore one version. The full gate was run against the combined tree rather than per branch: `make lint` (3 configs), `make test` (3 configs, `-race`), `make ui-test` (836), `make e2e` chromium (114), plus bindings/skill/commit checks.

logan closed this pull request

2026-08-18 15:44:23 +00:00

logan referenced this issue from a commit

2026-08-18 16:18:37 +00:00

Small-fix batch: ten issues from the desktop backlog (#83)

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#76