fix(explore): stop hiding the request badge until the row is hovered #74

2026-08-18T15:02:57Z

logan commented

2026-08-18 15:02:57 +00:00

Refs #33 — rebased to the half that #82 does not cover.

#82 fixes the repaint (requestUpdate() on the downloadStore subscription, and on the init() path too, which my original did not) and carries its own test. That commit is better than mine was; this PR no longer contains it and now merges clean with fix/small-issue-batch in either order.

What is left is the second half of what #33 reports — "the button should not be appearing on hover, they should just be there." The badge was opacity: 0 until :hover/:focus-within. That rule was inherited from the green ticks it replaced, and it does not survive the reason those were removed: a tick marked the common case, while this marks the rows that are not here. A mark on the exception is the information on this page, and one that only exists under the pointer cannot be seen, counted, or reached with a finger.

Tests. album-request-badge-visibility.test.ts (renamed from the file that collided with #82’s): computed opacity is 1 unhovered, and the badge is still only on rows with something to request — always-visible is not the same as everywhere, and a badge on an owned row would be the column of ticks this page deliberately stopped drawing.

Refs #33 — **rebased to the half that #82 does not cover.** #82 fixes the repaint (`requestUpdate()` on the `downloadStore` subscription, and on the `init()` path too, which my original did not) and carries its own test. That commit is better than mine was; this PR no longer contains it and now merges clean with `fix/small-issue-batch` in either order. What is left is the second half of what #33 reports — *"the button should not be appearing on hover, they should just be there."* The badge was `opacity: 0` until `:hover`/`:focus-within`. That rule was inherited from the green ticks it replaced, and it does not survive the reason those were removed: a tick marked the **common** case, while this marks the rows that are *not* here. A mark on the exception is the information on this page, and one that only exists under the pointer cannot be seen, counted, or reached with a finger. **Tests.** `album-request-badge-visibility.test.ts` (renamed from the file that collided with #82’s): computed `opacity` is 1 unhovered, and the badge is still only on rows with something to request — always-visible is not the same as everywhere, and a badge on an owned row would be the column of ticks this page deliberately stopped drawing.

logan changed title from ~~fix(explore): repaint the tracklist when a track is requested~~ to fix(explore): stop hiding the request badge until the row is hovered

2026-08-18 15:32:21 +00:00

logan added 1 commit 2026-08-18 15:32:22 +00:00

fix(explore): stop hiding the request badge until the row is hovered

CI / e2e (push) Skipped

CI / check (push) Skipped

CI / check (pull_request) Successful in 2m29s

Details

CI / e2e (pull_request) Canceled after 0s

Details

73dc80bdc9

The badge on a row you do not own was transparent until the row was
hovered or focused. That rule was inherited from the green ticks it
replaced, and it does not survive the reason those went: a tick marked
the *common* case, while this marks the rows that are not here. A mark
on the exception is the information on this page, and one that appears
only under the pointer cannot be seen, counted, or reached by anyone
driving the app with a finger.

The repaint half of #33 is fixed in #82; this is only the visibility,
rebased to leave that alone.

Refs #33

logan force-pushed fix/album-track-request-badge from b1ef9d63d4 to 73dc80bdc9

2026-08-18 15:32:22 +00:00

Compare

logan referenced this pull request

2026-08-18 15:32:53 +00:00

Fix/small issue batch #82

logan referenced this pull request

2026-08-18 15:41:56 +00:00

Small-fix batch: eleven issues from the desktop backlog #83

logan commented

2026-08-18 15:44:22 +00:00

Rolled into #83 and closed here — the commit is preserved as a merge on that branch, so it lands with its authorship and this PR's diff intact.

Batched deliberately: release.yml cuts a release on every push to main, so merging these one at a time would produce seven or eight releases for one afternoon of small fixes. #83 is one push and therefore one version.

The full gate was run against the combined tree rather than per branch: make lint (3 configs), make test (3 configs, -race), make ui-test (836), make e2e chromium (114), plus bindings/skill/commit checks.

Rolled into #83 and closed here — the commit is preserved as a merge on that branch, so it lands with its authorship and this PR's diff intact. Batched deliberately: `release.yml` cuts a release on **every** push to `main`, so merging these one at a time would produce seven or eight releases for one afternoon of small fixes. #83 is one push and therefore one version. The full gate was run against the combined tree rather than per branch: `make lint` (3 configs), `make test` (3 configs, `-race`), `make ui-test` (836), `make e2e` chromium (114), plus bindings/skill/commit checks.

logan closed this pull request

2026-08-18 15:44:22 +00:00

logan referenced this pull request

2026-08-18 15:44:33 +00:00

Fix/small issue batch #82

logan referenced this issue from a commit

2026-08-18 16:18:37 +00:00

Small-fix batch: ten issues from the desktop backlog (#83)