yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Desktop: do not schedule wanted-list checks when no download client is configured #37

New Issue
Closed
opened 2026-08-18 05:56:10 +00:00 by logan · 1 comment
logan commented 2026-08-18 05:56:10 +00:00
Collaborator
Copy Link
Copy Source

Report

Users should still be able to add things to the wanted list without a download client. But with no client configured, those requests should not be part of the periodic search job — I saw "next check in 6 hours" against a wanted album on an install with no client.

Findings

  • downloadStore.available already reports whether a client is configured (it is what gates canDownload on the album page).
  • The reconcile/search pass is a registered job (backend/jobs), so it is visible in the indicator — meaning a pointless pass is also visible noise, on top of being pointless.

Direction

  • Backend: skip scheduling the check when no client is configured, and do not compute or emit a "next check" time.
  • Frontend: where a request row would show "next check in ...", say what is actually true instead — "no download client configured", with a link to Settings.
  • When a client is configured later, the pass should start without a restart (the config is read at the moment the pass would run, matching how AllowMeteredCatalogDownload is handled).
**Report** Users should still be able to add things to the wanted list without a download client. But with no client configured, those requests should not be part of the periodic search job — I saw "next check in 6 hours" against a wanted album on an install with no client. **Findings** - `downloadStore.available` already reports whether a client is configured (it is what gates `canDownload` on the album page). - The reconcile/search pass is a registered job (`backend/jobs`), so it is visible in the indicator — meaning a pointless pass is also visible noise, on top of being pointless. **Direction** - Backend: skip scheduling the check when no client is configured, and do not compute or emit a "next check" time. - Frontend: where a request row would show "next check in ...", say what is actually true instead — "no download client configured", with a link to Settings. - When a client *is* configured later, the pass should start without a restart (the config is read at the moment the pass would run, matching how `AllowMeteredCatalogDownload` is handled).
logan added the Area/DownloadsKind/EnhancementPlatform/Desktop
Priority
Medium
3
 labels 2026-08-18 14:36:10 +00:00
logan self-assigned this 2026-08-18 15:17:39 +00:00
yonlu commented 2026-08-18 19:56:53 +00:00
Owner
Copy Link
Copy Source

Shipped in main as 760021e — fix(downloads): stop searching a list there is nothing to search with — merged through #83. This was listed in that PR's Closes line but did not close automatically; closing it now.

Shipped in `main` as `760021e` — fix(downloads): stop searching a list there is nothing to search with — merged through #83. This was listed in that PR's `Closes` line but did not close automatically; closing it now.
yonlu closed this issue 2026-08-18 19:56:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Downloads Kind/Enhancement Platform/Desktop
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees logan
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#37