yonlu/yellowjacket
1
1
Fork 0
Code Issues 55 Pull Requests 6 Actions Packages Projects Releases 12 Wiki Activity

Desktop: smart playlists can only AND their rules — no OR #35

New Issue
Closed
opened 2026-08-18 05:56:10 +00:00 by logan · 0 comments
logan commented 2026-08-18 05:56:10 +00:00
Collaborator
Copy Link
Copy Source

Report

The smart playlist creator only seems to do AND. I wanted a playlist drawing on several genres, and there is no way to express "genre is X OR genre is Y".

Findings

Confirmed in the backend: backend/smartplaylist/smartplaylist.go:182 — return strings.Join(conditions, " AND "), args, nil. The conjunction is hardcoded; there is no match-type on the rule set and no grouping.

Direction

Two levels, and the first probably suffices:

  1. Match all / match any — a matchType on the playlist, joined with AND or OR. One schema field, one join change, one radio in smart-playlist-editor.
  2. Rule groups — nested groups each with their own conjunction. Much more UI, and only worth it if 1 proves insufficient.

Either way: a multi-valued field needs care. Genre is a genuine many-to-many (file_genres), so "genre is any of (X, Y)" is better expressed as an IN on one rule than as two OR'd rules — consider an "is one of" operator for genre alongside the match-type work. Also remember a query file must be ASCII (sqlc rewrites by byte offset) and that this builder emits raw SQL rather than sqlc queries.

**Report** The smart playlist creator only seems to do AND. I wanted a playlist drawing on several genres, and there is no way to express "genre is X OR genre is Y". **Findings** Confirmed in the backend: `backend/smartplaylist/smartplaylist.go:182` — `return strings.Join(conditions, " AND "), args, nil`. The conjunction is hardcoded; there is no match-type on the rule set and no grouping. **Direction** Two levels, and the first probably suffices: 1. **Match all / match any** — a `matchType` on the playlist, joined with `AND` or `OR`. One schema field, one join change, one radio in `smart-playlist-editor`. 2. **Rule groups** — nested groups each with their own conjunction. Much more UI, and only worth it if 1 proves insufficient. Either way: a multi-valued field needs care. Genre is a genuine many-to-many (`file_genres`), so "genre is any of (X, Y)" is better expressed as an `IN` on one rule than as two OR'd rules — consider an "is one of" operator for genre alongside the match-type work. Also remember a query file must be ASCII (sqlc rewrites by byte offset) and that this builder emits raw SQL rather than sqlc queries.
yonlu was assigned by logan 2026-08-18 15:32:38 +00:00
logan closed this issue 2026-08-18 16:18:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Library-UI Kind/Feature Platform/Desktop
Priority
Medium
3
Reviewed
Confirmed
1
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#35