yonlu/yellowjacket
1
1 Fork 0
Code Issues 61 Pull Requests 1 Actions Packages Projects Releases 13 Wiki Activity

ListenBrainz top-recordings-for-artist answers 401 and is retried for every artist #284

New Issue
Open
opened 2026-10-06 02:40:30 +00:00 by yonlu · 1 comment
yonlu commented 2026-10-06 02:40:30 +00:00
Owner
Copy link
Copy source

Every call to https://api.listenbrainz.org/1/popularity/top-recordings-for-artist/<mbid> now answers 401:

$ curl -s -o /dev/null -w '%{http_code}\n' https://api.listenbrainz.org/1/popularity/top-recordings-for-artist/6f2f87e7-3ce9-4f1c-81dd-6f068a78cf26
401

backend/explore/searchindex.go fetchTopRecordings (and listenbrainz.go:70) call it without a token for every artist the search-index builder visits. In one minute of a dev run against a real library, .dev/app.log logged it 399 times. Each is a wasted rate-limited request and a log line, and the recordings half of the index is never filled.

Expected: a 401 is treated as an answer — stop asking for the session (or send a token if the user has one), record it, and do not retry per artist.

Every call to `https://api.listenbrainz.org/1/popularity/top-recordings-for-artist/<mbid>` now answers **401**: ``` $ curl -s -o /dev/null -w '%{http_code}\n' https://api.listenbrainz.org/1/popularity/top-recordings-for-artist/6f2f87e7-3ce9-4f1c-81dd-6f068a78cf26 401 ``` `backend/explore/searchindex.go` `fetchTopRecordings` (and `listenbrainz.go:70`) call it without a token for every artist the search-index builder visits. In one minute of a dev run against a real library, `.dev/app.log` logged it 399 times. Each is a wasted rate-limited request and a log line, and the recordings half of the index is never filled. Expected: a 401 is treated as an answer — stop asking for the session (or send a token if the user has one), record it, and do not retry per artist.
yonlu self-assigned this 2026-10-06 02:40:47 +00:00
yonlu added the
Status
In Progress
 label 2026-10-06 02:40:48 +00:00
yonlu commented 2026-10-06 02:40:48 +00:00
Author
Owner
Copy link
Copy source

Plan 023 (scoped library payloads), in order 279 → 281 → 280 → 282, then 283 and 284. Measured before/after with make perf against the bulk seed.

Plan 023 (scoped library payloads), in order 279 → 281 → 280 → 282, then 283 and 284. Measured before/after with make perf against the bulk seed.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Explore Kind/Bug Platform/Android Platform/Desktop
Priority
Medium
3
Status
In Progress
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#284